From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9DDC3A59B for ; Sat, 17 Aug 2019 03:48:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B63C21743 for ; Sat, 17 Aug 2019 03:48:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566013694; bh=HxsSwNwiVHXbty9BjtNr6DuJclpMy2U5qUXHSszZxrM=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=h4VSj0A2bd93D5t6cBer7HvbHCuyk8yDZSPT98u+b2ugfFeiRYKRB+O4wcibT1QCo x8HT9BvuWHX4zQ5mZlO7aiIvC2ZZXeTN3VRiMQxohNy86MdJuow28Eqw13KgXE3WPA pLKpWwm/OgE0sgpTR/wvL7szVeRNSTzNDqcJiceg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726087AbfHQDsN (ORCPT ); Fri, 16 Aug 2019 23:48:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:42612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbfHQDsN (ORCPT ); Fri, 16 Aug 2019 23:48:13 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5435B21721; Sat, 17 Aug 2019 03:48:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566013692; bh=HxsSwNwiVHXbty9BjtNr6DuJclpMy2U5qUXHSszZxrM=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=e8Au8v1YjIZnWREKfQOag1wlJ5dlrZgSMRbp90GK5UTPY+nUl2WJc1otkEjseKTHD 3520uhhDA1MOfMC6z+SshHGl8yLV5hAyKMxhpPm5HKjtVazIzaF8qeRTw9/o/K0lqr o/oE9EuoQwMQ1Ku1q59wIcPUKdI9WFywtxJJo4W0= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20190816125225.16061-1-geert+renesas@glider.be> <20190816125225.16061-2-geert+renesas@glider.be> <20190816180123.6299720665@mail.kernel.org> Subject: Re: [PATCH 1/3] clk: renesas: mstp: Set GENPD_FLAG_ALWAYS_ON for clock domain From: Stephen Boyd Cc: Geert Uytterhoeven , Michael Turquette , "Rafael J . Wysocki" , Kevin Hilman , Ulf Hansson , Linux-Renesas , linux-clk , Linux PM list To: Geert Uytterhoeven User-Agent: alot/0.8.1 Date: Fri, 16 Aug 2019 20:48:11 -0700 Message-Id: <20190817034812.5435B21721@mail.kernel.org> Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Quoting Geert Uytterhoeven (2019-08-16 12:59:32) > Hi Stephen, >=20 > On Fri, Aug 16, 2019 at 8:01 PM Stephen Boyd wrote: > > Quoting Geert Uytterhoeven (2019-08-16 05:52:23) > > > The CPG/MSTP Clock Domain driver does not implement the > > > generic_pm_domain.power_{on,off}() callbacks, as the domain itself > > > cannot be powered down. Hence the domain should be marked as always-= on > > > by setting the GENPD_FLAG_ALWAYS_ON flag. > > > > > > This gets rid of the following boot warning on RZ/A1: > > > > > > sh_mtu2 fcff0000.timer: PM domain cpg_clocks will not be powered = off > > > > > > Signed-off-by: Geert Uytterhoeven > > > --- > > > > Are you going to add a Fixes tag? >=20 > I didn't add a Fixes tag, as there's no clear point in history where the > problem appeared: the Clock Domain code in this driver predates the > introduction of the GENPD_FLAG_ALWAYS_ON flag by ca. 18 months. >=20 > Candidates are: > d716f4798ff8c65a ("PM / Domains: Support IRQ safe PM domains") > ffaa42e8a40b7f10 ("PM / Domains: Enable users of genpd to specify > always on PM domains") > 075c37d59ecd4a8b ("PM / Domains: Don't warn about IRQ safe device for > an always on PM domain") >=20 > Do you think it's worth adding one or more of the above? > Thanks! >=20 Well is it actually a problem to not specify the flag? I guess it's just a potential problem if the genpd is ever powered off, but given that the governor decides to leave it always enabled it doesn't actually matter? So it's not really fixing anything besides silencing a harmless warning?