From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A53C3A59D for ; Mon, 19 Aug 2019 11:17:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB50E20989 for ; Mon, 19 Aug 2019 11:17:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566213444; bh=SBx9yLs7l7QkTChHV7UVCy8UM+MrlbLRIJn2z15OfDI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=0zga0TQnffWz4rMq8mtfBUeyU0Ro1KK+FbIaYEu5fxtYDVpOtSqoOUs9WSRla9BSa nAZ7SXu7mRsPklB2Mao4A6Gykxa5eGwfyhNqr8JdWpmPVUuas+yuGDF1Vd+8Dz8AUs sMOB1ziRMeBGUO/QtI8WeOVhg0u56qvk1v9EtaAw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727439AbfHSLRX (ORCPT ); Mon, 19 Aug 2019 07:17:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:32828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726987AbfHSLRX (ORCPT ); Mon, 19 Aug 2019 07:17:23 -0400 Received: from X250 (37.80-203-192.nextgentel.com [80.203.192.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7669A2086C; Mon, 19 Aug 2019 11:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566213441; bh=SBx9yLs7l7QkTChHV7UVCy8UM+MrlbLRIJn2z15OfDI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nvK/FQ2iXY/JDm0pIrjZFcxpZ/5Ywrn8G3rCKnH9pItCtPhu7x5KaNQZPPfN78WNp kGo3pDamxs/iuZmVVggukIKtRPhZMg+WoK+lqft8ohEvxYp0bc1VPbXeThX7GLJjcW fR0R7Bzkj+hUa5CZ0qceHa/iLb2woHraePmuuOX4= Date: Mon, 19 Aug 2019 13:17:08 +0200 From: Shawn Guo To: Philippe Schenker Cc: Marcel Ziswiler , Max Krummenacher , "stefan@agner.ch" , "devicetree@vger.kernel.org" , Rob Herring , Mark Rutland , Michal =?utf-8?B?Vm9rw6HEjQ==?= , Fabio Estevam , Stefan Agner , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Pengutronix Kernel Team , NXP Linux Team , Sascha Hauer Subject: Re: [PATCH v4 06/21] ARM: dts: imx7-colibri: add GPIO wakeup key Message-ID: <20190819111707.GP5999@X250> References: <20190812142105.1995-1-philippe.schenker@toradex.com> <20190812142105.1995-7-philippe.schenker@toradex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190812142105.1995-7-philippe.schenker@toradex.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 12, 2019 at 02:21:23PM +0000, Philippe Schenker wrote: > From: Stefan Agner > > Add wakeup GPIO key which is able to wake the system from sleep > modes (e.g. Suspend-to-Memory). > > Signed-off-by: Stefan Agner > Signed-off-by: Philippe Schenker > Acked-by: Marcel Ziswiler > > --- > > Changes in v4: > - Add Marcel Ziswiler's Ack > > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi | 14 ++++++++++++++ > arch/arm/boot/dts/imx7-colibri.dtsi | 7 ++++++- > 2 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > index 3f2746169181..d4dbc4fc1adf 100644 > --- a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > +++ b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > @@ -52,6 +52,20 @@ > clock-frequency = <16000000>; > }; > > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_gpiokeys>; > + > + power { > + label = "Wake-Up"; > + gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>; > + linux,code = ; > + debounce-interval = <10>; > + gpio-key,wakeup; Please check Documentation/devicetree/bindings/power/wakeup-source.txt Shawn > + }; > + }; > + > panel: panel { > compatible = "edt,et057090dhu"; > backlight = <&bl>; > diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi > index cab40d22d24e..5347ed38acb2 100644 > --- a/arch/arm/boot/dts/imx7-colibri.dtsi > +++ b/arch/arm/boot/dts/imx7-colibri.dtsi > @@ -741,12 +741,17 @@ > > pinctrl_gpio_lpsr: gpio1-grp { > fsl,pins = < > - MX7D_PAD_LPSR_GPIO1_IO01__GPIO1_IO1 0x59 > MX7D_PAD_LPSR_GPIO1_IO02__GPIO1_IO2 0x59 > MX7D_PAD_LPSR_GPIO1_IO03__GPIO1_IO3 0x59 > >; > }; > > + pinctrl_gpiokeys: gpiokeysgrp { > + fsl,pins = < > + MX7D_PAD_LPSR_GPIO1_IO01__GPIO1_IO1 0x19 > + >; > + }; > + > pinctrl_i2c1: i2c1-grp { > fsl,pins = < > MX7D_PAD_LPSR_GPIO1_IO05__I2C1_SDA 0x4000007f > -- > 2.22.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7400CC3A59D for ; Mon, 19 Aug 2019 11:17:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 416BD2085A for ; Mon, 19 Aug 2019 11:17:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MI0mIcQ7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nvK/FQ2i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 416BD2085A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RcSaSZt5G65Vo+d/i0mCo6am9gfBtmYc81jXfZSMGGk=; b=MI0mIcQ789jPXR j3xeOureDMhpf5rfcZq0SWOwW0AZKpHWnDAFdxEYifAXHJ849JIfzyWPjT0NJgK+qGIdG9y7jyxkD on1K7zFdsx+p08MRdeP6FJvPOIVXn3uZ+skCVy+DeMNdxBazfQF4VY+JYNlAOmUcUlo7pHz+/V3+Y 9Dytodi58PqvdtXU0ldT1/PtohN+6ce7DEETUc/Kz0shMrI0z+E0quueu0b577F6b32Y3xP92SDot exfSNuTxogKcsZz3B96c2raZ2mjqKsEOQqOCjqsTUJvZ6qZNllf5qVuou8ysJev5HEFhQgam+louk XOxNJh7/JFvyhIW3GjUw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzffB-0001Dq-D0; Mon, 19 Aug 2019 11:17:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzff8-00015v-9V for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2019 11:17:23 +0000 Received: from X250 (37.80-203-192.nextgentel.com [80.203.192.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7669A2086C; Mon, 19 Aug 2019 11:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566213441; bh=SBx9yLs7l7QkTChHV7UVCy8UM+MrlbLRIJn2z15OfDI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nvK/FQ2iXY/JDm0pIrjZFcxpZ/5Ywrn8G3rCKnH9pItCtPhu7x5KaNQZPPfN78WNp kGo3pDamxs/iuZmVVggukIKtRPhZMg+WoK+lqft8ohEvxYp0bc1VPbXeThX7GLJjcW fR0R7Bzkj+hUa5CZ0qceHa/iLb2woHraePmuuOX4= Date: Mon, 19 Aug 2019 13:17:08 +0200 From: Shawn Guo To: Philippe Schenker Subject: Re: [PATCH v4 06/21] ARM: dts: imx7-colibri: add GPIO wakeup key Message-ID: <20190819111707.GP5999@X250> References: <20190812142105.1995-1-philippe.schenker@toradex.com> <20190812142105.1995-7-philippe.schenker@toradex.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190812142105.1995-7-philippe.schenker@toradex.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190819_041722_376586_D471916F X-CRM114-Status: GOOD ( 18.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , Michal =?utf-8?B?Vm9rw6HEjQ==?= , Pengutronix Kernel Team , Stefan Agner , Marcel Ziswiler , Sascha Hauer , "linux-kernel@vger.kernel.org" , "stefan@agner.ch" , Rob Herring , NXP Linux Team , Max Krummenacher , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 12, 2019 at 02:21:23PM +0000, Philippe Schenker wrote: > From: Stefan Agner > > Add wakeup GPIO key which is able to wake the system from sleep > modes (e.g. Suspend-to-Memory). > > Signed-off-by: Stefan Agner > Signed-off-by: Philippe Schenker > Acked-by: Marcel Ziswiler > > --- > > Changes in v4: > - Add Marcel Ziswiler's Ack > > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi | 14 ++++++++++++++ > arch/arm/boot/dts/imx7-colibri.dtsi | 7 ++++++- > 2 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > index 3f2746169181..d4dbc4fc1adf 100644 > --- a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > +++ b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > @@ -52,6 +52,20 @@ > clock-frequency = <16000000>; > }; > > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_gpiokeys>; > + > + power { > + label = "Wake-Up"; > + gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>; > + linux,code = ; > + debounce-interval = <10>; > + gpio-key,wakeup; Please check Documentation/devicetree/bindings/power/wakeup-source.txt Shawn > + }; > + }; > + > panel: panel { > compatible = "edt,et057090dhu"; > backlight = <&bl>; > diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi > index cab40d22d24e..5347ed38acb2 100644 > --- a/arch/arm/boot/dts/imx7-colibri.dtsi > +++ b/arch/arm/boot/dts/imx7-colibri.dtsi > @@ -741,12 +741,17 @@ > > pinctrl_gpio_lpsr: gpio1-grp { > fsl,pins = < > - MX7D_PAD_LPSR_GPIO1_IO01__GPIO1_IO1 0x59 > MX7D_PAD_LPSR_GPIO1_IO02__GPIO1_IO2 0x59 > MX7D_PAD_LPSR_GPIO1_IO03__GPIO1_IO3 0x59 > >; > }; > > + pinctrl_gpiokeys: gpiokeysgrp { > + fsl,pins = < > + MX7D_PAD_LPSR_GPIO1_IO01__GPIO1_IO1 0x19 > + >; > + }; > + > pinctrl_i2c1: i2c1-grp { > fsl,pins = < > MX7D_PAD_LPSR_GPIO1_IO05__I2C1_SDA 0x4000007f > -- > 2.22.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel