All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
	linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Michal Hocko <mhocko@kernel.org>,
	Mel Gorman <mgorman@techsingularity.net>,
	Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH 1/3] mm, page_owner: record page owner for each subpage
Date: Mon, 19 Aug 2019 14:57:51 +0300	[thread overview]
Message-ID: <20190819115751.bost7nrac4at7pq3@black.fi.intel.com> (raw)
In-Reply-To: <20190819115551.xkgnpr7zmaqpuebi@black.fi.intel.com>

On Mon, Aug 19, 2019 at 11:55:51AM +0000, Kirill A. Shutemov wrote:
> > @@ -2533,6 +2534,8 @@ static void __split_huge_page(struct page *page, struct list_head *list,
> >  
> >  	remap_page(head);
> >  
> > +	split_page_owner(head, HPAGE_PMD_ORDER);
> > +
> 
> I think it has to be before remap_page(). This way nobody would be able to
> mess with the page until it has valid page_owner.

Or rather next to ClearPageCompound().

-- 
 Kirill A. Shutemov

  reply	other threads:[~2019-08-19 11:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16 10:13 [PATCH 0/3] debug_pagealloc improvements through page_owner Vlastimil Babka
2019-08-16 10:13 ` [PATCH 1/3] mm, page_owner: record page owner for each subpage Vlastimil Babka
2019-08-16 14:04   ` Kirill A. Shutemov
2019-08-19 11:46     ` Vlastimil Babka
2019-08-19 11:55       ` Kirill A. Shutemov
2019-08-19 11:57         ` Kirill A. Shutemov [this message]
2019-08-19 13:11           ` Vlastimil Babka
2019-08-16 10:14 ` [PATCH 2/3] mm, page_owner: keep owner info when freeing the page Vlastimil Babka
2019-08-16 10:14 ` [PATCH 3/3] mm, page_owner, debug_pagealloc: save and dump freeing stack trace Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190819115751.bost7nrac4at7pq3@black.fi.intel.com \
    --to=kirill.shutemov@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@kernel.org \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.