From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C13C3A5A0 for ; Mon, 19 Aug 2019 23:04:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D863822CF4 for ; Mon, 19 Aug 2019 23:04:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="l2V9cPKg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728646AbfHSXEq (ORCPT ); Mon, 19 Aug 2019 19:04:46 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:38228 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728786AbfHSXDm (ORCPT ); Mon, 19 Aug 2019 19:03:42 -0400 Received: by mail-pg1-f195.google.com with SMTP id e11so2037319pga.5 for ; Mon, 19 Aug 2019 16:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+HPcPs0/zlCUibj+7sx/QSMq53DKHKeHt3X4baMNzZs=; b=l2V9cPKgC+xQf+M9Eq7V3R8A3hyhWD12bHUmsJxWIyt0fstaXxqCmLfeGxRgmVOXqy 7B1Apsgv8PJHo4NM/w9wVyo2A83K3EejfwDWpzf/9jW7IpeJTjDRkJKdwAvN4ABQVs/T fVyIrAOR44GEq3ZqXg6hS5HgyrNA1aO74nqpvIdI2IG9dSUUkVeBZtCx9SCoI3eEe25L AYrm9KmrTi6I0zf05rvkRW/Qcdwl8mYmmX0sGPiRfgn10oRr9LFfYeWsQjU6v3kbpzvT xAWummgxsvsYfQWrtNRvuIYBsP92PNtkufKW7vNvuhVChCUj0Bmg+T+zSHkPFrlvsBEz yTLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+HPcPs0/zlCUibj+7sx/QSMq53DKHKeHt3X4baMNzZs=; b=oqWSsuQoJFiWI9+5PQqKrH+l+FJkm0tjJXoHW2oJk/NrWRBtYiDAwEf45KcSPB5mZo 3tRtsCGd8rzhZ70aBj63I7nqKVT/yi8J/OSRfrqH75PDDlAEYJ+3f85I2hvn6+PTKX/w HiV1cbiGJDrHm+XXtvwHVpRWhB72mDCpQxeYUvN1f5JyZv6RqyDhGAB40rcMuSBuwnPR zkrnxWBS9o5nGfoUokayCMslWvBNQbRg8WAjT6vwla9oPNsUlGDmyBZBBRRWvCh5IyHx maDL0DQHwGFhaA8wObGOLLcTNgXcjbwpauqX12TntsepFsXIKzik9jA6SFGC7UUov/6V BQug== X-Gm-Message-State: APjAAAWVAbEi1ykFVHA+/HR3wNj7Qi30WsGdk6gWOuRcltgJGhja5/Gy 8IQaedGieqmhDyKLk5D4mQ3SKAwdUsY= X-Google-Smtp-Source: APXvYqyw7LbadLphD6JSmUioN4e4iV4Ibw8oT+is92wCfKEWMmhG+Ndg2xlLGksLs39nRlBJXygTng== X-Received: by 2002:a17:90b:8c5:: with SMTP id ds5mr23549322pjb.142.1566255820961; Mon, 19 Aug 2019 16:03:40 -0700 (PDT) Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id j15sm17256509pfr.146.2019.08.19.16.03.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2019 16:03:40 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Rongrong Zou , Xinliang Liu , David Airlie , Daniel Vetter , dri-devel , Sam Ravnborg Subject: [PATCH v4 10/25] drm: kirin: Move workqueue to ade_hw_ctx structure Date: Mon, 19 Aug 2019 23:03:06 +0000 Message-Id: <20190819230321.56480-11-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190819230321.56480-1-john.stultz@linaro.org> References: <20190819230321.56480-1-john.stultz@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The workqueue used to reset the display when we hit an LDI underflow error is ADE specific, so since this patch series works to make the kirin_crtc structure more generic, move the workqueue to the ade_hw_ctx structure instead. Cc: Rongrong Zou Cc: Xinliang Liu Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravnborg Acked-by: Xinliang Liu Reviewed-by: Sam Ravnborg Signed-off-by: John Stultz --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c index 8f50115a22d8..191ee59f68b6 100644 --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c @@ -52,6 +52,7 @@ struct ade_hw_ctx { struct clk *media_noc_clk; struct clk *ade_pix_clk; struct reset_control *reset; + struct work_struct display_reset_wq; bool power_on; int irq; @@ -61,7 +62,6 @@ struct ade_hw_ctx { struct kirin_crtc { struct drm_crtc base; void *hw_ctx; - struct work_struct display_reset_wq; bool enable; }; @@ -349,9 +349,9 @@ static void ade_crtc_disable_vblank(struct drm_crtc *crtc) static void drm_underflow_wq(struct work_struct *work) { - struct kirin_crtc *acrtc = container_of(work, struct kirin_crtc, + struct ade_hw_ctx *ctx = container_of(work, struct ade_hw_ctx, display_reset_wq); - struct drm_device *drm_dev = (&acrtc->base)->dev; + struct drm_device *drm_dev = ctx->crtc->dev; struct drm_atomic_state *state; state = drm_atomic_helper_suspend(drm_dev); @@ -362,7 +362,6 @@ static irqreturn_t ade_irq_handler(int irq, void *data) { struct ade_hw_ctx *ctx = data; struct drm_crtc *crtc = ctx->crtc; - struct kirin_crtc *kcrtc = to_kirin_crtc(crtc); void __iomem *base = ctx->base; u32 status; @@ -379,7 +378,7 @@ static irqreturn_t ade_irq_handler(int irq, void *data) ade_update_bits(base + LDI_INT_CLR, UNDERFLOW_INT_EN_OFST, MASK(1), 1); DRM_ERROR("LDI underflow!"); - schedule_work(&kcrtc->display_reset_wq); + schedule_work(&ctx->display_reset_wq); } return IRQ_HANDLED; @@ -1016,6 +1015,7 @@ static void *ade_hw_ctx_alloc(struct platform_device *pdev, if (ret) return ERR_PTR(-EIO); + INIT_WORK(&ctx->display_reset_wq, drm_underflow_wq); ctx->crtc = crtc; return ctx; @@ -1071,8 +1071,6 @@ static int ade_drm_init(struct platform_device *pdev) if (ret) return ret; - INIT_WORK(&kcrtc->display_reset_wq, drm_underflow_wq); - return 0; } -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Stultz Subject: [PATCH v4 10/25] drm: kirin: Move workqueue to ade_hw_ctx structure Date: Mon, 19 Aug 2019 23:03:06 +0000 Message-ID: <20190819230321.56480-11-john.stultz@linaro.org> References: <20190819230321.56480-1-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F6646E45B for ; Mon, 19 Aug 2019 23:03:41 +0000 (UTC) Received: by mail-pg1-x543.google.com with SMTP id m3so2021947pgv.13 for ; Mon, 19 Aug 2019 16:03:41 -0700 (PDT) In-Reply-To: <20190819230321.56480-1-john.stultz@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: lkml Cc: David Airlie , dri-devel , Xinliang Liu , Rongrong Zou , Sam Ravnborg List-Id: dri-devel@lists.freedesktop.org VGhlIHdvcmtxdWV1ZSB1c2VkIHRvIHJlc2V0IHRoZSBkaXNwbGF5IHdoZW4gd2UgaGl0IGFuIExE SQp1bmRlcmZsb3cgZXJyb3IgaXMgQURFIHNwZWNpZmljLCBzbyBzaW5jZSB0aGlzIHBhdGNoIHNl cmllcwp3b3JrcyB0byBtYWtlIHRoZSBraXJpbl9jcnRjIHN0cnVjdHVyZSBtb3JlIGdlbmVyaWMs IG1vdmUgdGhlCndvcmtxdWV1ZSB0byB0aGUgYWRlX2h3X2N0eCBzdHJ1Y3R1cmUgaW5zdGVhZC4K CkNjOiBSb25ncm9uZyBab3UgPHpvdXJvbmdyb25nQGdtYWlsLmNvbT4KQ2M6IFhpbmxpYW5nIExp dSA8ei5saXV4aW5saWFuZ0BoaXNpbGljb24uY29tPgpDYzogRGF2aWQgQWlybGllIDxhaXJsaWVk QGxpbnV4LmllPgpDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgpDYzogZHJpLWRl dmVsIDxkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnPgpDYzogU2FtIFJhdm5ib3JnIDxz YW1AcmF2bmJvcmcub3JnPgpBY2tlZC1ieTogWGlubGlhbmcgTGl1IDx6LmxpdXhpbmxpYW5nQGhp c2lsaWNvbi5jb20+ClJldmlld2VkLWJ5OiBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+ ClNpZ25lZC1vZmYtYnk6IEpvaG4gU3R1bHR6IDxqb2huLnN0dWx0ekBsaW5hcm8ub3JnPgotLS0K IGRyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24va2lyaW4va2lyaW5fZHJtX2FkZS5jIHwgMTIgKysr KystLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24va2lyaW4va2lyaW5fZHJt X2FkZS5jIGIvZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9raXJpbi9raXJpbl9kcm1fYWRlLmMK aW5kZXggOGY1MDExNWEyMmQ4Li4xOTFlZTU5ZjY4YjYgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9oaXNpbGljb24va2lyaW4va2lyaW5fZHJtX2FkZS5jCisrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9oaXNpbGljb24va2lyaW4va2lyaW5fZHJtX2FkZS5jCkBAIC01Miw2ICs1Miw3IEBAIHN0cnVj dCBhZGVfaHdfY3R4IHsKIAlzdHJ1Y3QgY2xrICptZWRpYV9ub2NfY2xrOwogCXN0cnVjdCBjbGsg KmFkZV9waXhfY2xrOwogCXN0cnVjdCByZXNldF9jb250cm9sICpyZXNldDsKKwlzdHJ1Y3Qgd29y a19zdHJ1Y3QgZGlzcGxheV9yZXNldF93cTsKIAlib29sIHBvd2VyX29uOwogCWludCBpcnE7CiAK QEAgLTYxLDcgKzYyLDYgQEAgc3RydWN0IGFkZV9od19jdHggewogc3RydWN0IGtpcmluX2NydGMg ewogCXN0cnVjdCBkcm1fY3J0YyBiYXNlOwogCXZvaWQgKmh3X2N0eDsKLQlzdHJ1Y3Qgd29ya19z dHJ1Y3QgZGlzcGxheV9yZXNldF93cTsKIAlib29sIGVuYWJsZTsKIH07CiAKQEAgLTM0OSw5ICsz NDksOSBAQCBzdGF0aWMgdm9pZCBhZGVfY3J0Y19kaXNhYmxlX3ZibGFuayhzdHJ1Y3QgZHJtX2Ny dGMgKmNydGMpCiAKIHN0YXRpYyB2b2lkIGRybV91bmRlcmZsb3dfd3Eoc3RydWN0IHdvcmtfc3Ry dWN0ICp3b3JrKQogewotCXN0cnVjdCBraXJpbl9jcnRjICphY3J0YyA9IGNvbnRhaW5lcl9vZih3 b3JrLCBzdHJ1Y3Qga2lyaW5fY3J0YywKKwlzdHJ1Y3QgYWRlX2h3X2N0eCAqY3R4ID0gY29udGFp bmVyX29mKHdvcmssIHN0cnVjdCBhZGVfaHdfY3R4LAogCQkJCQkgICAgICBkaXNwbGF5X3Jlc2V0 X3dxKTsKLQlzdHJ1Y3QgZHJtX2RldmljZSAqZHJtX2RldiA9ICgmYWNydGMtPmJhc2UpLT5kZXY7 CisJc3RydWN0IGRybV9kZXZpY2UgKmRybV9kZXYgPSBjdHgtPmNydGMtPmRldjsKIAlzdHJ1Y3Qg ZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7CiAKIAlzdGF0ZSA9IGRybV9hdG9taWNfaGVscGVyX3N1 c3BlbmQoZHJtX2Rldik7CkBAIC0zNjIsNyArMzYyLDYgQEAgc3RhdGljIGlycXJldHVybl90IGFk ZV9pcnFfaGFuZGxlcihpbnQgaXJxLCB2b2lkICpkYXRhKQogewogCXN0cnVjdCBhZGVfaHdfY3R4 ICpjdHggPSBkYXRhOwogCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9IGN0eC0+Y3J0YzsKLQlzdHJ1 Y3Qga2lyaW5fY3J0YyAqa2NydGMgPSB0b19raXJpbl9jcnRjKGNydGMpOwogCXZvaWQgX19pb21l bSAqYmFzZSA9IGN0eC0+YmFzZTsKIAl1MzIgc3RhdHVzOwogCkBAIC0zNzksNyArMzc4LDcgQEAg c3RhdGljIGlycXJldHVybl90IGFkZV9pcnFfaGFuZGxlcihpbnQgaXJxLCB2b2lkICpkYXRhKQog CQlhZGVfdXBkYXRlX2JpdHMoYmFzZSArIExESV9JTlRfQ0xSLCBVTkRFUkZMT1dfSU5UX0VOX09G U1QsCiAJCQkJTUFTSygxKSwgMSk7CiAJCURSTV9FUlJPUigiTERJIHVuZGVyZmxvdyEiKTsKLQkJ c2NoZWR1bGVfd29yaygma2NydGMtPmRpc3BsYXlfcmVzZXRfd3EpOworCQlzY2hlZHVsZV93b3Jr KCZjdHgtPmRpc3BsYXlfcmVzZXRfd3EpOwogCX0KIAogCXJldHVybiBJUlFfSEFORExFRDsKQEAg LTEwMTYsNiArMTAxNSw3IEBAIHN0YXRpYyB2b2lkICphZGVfaHdfY3R4X2FsbG9jKHN0cnVjdCBw bGF0Zm9ybV9kZXZpY2UgKnBkZXYsCiAJaWYgKHJldCkKIAkJcmV0dXJuIEVSUl9QVFIoLUVJTyk7 CiAKKwlJTklUX1dPUksoJmN0eC0+ZGlzcGxheV9yZXNldF93cSwgZHJtX3VuZGVyZmxvd193cSk7 CiAJY3R4LT5jcnRjID0gY3J0YzsKIAogCXJldHVybiBjdHg7CkBAIC0xMDcxLDggKzEwNzEsNiBA QCBzdGF0aWMgaW50IGFkZV9kcm1faW5pdChzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQog CWlmIChyZXQpCiAJCXJldHVybiByZXQ7CiAKLQlJTklUX1dPUksoJmtjcnRjLT5kaXNwbGF5X3Jl c2V0X3dxLCBkcm1fdW5kZXJmbG93X3dxKTsKLQogCXJldHVybiAwOwogfQogCi0tIAoyLjE3LjEK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==