From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CF9382020D334 for ; Mon, 19 Aug 2019 19:27:45 -0700 (PDT) Date: Tue, 20 Aug 2019 04:26:19 +0200 From: Christoph Hellwig Subject: Re: [PATCH 1/4] resource: add a not device managed request_free_mem_region variant Message-ID: <20190820022619.GA23225@lst.de> References: <20190818090557.17853-1-hch@lst.de> <20190818090557.17853-2-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: linux-nvdimm , Linux Kernel Mailing List , Bharata B Rao , Linux MM , Jason Gunthorpe , Andrew Morton , Christoph Hellwig List-ID: On Mon, Aug 19, 2019 at 06:28:30PM -0700, Dan Williams wrote: > > Previously we would loudly crash if someone passed NULL to > devm_request_free_mem_region(), but now it will silently work and the > result will leak. Perhaps this wants a: We'd still instantly crash due to the dev_name dereference, right? _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F1B1C41514 for ; Tue, 20 Aug 2019 02:26:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F39FA22CE8 for ; Tue, 20 Aug 2019 02:26:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729102AbfHTC0X (ORCPT ); Mon, 19 Aug 2019 22:26:23 -0400 Received: from verein.lst.de ([213.95.11.211]:52591 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728878AbfHTC0X (ORCPT ); Mon, 19 Aug 2019 22:26:23 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 9B59668B02; Tue, 20 Aug 2019 04:26:19 +0200 (CEST) Date: Tue, 20 Aug 2019 04:26:19 +0200 From: Christoph Hellwig To: Dan Williams Cc: Christoph Hellwig , Jason Gunthorpe , Bharata B Rao , Andrew Morton , Linux MM , Linux Kernel Mailing List , linux-nvdimm , Ira Weiny Subject: Re: [PATCH 1/4] resource: add a not device managed request_free_mem_region variant Message-ID: <20190820022619.GA23225@lst.de> References: <20190818090557.17853-1-hch@lst.de> <20190818090557.17853-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 19, 2019 at 06:28:30PM -0700, Dan Williams wrote: > > Previously we would loudly crash if someone passed NULL to > devm_request_free_mem_region(), but now it will silently work and the > result will leak. Perhaps this wants a: We'd still instantly crash due to the dev_name dereference, right?