* [PATCH] dt-bindings: sh-mobile-ceu: Rename bindings documentation file
@ 2019-08-19 14:05 Simon Horman
2019-08-20 9:52 ` Jacopo Mondi
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2019-08-19 14:05 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Rob Herring, Mark Rutland, Magnus Damm, Laurent Pinchart,
Niklas Söderlund, Geert Uytterhoeven, linux-media,
devicetree, linux-renesas-soc, Simon Horman
Renesas media binding documentation files uses a naming schema of
'renesas,<module>.txt'. Rename the SH Mobile CEU file to match this pattern.
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
Based on v5.3-rc1
---
.../bindings/media/{sh_mobile_ceu.txt => renesas,sh-mobile-ceu.txt} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename Documentation/devicetree/bindings/media/{sh_mobile_ceu.txt => renesas,sh-mobile-ceu.txt} (100%)
diff --git a/Documentation/devicetree/bindings/media/sh_mobile_ceu.txt b/Documentation/devicetree/bindings/media/renesas,sh-mobile-ceu.txt
similarity index 100%
rename from Documentation/devicetree/bindings/media/sh_mobile_ceu.txt
rename to Documentation/devicetree/bindings/media/renesas,sh-mobile-ceu.txt
--
2.11.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: sh-mobile-ceu: Rename bindings documentation file
2019-08-19 14:05 [PATCH] dt-bindings: sh-mobile-ceu: Rename bindings documentation file Simon Horman
@ 2019-08-20 9:52 ` Jacopo Mondi
2019-08-20 15:19 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Jacopo Mondi @ 2019-08-20 9:52 UTC (permalink / raw)
To: Simon Horman
Cc: Mauro Carvalho Chehab, Rob Herring, Mark Rutland, Magnus Damm,
Laurent Pinchart, Niklas Söderlund, Geert Uytterhoeven,
linux-media, devicetree, linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]
Hi Simon,
On Mon, Aug 19, 2019 at 04:05:44PM +0200, Simon Horman wrote:
> Renesas media binding documentation files uses a naming schema of
> 'renesas,<module>.txt'. Rename the SH Mobile CEU file to match this pattern.
>
The old soc-camera based sh-mobile-ceu driver has been removed one
year ago and replaced by driver/media/platform/renesas-ceu.c whose
bindings are described at
Documentation/devicetree/bindings/media/renesas,ceu.txt
Should this file be removed instead of renamed?
Thanks
j
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> Based on v5.3-rc1
> ---
> .../bindings/media/{sh_mobile_ceu.txt => renesas,sh-mobile-ceu.txt} | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> rename Documentation/devicetree/bindings/media/{sh_mobile_ceu.txt => renesas,sh-mobile-ceu.txt} (100%)
>
> diff --git a/Documentation/devicetree/bindings/media/sh_mobile_ceu.txt b/Documentation/devicetree/bindings/media/renesas,sh-mobile-ceu.txt
> similarity index 100%
> rename from Documentation/devicetree/bindings/media/sh_mobile_ceu.txt
> rename to Documentation/devicetree/bindings/media/renesas,sh-mobile-ceu.txt
> --
> 2.11.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: sh-mobile-ceu: Rename bindings documentation file
2019-08-20 9:52 ` Jacopo Mondi
@ 2019-08-20 15:19 ` Simon Horman
2019-08-21 8:17 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2019-08-20 15:19 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Mauro Carvalho Chehab, Rob Herring, Mark Rutland, Magnus Damm,
Laurent Pinchart, Niklas Söderlund, Geert Uytterhoeven,
linux-media, devicetree, linux-renesas-soc
On Tue, Aug 20, 2019 at 11:52:05AM +0200, Jacopo Mondi wrote:
> Hi Simon,
>
> On Mon, Aug 19, 2019 at 04:05:44PM +0200, Simon Horman wrote:
> > Renesas media binding documentation files uses a naming schema of
> > 'renesas,<module>.txt'. Rename the SH Mobile CEU file to match this pattern.
> >
>
> The old soc-camera based sh-mobile-ceu driver has been removed one
> year ago and replaced by driver/media/platform/renesas-ceu.c whose
> bindings are described at
> Documentation/devicetree/bindings/media/renesas,ceu.txt
>
> Should this file be removed instead of renamed?
Thanks,
I thought I had checked that but clearly I did not.
I agree the file should be removed and I'll send a revised patch
accordingly.
>
> Thanks
> j
>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > Based on v5.3-rc1
> > ---
> > .../bindings/media/{sh_mobile_ceu.txt => renesas,sh-mobile-ceu.txt} | 0
> > 1 file changed, 0 insertions(+), 0 deletions(-)
> > rename Documentation/devicetree/bindings/media/{sh_mobile_ceu.txt => renesas,sh-mobile-ceu.txt} (100%)
> >
> > diff --git a/Documentation/devicetree/bindings/media/sh_mobile_ceu.txt b/Documentation/devicetree/bindings/media/renesas,sh-mobile-ceu.txt
> > similarity index 100%
> > rename from Documentation/devicetree/bindings/media/sh_mobile_ceu.txt
> > rename to Documentation/devicetree/bindings/media/renesas,sh-mobile-ceu.txt
> > --
> > 2.11.0
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: sh-mobile-ceu: Rename bindings documentation file
2019-08-20 15:19 ` Simon Horman
@ 2019-08-21 8:17 ` Simon Horman
2019-08-21 9:30 ` Jacopo Mondi
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2019-08-21 8:17 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Mauro Carvalho Chehab, Rob Herring, Mark Rutland, Magnus Damm,
Laurent Pinchart, Niklas Söderlund, Geert Uytterhoeven,
linux-media, devicetree, linux-renesas-soc
On Tue, Aug 20, 2019 at 05:19:30PM +0200, Simon Horman wrote:
> On Tue, Aug 20, 2019 at 11:52:05AM +0200, Jacopo Mondi wrote:
> > Hi Simon,
> >
> > On Mon, Aug 19, 2019 at 04:05:44PM +0200, Simon Horman wrote:
> > > Renesas media binding documentation files uses a naming schema of
> > > 'renesas,<module>.txt'. Rename the SH Mobile CEU file to match this pattern.
> > >
> >
> > The old soc-camera based sh-mobile-ceu driver has been removed one
> > year ago and replaced by driver/media/platform/renesas-ceu.c whose
> > bindings are described at
> > Documentation/devicetree/bindings/media/renesas,ceu.txt
> >
> > Should this file be removed instead of renamed?
>
> Thanks,
>
> I thought I had checked that but clearly I did not.
> I agree the file should be removed and I'll send a revised patch
> accordingly.
The one lingering reference to renesas,sh-mobile-ceu I can see
in the tree is its use in an example of two data pipelines in
Documentation/devicetree/bindings/media/video-interfaces.txt
Could you suggest an alternative example?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: sh-mobile-ceu: Rename bindings documentation file
2019-08-21 8:17 ` Simon Horman
@ 2019-08-21 9:30 ` Jacopo Mondi
0 siblings, 0 replies; 5+ messages in thread
From: Jacopo Mondi @ 2019-08-21 9:30 UTC (permalink / raw)
To: Simon Horman
Cc: Mauro Carvalho Chehab, Rob Herring, Mark Rutland, Magnus Damm,
Laurent Pinchart, Niklas Söderlund, Geert Uytterhoeven,
linux-media, devicetree, linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 2175 bytes --]
Hi Simon,
On Wed, Aug 21, 2019 at 10:17:48AM +0200, Simon Horman wrote:
> On Tue, Aug 20, 2019 at 05:19:30PM +0200, Simon Horman wrote:
> > On Tue, Aug 20, 2019 at 11:52:05AM +0200, Jacopo Mondi wrote:
> > > Hi Simon,
> > >
> > > On Mon, Aug 19, 2019 at 04:05:44PM +0200, Simon Horman wrote:
> > > > Renesas media binding documentation files uses a naming schema of
> > > > 'renesas,<module>.txt'. Rename the SH Mobile CEU file to match this pattern.
> > > >
> > >
> > > The old soc-camera based sh-mobile-ceu driver has been removed one
> > > year ago and replaced by driver/media/platform/renesas-ceu.c whose
> > > bindings are described at
> > > Documentation/devicetree/bindings/media/renesas,ceu.txt
> > >
> > > Should this file be removed instead of renamed?
> >
> > Thanks,
> >
> > I thought I had checked that but clearly I did not.
> > I agree the file should be removed and I'll send a revised patch
> > accordingly.
>
> The one lingering reference to renesas,sh-mobile-ceu I can see
> in the tree is its use in an example of two data pipelines in
> Documentation/devicetree/bindings/media/video-interfaces.txt
>
Yeah, I noticed that, but never considered it more than an example.
Although, with the removal of the bindings description, it should
probably be changed to avoid generating confusion...
> Could you suggest an alternative example?
The pipeline described in the example is purely fictional, as it uses
a "renesas-shmobile-csi2" compatible to model a CSI-2 input which I
don't see mentioned anywhere. I guess the CEU compatible value there could be
changed to anything we want, including the new renesas-ceu value which
has superseded the sh-mobile-ceu one.
Otherwise, RZ/A2 supports both CSI-2 by using the rcar-vin+rcar-csi2
IP blocks we have in R-Car and parallel input using the old CEU interface.
We could use that as a real-world example, using VIN for CSI-2 and CEU for
parallel input. Unfortunately, no RZ/A2 DTS in mainline has any of the
two interfaces enabled afaict.
I'll send a patch to the media list that just changes the suppressed
compatible value with the new 'renesas-ceu' one unless someone has
different opinions.
Thanks
j
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-21 9:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 14:05 [PATCH] dt-bindings: sh-mobile-ceu: Rename bindings documentation file Simon Horman
2019-08-20 9:52 ` Jacopo Mondi
2019-08-20 15:19 ` Simon Horman
2019-08-21 8:17 ` Simon Horman
2019-08-21 9:30 ` Jacopo Mondi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.