From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83425C3A59E for ; Tue, 20 Aug 2019 13:40:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FFC1230F2 for ; Tue, 20 Aug 2019 13:40:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566308454; bh=ktfeBv51rTzAgpWju4QM5eByplbeoXnsWceE+8Icjuo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qEohFS7x0Pc3xBexYV0hWIEjLEGeA4RAhumk6+Kyp+hfsAxL+fIq3BijyWWPuuZA/ PXHysVnDvdBdPuNejn/yX/R/fao4c6+Cs7R48wpSr+TwQXDNspoJ+qXfjkGvbWKjqI DV3Zh4ksMqd3xeOUI4qrxyz4nA6inJbZJKBriyqs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730247AbfHTNkx (ORCPT ); Tue, 20 Aug 2019 09:40:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:35758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730210AbfHTNkv (ORCPT ); Tue, 20 Aug 2019 09:40:51 -0400 Received: from sasha-vm.mshome.net (unknown [12.236.144.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF6F222DA7; Tue, 20 Aug 2019 13:40:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566308450; bh=ktfeBv51rTzAgpWju4QM5eByplbeoXnsWceE+8Icjuo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LOpdsgW8Z19MJQXugEoE7vGdw+fmpW1q874eTabSnhgjRFNezT3xRWpWsEiggNJE4 vl537M3ioh5NOnhoKZ+yWMyZ7Z9mNuIo9jQgxXC+Noe2AjcvgR+BGRTLe/wtPM1+mS S76OCFMAAMiiJ8X1+3aiLDzVPFYC4D1tozIEQJbA= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jacopo Mondi , Stable@vger.kernel.org, Jonathan Cameron , Sasha Levin , linux-iio@vger.kernel.org Subject: [PATCH AUTOSEL 5.2 20/44] iio: adc: max9611: Fix temperature reading in probe Date: Tue, 20 Aug 2019 09:40:04 -0400 Message-Id: <20190820134028.10829-20-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190820134028.10829-1-sashal@kernel.org> References: <20190820134028.10829-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jacopo Mondi [ Upstream commit b9ddd5091160793ee9fac10da765cf3f53d2aaf0 ] The max9611 driver reads the die temperature at probe time to validate the communication channel. Use the actual read value to perform the test instead of the read function return value, which was mistakenly used so far. The temperature reading test was only successful because the 0 return value is in the range of supported temperatures. Fixes: 69780a3bbc0b ("iio: adc: Add Maxim max9611 ADC driver") Signed-off-by: Jacopo Mondi Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/adc/max9611.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c index 0e3c6529fc4c9..da073d72f649f 100644 --- a/drivers/iio/adc/max9611.c +++ b/drivers/iio/adc/max9611.c @@ -480,7 +480,7 @@ static int max9611_init(struct max9611_dev *max9611) if (ret) return ret; - regval = ret & MAX9611_TEMP_MASK; + regval &= MAX9611_TEMP_MASK; if ((regval > MAX9611_TEMP_MAX_POS && regval < MAX9611_TEMP_MIN_NEG) || -- 2.20.1