From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 21 Aug 2019 08:42:56 -0400 Subject: [U-Boot] [PATCH 2/3] configs: Rename environment variable fit_loadaddr to addr_fit In-Reply-To: <20190812195955.3512-2-afd@ti.com> References: <20190812195955.3512-1-afd@ti.com> <20190812195955.3512-2-afd@ti.com> Message-ID: <20190821124256.GC2718@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Aug 12, 2019 at 03:59:54PM -0400, Andrew F. Davis wrote: > This is the first part of a larger effort I would like to propose to > unify and simplify the default set of environment variables. > > When many early environment variables were named there were fewer images > being loaded, usually just a kernel. At this time names like 'loadaddr' > would suffice. Now we have more images and many more commands that act on > them, often re-using the same variable for several different uses. The > contents of a variable are also not immediately known causing one to have > to look up a chain of variables to understand what a command is actually > doing. I suggest the following. > > To start, all variables containing names should be prefixed with name_ > and addresses with addr_. This is like how K2 already does things and > allows for simple universal commands like: > > get_fdt_nfs=nfs ${addr_fdt} /boot/${name_fdt} > > Which is very clear on what is intended here and would work across all > board that using the this naming convention. > > We can do this one variable at a time, start here with addr_fit. > > Signed-off-by: Andrew F. Davis > Acked-by: Andreas Dannenberg Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: