All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Advanced preparser support for GPU relocs
Date: Fri, 23 Aug 2019 02:39:31 -0000	[thread overview]
Message-ID: <20190823023931.14426.67674@emeril.freedesktop.org> (raw)
In-Reply-To: <20190823020909.6029-1-daniele.ceraolospurio@intel.com>

== Series Details ==

Series: drm/i915/tgl: Advanced preparser support for GPU relocs
URL   : https://patchwork.freedesktop.org/series/65658/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
68a96483d2c1 drm/i915/tgl: Advanced preparser support for GPU relocs
-:121: WARNING:LINE_SPACING: Missing a blank line after declarations
#121: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1212:
+		int ret;
+		eb->engine->emit_flush(rq, EMIT_FLUSH);

-:142: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#142: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1266:
+	if (cache->rq_size > cache->size/sizeof(u32) - (len + 1))
 	                                ^

-:193: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#193: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:57:
+#define   MI_CBBEND_GLOBAL_GTT		(1<<22)
                               		  ^

-:194: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#194: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:58:
+#define   MI_CBBEND_COMPARE_SEMAPHORE	(1<<21) /* Gen12+*/
                                      	  ^

-:195: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#195: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:59:
+#define   MI_CBBEND_COMPARE_MASK	(1<<19) /* Gen9+*/
                                 	  ^

-:196: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#196: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:60:
+#define   MI_CBBEND_END_CURRENT_LEVEL	(1<<18) /* Gen12+*/
                                      	  ^

-:210: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#210: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:150:
+#define   MI_SRM_ADD_CS_MMIO_START	(1<<19) /* gen11+ */
                                   	  ^

-:311: WARNING:LINE_SPACING: Missing a blank line after declarations
#311: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:3076:
+		u32 tmp[16];
+		engine->emit_preparser_disable = gen12_emit_preparser_disable;

total: 0 errors, 2 warnings, 6 checks, 271 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-08-23  2:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23  2:09 [RFC] drm/i915/tgl: Advanced preparser support for GPU relocs Daniele Ceraolo Spurio
2019-08-23  2:39 ` Patchwork [this message]
2019-08-23  3:41 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-08-23  7:27 ` [RFC] " Chris Wilson
2019-08-23 14:26   ` Chris Wilson
2019-08-23 15:05     ` Daniele Ceraolo Spurio
2019-08-23 15:10       ` Chris Wilson
2019-08-23 15:28         ` Chris Wilson
2019-08-23 15:39           ` Daniele Ceraolo Spurio
2019-08-23 15:52             ` Chris Wilson
2019-08-23 15:56               ` Daniele Ceraolo Spurio
2019-08-23 16:31                 ` Chris Wilson
2019-08-23 17:01                   ` Daniele Ceraolo Spurio
2019-08-23 17:28                     ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190823023931.14426.67674@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.