From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] mmc: fsl_esdhc: clean up code
Date: Fri, 23 Aug 2019 10:44:57 +0200 [thread overview]
Message-ID: <20190823104457.50f5c210@jawa> (raw)
In-Reply-To: <20190819082750.22671-3-yangbo.lu@nxp.com>
On Mon, 19 Aug 2019 16:27:49 +0800
Yangbo Lu <yangbo.lu@nxp.com> wrote:
> /* Return the XFERTYP flags for a given command and data packet */
> -static uint esdhc_xfertyp(struct mmc_cmd *cmd, struct mmc_data *data)
> +static uint esdhc_setup_xfertyp(struct mmc_cmd *cmd, struct mmc_data
> *data) {
> uint xfertyp = 0;
>
> @@ -310,9 +310,9 @@ static int esdhc_setup_data(struct fsl_esdhc_priv
> *priv, struct mmc *mmc, return 0;
> }
>
> -static void check_and_invalidate_dcache_range
> - (struct mmc_cmd *cmd,
> - struct mmc_data *data) {
> +static void esdhc_invalidate_dcache_range(struct mmc_cmd *cmd,
> + struct mmc_data *data)
^^^^ - it shall be aligned
with the (
Could you double check this patch set with ./tools/checkpatch.py if it
is clean?
(You can also test tools/patman - which does automatic checkpatch check)
> +{
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190823/5ec66c0b/attachment.sig>
next prev parent reply other threads:[~2019-08-23 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 8:27 [U-Boot] [PATCH 0/3] mmc: fsl_esdhc: clean up code Yangbo Lu
2019-08-19 8:27 ` [U-Boot] [PATCH 1/3] mmc: fsl_esdhc: make BLK as hard requirement of DM_MMC Yangbo Lu
2019-08-19 8:27 ` [U-Boot] [PATCH 2/3] mmc: fsl_esdhc: clean up code Yangbo Lu
2019-08-23 8:44 ` Lukasz Majewski [this message]
2019-09-03 3:31 ` Y.b. Lu
2019-08-19 8:27 ` [U-Boot] [PATCH 3/3] mmc: fsl_esdhc: rename fsl_esdhc_init to fsl_esdhc_get_cfg Yangbo Lu
2019-09-04 4:22 ` [U-Boot] [PATCH 0/3] mmc: fsl_esdhc: clean up code Y.b. Lu
2019-09-04 7:52 ` Peng Fan
2019-09-06 2:12 ` Peng Fan
2019-09-06 6:02 ` Y.b. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823104457.50f5c210@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.