From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E6E9C3A5A4 for ; Fri, 23 Aug 2019 12:22:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52A7C21897 for ; Fri, 23 Aug 2019 12:22:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="QhVuHj1d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394481AbfHWMW6 (ORCPT ); Fri, 23 Aug 2019 08:22:58 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:37870 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731856AbfHWMW6 (ORCPT ); Fri, 23 Aug 2019 08:22:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=V/BSRc/5Dyzi5nNWjFuzygHkjpKjWnqloHD8aW/Vxqo=; b=QhVuHj1dAZl1mSQGXJo2iAGCW hgIo2M3LHfplbLuqjQQKsp+jqghpnaWYkE+8TJagxpAooKMVQSfkyCiWzwg0J/FebKHV2fgd5dRkD 62k1PTj5cLwTATA9cUqki8XfXOsA+hV4kL5THNjT0pglSIqU3PgXGRmhGuQI+/mv+yaebEm22DsFZ NsW/tHvQOSWbR9a8c7n66Br1OziopIZBpxN0M1Rr5TYPorCcXRqMoWvj4KXCSJZtqjcrT7O74s0uW yu/81Xxv4oF8izJ2tOAHVHMs3+/ib0gg12YdbCPetCqufa/tIbQUDfbnN9QLO9xSKQaHM0oj+tX+W gWXahD2LQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1i18ab-0007UH-8z; Fri, 23 Aug 2019 12:22:45 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 48F1A307691; Fri, 23 Aug 2019 14:22:10 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 67A3B201E04D9; Fri, 23 Aug 2019 14:22:42 +0200 (CEST) Date: Fri, 23 Aug 2019 14:22:42 +0200 From: Peter Zijlstra To: Jason Gunthorpe Cc: Daniel Vetter , Andrew Morton , LKML , Linux MM , DRI Development , Intel Graphics Development , Ingo Molnar , Michal Hocko , David Rientjes , Christian =?iso-8859-1?Q?K=F6nig?= , =?iso-8859-1?B?Suly9G1l?= Glisse , Masahiro Yamada , Wei Wang , Andy Shevchenko , Thomas Gleixner , Jann Horn , Feng Tang , Kees Cook , Randy Dunlap , Daniel Vetter Subject: Re: [PATCH 3/4] kernel.h: Add non_block_start/end() Message-ID: <20190823122242.GN2349@hirez.programming.kicks-ass.net> References: <20190820081902.24815-1-daniel.vetter@ffwll.ch> <20190820081902.24815-4-daniel.vetter@ffwll.ch> <20190820202440.GH11147@phenom.ffwll.local> <20190822161428.c9e4479207386d34745ea111@linux-foundation.org> <20190823121234.GB12968@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190823121234.GB12968@ziepe.ca> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 23, 2019 at 09:12:34AM -0300, Jason Gunthorpe wrote: > I still haven't heard a satisfactory answer why a whole new scheme is > needed and a simple: > > if (IS_ENABLED(CONFIG_DEBUG_ATOMIC_SLEEP)) > preempt_disable() > > isn't sufficient to catch the problematic cases during debugging?? > IMHO the fact preempt is changed by the above when debugging is not > material here. I think that information should be included in the > commit message at least. That has a much larger impact and actually changes behaviour, while the relatively simple patch Daniel proposed only adds a warning but doesn't affect behaviour. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 3/4] kernel.h: Add non_block_start/end() Date: Fri, 23 Aug 2019 14:22:42 +0200 Message-ID: <20190823122242.GN2349@hirez.programming.kicks-ass.net> References: <20190820081902.24815-1-daniel.vetter@ffwll.ch> <20190820081902.24815-4-daniel.vetter@ffwll.ch> <20190820202440.GH11147@phenom.ffwll.local> <20190822161428.c9e4479207386d34745ea111@linux-foundation.org> <20190823121234.GB12968@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190823121234.GB12968@ziepe.ca> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jason Gunthorpe Cc: Feng Tang , Michal Hocko , Kees Cook , Masahiro Yamada , Intel Graphics Development , Jann Horn , LKML , DRI Development , Linux MM , =?iso-8859-1?B?Suly9G1l?= Glisse , Ingo Molnar , Thomas Gleixner , Randy Dunlap , David Rientjes , Wei Wang , Daniel Vetter , Andrew Morton , Andy Shevchenko , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBBdWcgMjMsIDIwMTkgYXQgMDk6MTI6MzRBTSAtMDMwMCwgSmFzb24gR3VudGhvcnBl IHdyb3RlOgoKPiBJIHN0aWxsIGhhdmVuJ3QgaGVhcmQgYSBzYXRpc2ZhY3RvcnkgYW5zd2VyIHdo eSBhIHdob2xlIG5ldyBzY2hlbWUgaXMKPiBuZWVkZWQgYW5kIGEgc2ltcGxlOgo+IAo+ICAgIGlm IChJU19FTkFCTEVEKENPTkZJR19ERUJVR19BVE9NSUNfU0xFRVApKQo+ICAgICAgICAgcHJlZW1w dF9kaXNhYmxlKCkKPiAKPiBpc24ndCBzdWZmaWNpZW50IHRvIGNhdGNoIHRoZSBwcm9ibGVtYXRp YyBjYXNlcyBkdXJpbmcgZGVidWdnaW5nPz8KPiBJTUhPIHRoZSBmYWN0IHByZWVtcHQgaXMgY2hh bmdlZCBieSB0aGUgYWJvdmUgd2hlbiBkZWJ1Z2dpbmcgaXMgbm90Cj4gbWF0ZXJpYWwgaGVyZS4g SSB0aGluayB0aGF0IGluZm9ybWF0aW9uIHNob3VsZCBiZSBpbmNsdWRlZCBpbiB0aGUKPiBjb21t aXQgbWVzc2FnZSBhdCBsZWFzdC4KClRoYXQgaGFzIGEgbXVjaCBsYXJnZXIgaW1wYWN0IGFuZCBh Y3R1YWxseSBjaGFuZ2VzIGJlaGF2aW91ciwgd2hpbGUgdGhlCnJlbGF0aXZlbHkgc2ltcGxlIHBh dGNoIERhbmllbCBwcm9wb3NlZCBvbmx5IGFkZHMgYSB3YXJuaW5nIGJ1dCBkb2Vzbid0CmFmZmVj dCBiZWhhdmlvdXIuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eA==