From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 30B8089CDE for ; Fri, 23 Aug 2019 14:31:15 +0000 (UTC) Date: Fri, 23 Aug 2019 17:30:13 +0300 From: Imre Deak Message-ID: <20190823143013.GG26896@ideak-desk.fi.intel.com> References: <20190621154252.27952-5-anshuman.gupta@intel.com> <20190814174621.4426-1-anshuman.gupta@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190814174621.4426-1-anshuman.gupta@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t v12 4/6] tests/i915/i915_pm_dc: Added test for DC5 during DPMS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Anshuman Gupta Cc: igt-dev@lists.freedesktop.org, Jyoti Yadav List-ID: T24gV2VkLCBBdWcgMTQsIDIwMTkgYXQgMTE6MTY6MjFQTSArMDUzMCwgQW5zaHVtYW4gR3VwdGEg d3JvdGU6Cj4gRnJvbTogSnlvdGkgWWFkYXYgPGp5b3RpLnIueWFkYXZAaW50ZWwuY29tPgo+IAo+ IEFkZGVkIG5ldyBzdWJ0ZXN0IGZvciBEQzUgZW50cnkgZHVyaW5nIERQTVMgb24vb2ZmIGN5Y2xl Lgo+IER1cmluZyBEUE1TIG9uL29mZiBjeWNsZSBEQzUgY291bnRlciBpcyBpbmNyZW1lbnRlZC4K PiAKPiB2MjogUmVuYW1lIHRoZSBzdWJ0ZXN0IHdpdGggbWVhbmluZ2Z1bCBuYW1lLgo+IHYzOiBS ZWJhc2VkLgo+IHY0OiBBZGRyZXNzZWQgcmV2aWV3IGNvbW1lbnRzIGJ5IHJlbW92aW5nIGxlZnRv dmVyIGNvZGUKPiAgICAgY2xlYW51cCgpLgo+IHY1OiBBZGRyZXNzZWQgdGhlIHJldmlldyBjb21t ZW50IGJ5IHJlbW92aW5nIHJlZHVuZGFudAo+ICAgICByZWFkX2RjX2NvdW50ZXIoKSBzdWdnZXN0 ZWQgYnkgSW1yZS4KPiAgICAgTGlzdGluZyBhY3R1YWwgY2hhbmdlIGluIHBhdGNoIHNldCBjaGFu Z2Vsb2cgdG8gbWFrZSByZXZpZXcgZWFzaWVyLgo+IHY2OiBUaHJlZSB3YXkgcGF0Y2ggYXBwbGll ZCwgbm8gZnVuY3Rpb25hbCBjaGFuZ2UuCj4gdjc6IERpc2FibGluZyBydW50aW1lIHN1c3BlbmQg Zm9yIHRoZSBwbGF0Zm9ybSB3aGljaCBzdXBwb3J0LCBEQzkuCj4gICAgIHJlYmFzZWQgZHVlIHRv IHRlc3QgbmFtZSBwbV9kYyBjaGFuZ2VkIHRvIGk5MTVfcG1fZGMsIGFsaWduaW5nIHRvCj4gICAg IG90aGVyIFBNIHRlc3RzLgo+IHY4OiBJbnRyb2R1Y2VkIHNldHVwX2RjX2RwbXMoKSBpbiBvcmRl ciB0byBkaXNhYmxlIHJ1bnRpbWUgcG0sIHJlc3RvcmluZwo+ICAgICBQT1dFUl9ESVIgdmFsdWVz IHRvIGl0cyBvcmlnaW5hbCBhbmQgZW5hYmxpbmcgcnVudGltZSBwbSAgZm9yIG90aGVyCj4gICAg IGZvbGxvd2VkIHN1Yi10ZXN0cy4KPiB2OTogQ2hlY2sgREM1IGNvdW50ZXIgdmFsdWUgYWZ0ZXIg RFBNUyBvZmYsIGJyb2tlIHRoZSBkcG1zX29uX29mZgo+ICAgICBmdW5jdGlvbiB0byBkcG1zX29u IGFuZCBkcG1zX29mZi4gW0ltcmVdCj4gdjEwOkFkZGVkIEFUX0xFQVNUX0dlbjExIGNvbmRpdGlv biBpbnN0ZWFkIG9mIElTX0lDRUxBS0UgaW4gb3JkZXIgdG8KPiAgICAgZGlzYWJsZSBydW50aW1l IHN1c3BlbmQuIFtJbXJlXQo+IAo+IFNpZ25lZC1vZmYtYnk6IEp5b3RpIFlhZGF2IDxqeW90aS5y LnlhZGF2QGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBBbnNodW1hbiBHdXB0YSA8YW5zaHVt YW4uZ3VwdGFAaW50ZWwuY29tPgo+IC0tLQo+ICB0ZXN0cy9pOTE1L2k5MTVfcG1fZGMuYyB8IDYy ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFu Z2VkLCA2MiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL3Rlc3RzL2k5MTUvaTkxNV9w bV9kYy5jIGIvdGVzdHMvaTkxNS9pOTE1X3BtX2RjLmMKPiBpbmRleCBmMjYxZWNiZi4uZjAzZDMw YTggMTAwNjQ0Cj4gLS0tIGEvdGVzdHMvaTkxNS9pOTE1X3BtX2RjLmMKPiArKysgYi90ZXN0cy9p OTE1L2k5MTVfcG1fZGMuYwo+IEBAIC00Niw2ICs0Niw3IEBAIHR5cGVkZWYgc3RydWN0IHsKPiAg CWVudW0gcHNyX21vZGUgb3BfcHNyX21vZGU7Cj4gIAlkcm1Nb2RlTW9kZUluZm8gKm1vZGU7Cj4g IAlpZ3Rfb3V0cHV0X3QgKm91dHB1dDsKPiArCWJvb2wgcnVudGltZV9zdXNwZW5kX2Rpc2FibGVk Owo+ICB9IGRhdGFfdDsKPiAgCj4gIGJvb2wgZGNfc3RhdGVfd2FpdF9lbnRyeShpbnQgZHJtX2Zk LCBpbnQgZGNfZmxhZywgaW50IHByZXZfZGNfY291bnQpOwo+IEBAIC0xNzMsNiArMTc0LDYyIEBA IHN0YXRpYyB2b2lkIHRlc3RfZGNfc3RhdGVfcHNyKGRhdGFfdCAqZGF0YSwgaW50IGRjX2ZsYWcp Cj4gIAljbGVhbnVwKGRhdGEpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBzZXR1cF9kY19kcG1z KGRhdGFfdCAqZGF0YSkKPiArewo+ICsJaWYgKElTX0JST1hUT04oZGF0YS0+ZGV2aWQpIHx8IElT X0dFTUlOSUxBS0UoZGF0YS0+ZGV2aWQpIHx8Cj4gKwkgICAgQVRfTEVBU1RfR0VOKGRhdGEtPmRl dmlkLCAxMSkpIHsKPiArCQlkYXRhLT5ydW50aW1lX3N1c3BlbmRfZGlzYWJsZWQgPSBpZ3RfZGlz YWJsZV9ydW50aW1lX3BtKCk7Cj4gKwkJaWd0X3JlcXVpcmVfZihkYXRhLT5ydW50aW1lX3N1c3Bl bmRfZGlzYWJsZWQsCj4gKwkJCSAgICAgICJ1bmFibGUgdG8gZGlzYWJsZSBydW50aW1lIHBtIGZv ciBpOTE1XG4iKTsKPiArCX0gZWxzZSB7Cj4gKwkJZGF0YS0+cnVudGltZV9zdXNwZW5kX2Rpc2Fi bGVkID0gZmFsc2U7Cj4gKwl9Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIGRwbXNfb2ZmKGRhdGFf dCAqZGF0YSkKPiArewo+ICsJZm9yIChpbnQgaSA9IDA7IGkgPCBkYXRhLT5kaXNwbGF5Lm5fb3V0 cHV0czsgaSsrKSB7Cj4gKwkJa21zdGVzdF9zZXRfY29ubmVjdG9yX2RwbXMoZGF0YS0+ZHJtX2Zk LAo+ICsJCQkJCSAgIGRhdGEtPmRpc3BsYXkub3V0cHV0c1tpXS5jb25maWcuY29ubmVjdG9yLAo+ ICsJCQkJCSAgIERSTV9NT0RFX0RQTVNfT0ZGKTsKPiArCX0KPiArCj4gKwlpZiAoIWRhdGEtPnJ1 bnRpbWVfc3VzcGVuZF9kaXNhYmxlZCkKPiArCQlpZ3RfYXNzZXJ0KGlndF93YWl0X2Zvcl9wbV9z dGF0dXMKPiArCQkJICAgKElHVF9SVU5USU1FX1BNX1NUQVRVU19TVVNQRU5ERUQpKTsKPiArfQo+ ICsKPiArc3RhdGljIHZvaWQgZHBtc19vbihkYXRhX3QgKmRhdGEpCj4gK3sKPiArCWZvciAoaW50 IGkgPSAwOyBpIDwgZGF0YS0+ZGlzcGxheS5uX291dHB1dHM7IGkrKykgewo+ICsJCWttc3Rlc3Rf c2V0X2Nvbm5lY3Rvcl9kcG1zKGRhdGEtPmRybV9mZCwKPiArCQkJCQkgICBkYXRhLT5kaXNwbGF5 Lm91dHB1dHNbaV0uY29uZmlnLmNvbm5lY3RvciwKPiArCQkJCQkgICBEUk1fTU9ERV9EUE1TX09O KTsKPiArCX0KPiArCj4gKwlpZiAoIWRhdGEtPnJ1bnRpbWVfc3VzcGVuZF9kaXNhYmxlZCkKPiAr CQlpZ3RfYXNzZXJ0KGlndF93YWl0X2Zvcl9wbV9zdGF0dXMKPiArCQkJICAgKElHVF9SVU5USU1F X1BNX1NUQVRVU19BQ1RJVkUpKTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgdGVzdF9kY19zdGF0 ZV9kcG1zKGRhdGFfdCAqZGF0YSwgaW50IGRjX2ZsYWcpCj4gK3sKPiArCXVpbnQzMl90IGRjX2Nv dW50ZXI7Cj4gKwo+ICsJZGNfY291bnRlciA9IHJlYWRfZGNfY291bnRlcihkYXRhLT5kcm1fZmQs IGRjX2ZsYWcpOwo+ICsJZHBtc19vZmYoZGF0YSk7Cj4gKwljaGVja19kY19jb3VudGVyKGRhdGEt PmRybV9mZCwgZGNfZmxhZywgZGNfY291bnRlcik7Cj4gKwlkcG1zX29uKGRhdGEpOwo+ICsKPiAr CS8qIGlmIHJ1bnRpbWUgUE0gaXMgZGlzYWJsZWQgZm9yIGk5MTUgcmVzdG9yZSBpdCwKPiArCSAq IHNvIGFueSBvdGhlciBzdWItdGVzdCBjYW4gdXNlIHJ1bnRpbWUtUE0uCj4gKwkgKi8KPiArCWlm IChkYXRhLT5ydW50aW1lX3N1c3BlbmRfZGlzYWJsZWQpIHsKPiArCQlpZ3RfcmVzdG9yZV9ydW50 aW1lX3BtKCk7Cj4gKwkJaWd0X3NldHVwX3J1bnRpbWVfcG0oKTsKPiArCX0KClRoZSBhYm92ZSBy ZXN0b3JlcyB3aGF0IHNldHVwX2RjX2RwbXMoKSBkaWQgc28gY291bGQgeW91IG1vdmUgaXQgYQpj bGVhbnVwX2RjX2RwbXMoKSBmdW5jdGlvbiBmb3IgY2xhcml0eT8KCj4gK30KPiArCj4gIGludCBt YWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCj4gIHsKPiAgCWJvb2wgaGFzX3J1bnRpbWVfcG07 Cj4gQEAgLTIxMCw2ICsyNjcsMTEgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkK PiAgCQl0ZXN0X2RjX3N0YXRlX3BzcigmZGF0YSwgQ0hFQ0tfREM2KTsKPiAgCX0KPiAgCj4gKwlp Z3Rfc3VidGVzdCgiZGM1LWRwbXMiKSB7Cj4gKwkJc2V0dXBfZGNfZHBtcygmZGF0YSk7CgpDb3Vs ZCB5b3UgbW92ZSB0aGUgYWJvdmUgY2FsbCB0byB0ZXN0X2RjX3N0YXRlX2RwbXMoKSBhbmQgY2hl Y2sgZm9yCkNIRUNLX0RDNSB3aXRoaW5nIHNldHVwX2RjX2RwbXMoKT8KCkkgY291bGRuJ3Qgc3Bv dCBhbnkgb3RoZXIgaXNzdWVzIHNvIHdpdGggdGhlc2UgY2hhbmdlcyBvbiB0aGUgcGF0Y2hzZXQ6 ClJldmlld2VkLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+CgpDb3VsZCB5b3Ug cGxlYXNlIHJlc2VuZCB0aGUgd2hvbGUgcGF0Y2hzZXQ/Cgo+ICsJCXRlc3RfZGNfc3RhdGVfZHBt cygmZGF0YSwgQ0hFQ0tfREM1KTsKPiArCX0KPiArCj4gIAlpZ3RfZml4dHVyZSB7Cj4gIAkJY2xv c2UoZGF0YS5kZWJ1Z2ZzX2ZkKTsKPiAgCQlkaXNwbGF5X2ZpbmkoJmRhdGEpOwo+IC0tIAo+IDIu MjEuMAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpp Z3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXY=