From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B401AC3A5A2 for ; Fri, 23 Aug 2019 16:04:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 873922173E for ; Fri, 23 Aug 2019 16:04:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387775AbfHWQEK (ORCPT ); Fri, 23 Aug 2019 12:04:10 -0400 Received: from mga12.intel.com ([192.55.52.136]:16274 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733303AbfHWQEK (ORCPT ); Fri, 23 Aug 2019 12:04:10 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2019 09:04:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,421,1559545200"; d="scan'208";a="263228579" Received: from unknown (HELO localhost) ([10.252.39.229]) by orsmga001.jf.intel.com with ESMTP; 23 Aug 2019 09:04:06 -0700 Date: Fri, 23 Aug 2019 19:04:04 +0300 From: Jarkko Sakkinen To: sean.j.christopherson@intel.com Cc: luto@kernel.org, linux-sgx@vger.kernel.org Subject: Re: sgx_encl_may_map() Message-ID: <20190823160404.oszonu4srjx276a3@linux.intel.com> References: <20190823150248.kuxgdxyd4z5wlsz5@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190823150248.kuxgdxyd4z5wlsz5@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20180716 Sender: linux-sgx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Fri, Aug 23, 2019 at 06:02:48PM +0300, Jarkko Sakkinen wrote: > 3. Why don't just store SECINFO flags on EADD? Doing > calc_vma_prot_bits() on fly is not expensive. Now > data in SECINFO flags is scattered to two different > fields (desc and vm_max_prot_bits). I'd just have a field > called secinfo_flags. Makes sense to have that field as a cache so that we don't have to do recalc per page in the sgx_encl_may_map() and thus makes sense to keep TCS tagging in desc. /Jarkko