All of lore.kernel.org
 help / color / mirror / Atom feed
From: Salvatore Bonaccorso <carnil@debian.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
	xfs <linux-xfs@vger.kernel.org>,
	Dave Chinner <david@fromorbit.com>,
	Security Officers <security@kernel.org>,
	Debian Security Team <team@security.debian.org>,
	benjamin.moody@gmail.com, Ben Hutchings <benh@debian.org>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] xfs: fix missing ILOCK unlock when xfs_setattr_nonsize fails due to EDQUOT
Date: Fri, 23 Aug 2019 21:26:12 +0200	[thread overview]
Message-ID: <20190823192612.GB8736@eldamar.local> (raw)
In-Reply-To: <CAHk-=wiE1zyj89=gpoCn8L0hy8WpS68s+13GOsHQ5Eq3DPWqEw@mail.gmail.com>

Hi Linus,

On Fri, Aug 23, 2019 at 09:28:42AM -0700, Linus Torvalds wrote:
> On Thu, Aug 22, 2019 at 8:55 PM Darrick J. Wong <darrick.wong@oracle.com> wrote:
> >
> > ...which is clearly caused by xfs_setattr_nonsize failing to unlock the
> > ILOCK after the xfs_qm_vop_chown_reserve call fails.  Add the missing
> > unlock.
> 
> Thanks for the quick fix.
> 
> I assume there's no real embargo on this, and we can just add it asap
> to the xfs tree and mark it for stable, rather than do anything
> outside the usual development path?
> 
> The security list rules do allow for a 5-working-day delay, but this
> being "just" a local DoS thing I expect nobody really will argue for
> it.
> 
> Anybody?

Agreed, there is no real embargo on this, it is public anyway on the
xfs list and actually we just wanted to be on the safe side by asking
or bringing it to security@k.o.

Thanks for the quick fix.

Regards,
Salvatore

  parent reply	other threads:[~2019-08-23 19:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23  3:55 [PATCH] xfs: fix missing ILOCK unlock when xfs_setattr_nonsize fails due to EDQUOT Darrick J. Wong
2019-08-23  3:57 ` [PATCH] generic: test for failure to unlock inode after chgrp fails with EDQUOT Darrick J. Wong
2019-08-24 23:05   ` Christoph Hellwig
2019-08-23  4:55 ` [PATCH] xfs: fix missing ILOCK unlock when xfs_setattr_nonsize fails due to EDQUOT Dave Chinner
2019-08-23 16:28 ` Linus Torvalds
2019-08-23 17:15   ` Benjamin Moody
2019-08-23 19:26   ` Salvatore Bonaccorso [this message]
2019-08-24 18:22     ` Salvatore Bonaccorso
2019-08-23 19:24 ` Salvatore Bonaccorso
2019-08-24 18:44   ` Linus Torvalds
2019-08-25  3:13     ` Greg KH
2019-08-25 15:45       ` Salvatore Bonaccorso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190823192612.GB8736@eldamar.local \
    --to=carnil@debian.org \
    --cc=benh@debian.org \
    --cc=benjamin.moody@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=security@kernel.org \
    --cc=team@security.debian.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.