From: Andrew Morton <akpm@linux-foundation.org>
To: Roman Gushchin <guro@fb.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
Michal Hocko <mhocko@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v3 0/3] vmstats/vmevents flushing
Date: Sat, 24 Aug 2019 13:53:39 -0700 [thread overview]
Message-ID: <20190824135339.46da90b968d92529641b3ed2@linux-foundation.org> (raw)
In-Reply-To: <20190823003347.GA4252@castle>
On Fri, 23 Aug 2019 00:33:51 +0000 Roman Gushchin <guro@fb.com> wrote:
> On Thu, Aug 22, 2019 at 04:27:09PM -0700, Andrew Morton wrote:
> > On Mon, 19 Aug 2019 16:00:51 -0700 Roman Gushchin <guro@fb.com> wrote:
> >
> > > v3:
> > > 1) rearranged patches [2/3] and [3/3] to make [1/2] and [2/2] suitable
> > > for stable backporting
> > >
> > > v2:
> > > 1) fixed !CONFIG_MEMCG_KMEM build by moving memcg_flush_percpu_vmstats()
> > > and memcg_flush_percpu_vmevents() out of CONFIG_MEMCG_KMEM
> > > 2) merged add-comments-to-slab-enums-definition patch in
> > >
> > > Thanks!
> > >
> > > Roman Gushchin (3):
> > > mm: memcontrol: flush percpu vmstats before releasing memcg
> > > mm: memcontrol: flush percpu vmevents before releasing memcg
> > > mm: memcontrol: flush percpu slab vmstats on kmem offlining
> > >
> >
> > Can you please explain why the first two patches were cc:stable but not
> > the third?
> >
> >
>
> Because [1] and [2] are fixing commit 42a300353577 ("mm: memcontrol: fix
> recursive statistics correctness & scalabilty"), which has been merged into 5.2.
>
> And [3] fixes commit fb2f2b0adb98 ("mm: memcg/slab: reparent memcg kmem_caches
> on cgroup removal"), which is in not yet released 5.3, so stable backport isn't
> required.
OK, thanks. Patches 1 & 2 are good to go but I don't think that #3 has
had suitable review and I have a note here that Michal has concerns
with it.
next prev parent reply other threads:[~2019-08-24 20:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 23:00 [PATCH v3 0/3] vmstats/vmevents flushing Roman Gushchin
2019-08-19 23:00 ` [PATCH v3 1/3] mm: memcontrol: flush percpu vmstats before releasing memcg Roman Gushchin
2019-08-19 23:00 ` [PATCH v3 2/3] mm: memcontrol: flush percpu vmevents " Roman Gushchin
2019-08-19 23:00 ` [PATCH v3 3/3] mm: memcontrol: flush percpu slab vmstats on kmem offlining Roman Gushchin
2019-08-22 23:27 ` [PATCH v3 0/3] vmstats/vmevents flushing Andrew Morton
2019-08-23 0:33 ` Roman Gushchin
2019-08-24 20:53 ` Andrew Morton [this message]
2019-08-26 7:33 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190824135339.46da90b968d92529641b3ed2@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Kernel-team@fb.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.