From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C916C3A5A4 for ; Mon, 26 Aug 2019 07:58:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69DDD20578 for ; Mon, 26 Aug 2019 07:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730380AbfHZH6W (ORCPT ); Mon, 26 Aug 2019 03:58:22 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:37755 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730317AbfHZH6V (ORCPT ); Mon, 26 Aug 2019 03:58:21 -0400 Received: from uno.localdomain (unknown [87.18.63.98]) (Authenticated sender: jacopo@jmondi.org) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 49607240006; Mon, 26 Aug 2019 07:58:12 +0000 (UTC) Date: Mon, 26 Aug 2019 09:59:43 +0200 From: Jacopo Mondi To: Geert Uytterhoeven Cc: Jacopo Mondi , Laurent Pinchart , Kieran Bingham , Simon Horman , Ulrich Hecht , David Airlie , Daniel Vetter , Koji Matsuoka , muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, Linux-Renesas , DRI Development , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , Mark Rutland Subject: Re: [PATCH v3 01/14] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Message-ID: <20190826075943.h7ivwagape3glym5@uno.localdomain> References: <20190825135154.11488-1-jacopo+renesas@jmondi.org> <20190825135154.11488-2-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6ypjwqqmzlry6ejt" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6ypjwqqmzlry6ejt Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Hi Geert, On Mon, Aug 26, 2019 at 09:34:41AM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Sun, Aug 25, 2019 at 3:50 PM Jacopo Mondi wrote: > > Add device tree bindings documentation for the Renesas R-Car Display > > Unit Color Management Module. > > > > CMM is the image enhancement module available on each R-Car DU video > > channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). > > > > Signed-off-by: Jacopo Mondi > > Thanks for your patch! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/renesas,cmm.txt > > @@ -0,0 +1,33 @@ > > +* Renesas R-Car Color Management Module (CMM) > > + > > +Renesas R-Car image enhancement module connected to R-Car DU video channels. > > + > > +Required properties: > > + - compatible: shall be one or more of the following: > > + - "renesas,cmm-r8a7795": for R8A7795 (R-Car H3) compatible CMM. > > + - "renesas,cmm-r8a7796": for R8A7796 (R-Car M3-W) compatible CMM. > > + - "renesas,cmm-r8a77965": for R8A77965 (R-Car M3-N) compatible CMM. > > + - "renesas,cmm-r8a77990": for R8A77990 (R-Car E3) compatible CMM. > > + - "renesas,cmm-r8a77995": for R8A77995 (R-Car D3) compatible CMM. > > Please use "renesas,-cmm" instead of "renesas,cmm-". > I actually copied it from the r-car gpio bindings, and I liked cmm- better. If you prefer I can change it though. > > + - "renesas,rcar-gen3-cmm": for a generic R-Car Gen3 compatible CMM. > > + - "renesas,rcar-gen2-cmm": for a generic R-Car Gen2 compatible CMM. > > + > > + When the generic compatible string is specified, the SoC-specific > > + version corresponding to the platform should be listed first. > > + > > + - reg: the address base and length of the memory area where CMM control > > + registers are mapped to. > > + > > + - clocks: phandle and clock-specifier pair to the CMM functional clock > > + supplier. > > Thinking about yaml validation: > > power-domains? > resets? > They should indeed be documented. Thanks j > > +Example: > > +-------- > > + > > + cmm0: cmm@fea40000 { > > + compatible = "renesas,cmm-r8a7796"; > > + reg = <0 0xfea40000 0 0x1000>; > > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > > + clocks = <&cpg CPG_MOD 711>; > > + resets = <&cpg 711>; > > + }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds --6ypjwqqmzlry6ejt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEtcQ9SICaIIqPWDjAcjQGjxahVjwFAl1jkW8ACgkQcjQGjxah VjxB3w//d3VYx+uJJKBX383/pCXEkl5iaMUHMgZ4mxsCzn3gM1E/3uGgWJOZpjdz sHAvl1p7ybG4abmbXOKJH0ltitBderyFLPbagGW4SDTi7hFe8AbiRNm9sPWyBjYk OORU2Upt91N++sTh7xHoxq8bJhqWYL0ZhGOE+tbbwl2LgMAjOXaQFYXTX5Tnl/Mm 7XNVATlhfhpN7Xc9ddijtNasUBFYNAvaBdme/d1h/FOD9gy3nFO2i/w828g+zlIM MSBpZCcfRSoUmjc2CSJzHW7DHAhdVxm7J9qbSGDRz7I5FMfrH3ICS2ufDoHyNmlr fqB18iTbkwktkDQwm5rcUGhDEGp19hFCr7qmu4NPeQ+FhTM9TtkxYB+E4gZm74Tu OvUoI4fbMJIlcLoKw8OBT+l8eX2e5CuWqpHokpwDLdXxjHZwtQIoSKLJvRQliGw0 fs7UR7wHhTWCmSwx1bhghcCLHDLQewjZzS0gqX957ks33+Djq7I2dX3EUUdwd+15 bGgsTiSmr6p8hFzPm2t0ZIyg2g9Lj2cGk+O36FYJtvps9VfiBcK9+CecZbQ73Zs5 godvAr3BPCDAKJlGekXOztiK5EoYN6XmGB09IR+0inCfMv6o9jFn7AiUqDjNVq2i e3762EZuD8nKwv8FlWsj2LIkD0g/6B+mwTJ/WPBNYWzr2o1RuD8= =Y5PQ -----END PGP SIGNATURE----- --6ypjwqqmzlry6ejt-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacopo Mondi Subject: Re: [PATCH v3 01/14] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Date: Mon, 26 Aug 2019 09:59:43 +0200 Message-ID: <20190826075943.h7ivwagape3glym5@uno.localdomain> References: <20190825135154.11488-1-jacopo+renesas@jmondi.org> <20190825135154.11488-2-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6ypjwqqmzlry6ejt" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Jacopo Mondi , Laurent Pinchart , Kieran Bingham , Simon Horman , Ulrich Hecht , David Airlie , Daniel Vetter , Koji Matsuoka , muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, Linux-Renesas , DRI Development , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , Mark Rutland List-Id: devicetree@vger.kernel.org --6ypjwqqmzlry6ejt Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Hi Geert, On Mon, Aug 26, 2019 at 09:34:41AM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Sun, Aug 25, 2019 at 3:50 PM Jacopo Mondi wrote: > > Add device tree bindings documentation for the Renesas R-Car Display > > Unit Color Management Module. > > > > CMM is the image enhancement module available on each R-Car DU video > > channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). > > > > Signed-off-by: Jacopo Mondi > > Thanks for your patch! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/renesas,cmm.txt > > @@ -0,0 +1,33 @@ > > +* Renesas R-Car Color Management Module (CMM) > > + > > +Renesas R-Car image enhancement module connected to R-Car DU video channels. > > + > > +Required properties: > > + - compatible: shall be one or more of the following: > > + - "renesas,cmm-r8a7795": for R8A7795 (R-Car H3) compatible CMM. > > + - "renesas,cmm-r8a7796": for R8A7796 (R-Car M3-W) compatible CMM. > > + - "renesas,cmm-r8a77965": for R8A77965 (R-Car M3-N) compatible CMM. > > + - "renesas,cmm-r8a77990": for R8A77990 (R-Car E3) compatible CMM. > > + - "renesas,cmm-r8a77995": for R8A77995 (R-Car D3) compatible CMM. > > Please use "renesas,-cmm" instead of "renesas,cmm-". > I actually copied it from the r-car gpio bindings, and I liked cmm- better. If you prefer I can change it though. > > + - "renesas,rcar-gen3-cmm": for a generic R-Car Gen3 compatible CMM. > > + - "renesas,rcar-gen2-cmm": for a generic R-Car Gen2 compatible CMM. > > + > > + When the generic compatible string is specified, the SoC-specific > > + version corresponding to the platform should be listed first. > > + > > + - reg: the address base and length of the memory area where CMM control > > + registers are mapped to. > > + > > + - clocks: phandle and clock-specifier pair to the CMM functional clock > > + supplier. > > Thinking about yaml validation: > > power-domains? > resets? > They should indeed be documented. Thanks j > > +Example: > > +-------- > > + > > + cmm0: cmm@fea40000 { > > + compatible = "renesas,cmm-r8a7796"; > > + reg = <0 0xfea40000 0 0x1000>; > > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > > + clocks = <&cpg CPG_MOD 711>; > > + resets = <&cpg 711>; > > + }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds --6ypjwqqmzlry6ejt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEtcQ9SICaIIqPWDjAcjQGjxahVjwFAl1jkW8ACgkQcjQGjxah VjxB3w//d3VYx+uJJKBX383/pCXEkl5iaMUHMgZ4mxsCzn3gM1E/3uGgWJOZpjdz sHAvl1p7ybG4abmbXOKJH0ltitBderyFLPbagGW4SDTi7hFe8AbiRNm9sPWyBjYk OORU2Upt91N++sTh7xHoxq8bJhqWYL0ZhGOE+tbbwl2LgMAjOXaQFYXTX5Tnl/Mm 7XNVATlhfhpN7Xc9ddijtNasUBFYNAvaBdme/d1h/FOD9gy3nFO2i/w828g+zlIM MSBpZCcfRSoUmjc2CSJzHW7DHAhdVxm7J9qbSGDRz7I5FMfrH3ICS2ufDoHyNmlr fqB18iTbkwktkDQwm5rcUGhDEGp19hFCr7qmu4NPeQ+FhTM9TtkxYB+E4gZm74Tu OvUoI4fbMJIlcLoKw8OBT+l8eX2e5CuWqpHokpwDLdXxjHZwtQIoSKLJvRQliGw0 fs7UR7wHhTWCmSwx1bhghcCLHDLQewjZzS0gqX957ks33+Djq7I2dX3EUUdwd+15 bGgsTiSmr6p8hFzPm2t0ZIyg2g9Lj2cGk+O36FYJtvps9VfiBcK9+CecZbQ73Zs5 godvAr3BPCDAKJlGekXOztiK5EoYN6XmGB09IR+0inCfMv6o9jFn7AiUqDjNVq2i e3762EZuD8nKwv8FlWsj2LIkD0g/6B+mwTJ/WPBNYWzr2o1RuD8= =Y5PQ -----END PGP SIGNATURE----- --6ypjwqqmzlry6ejt--