Hi Laurent,

On Tue, Aug 27, 2019 at 01:43:37AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> Should you squash this with the patches that add CMM units to the other
> SoCs ?

I don't know, I guess it depends on Geert's preferences. Geert?


>
> On Sun, Aug 25, 2019 at 03:51:43PM +0200, Jacopo Mondi wrote:
> > Add CMM units to Renesas R-Car M3-W device tree and reference them from
> > the Display Unit they are connected to.
> >
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
>
> Apart from the issue pointed out by Geert,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > ---
> >  arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25 ++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > index 3dc9d73f589a..8d78e1f98a23 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > @@ -2613,6 +2613,30 @@
> >  			renesas,fcp = <&fcpvi0>;
> >  		};
> >
> > +		cmm0: cmm@fea40000 {
> > +			compatible = "renesas,cmm-r8a7796";
> > +			reg = <0 0xfea40000 0 0x1000>;
> > +			clocks = <&cpg CPG_MOD 711>;
> > +			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> > +			resets = <&cpg 711>;
> > +		};
> > +
> > +		cmm1: cmm@fea50000 {
> > +			compatible = "renesas,cmm-r8a7796";
> > +			reg = <0 0xfea50000 0 0x1000>;
> > +			clocks = <&cpg CPG_MOD 710>;
> > +			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> > +			resets = <&cpg 710>;
> > +		};
> > +
> > +		cmm2: cmm@fea60000 {
> > +			compatible = "renesas,cmm-r8a7796";
> > +			reg = <0 0xfea60000 0 0x1000>;
> > +			clocks = <&cpg CPG_MOD 709>;
> > +			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> > +			resets = <&cpg 709>;
> > +		};
> > +
> >  		csi20: csi2@fea80000 {
> >  			compatible = "renesas,r8a7796-csi2";
> >  			reg = <0 0xfea80000 0 0x10000>;
> > @@ -2766,6 +2790,7 @@
> >  			status = "disabled";
> >
> >  			vsps = <&vspd0 &vspd1 &vspd2>;
> > +			cmms = <&cmm0 &cmm1 &cmm2>;
> >
> >  			ports {
> >  				#address-cells = <1>;
>
> --
> Regards,
>
> Laurent Pinchart