All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Krempa <pkrempa@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
	Vanderson Martins do Rosario <vandersonmr2@gmail.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Like Xu <like.xu@linux.intel.com>,
	Erik Skultety <eskultet@redhat.com>,
	qemu-stable@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
	qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,
	Paolo Bonzini <pbonzini@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2] pc: Don't make die-id mandatory unless necessary
Date: Thu, 29 Aug 2019 15:46:40 +0200	[thread overview]
Message-ID: <20190829134640.GK13714@angien.pipo.sk> (raw)
In-Reply-To: <20190829131225.GJ13714@angien.pipo.sk>

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

On Thu, Aug 29, 2019 at 15:12:33 +0200, Peter Krempa wrote:
> On Wed, Aug 28, 2019 at 18:57:18 +0200, Igor Mammedov wrote:
> > On Wed, 28 Aug 2019 11:35:24 -0300

[...]

> > Also if we would need to change implicit values logic down the road
> > it would be a pain like with any default parameters in QEMU, which is
> > a good reason against relaxing rule.
> 
> Hi,
> 
> after a discussion with Igor I'm preparing patches which take the
> 'props' verbatim and use it for hotplug. It's a fairly simple change in
> libvirt. Originally I've opted to reconstruct the props from internal
> data since it was simpler as the values were already parsed into
> internal structures anyways.
> 
> With some persuation we could even get it into libvirt during the freeze
> so that with new libvirt the released stuff will not break any more.

https://www.redhat.com/archives/libvir-list/2019-August/msg01322.html


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-08-29 13:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16 17:07 [Qemu-devel] [PATCH v2] pc: Don't make die-id mandatory unless necessary Eduardo Habkost
2019-08-26 14:05 ` Igor Mammedov
2019-08-28  6:52 ` Markus Armbruster
2019-08-28 14:35   ` Eduardo Habkost
2019-08-28 16:57     ` Igor Mammedov
2019-08-29 13:12       ` Peter Krempa
2019-08-29 13:46         ` Peter Krempa [this message]
2021-02-03 16:07       ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190829134640.GK13714@angien.pipo.sk \
    --to=pkrempa@redhat.com \
    --cc=armbru@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=ehabkost@redhat.com \
    --cc=eskultet@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=like.xu@linux.intel.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=vandersonmr2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.