From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DD2CC3A5A4 for ; Fri, 30 Aug 2019 13:20:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BBC521897 for ; Fri, 30 Aug 2019 13:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567171239; bh=SK7MIU26ekdFufN9wFcNBBpMKeHmFfdUbjP+h2nZYvI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=T2oNmvKamqiTY6mF+PdE6kWUwovYdVAxYsQd9e9rRIEzZzJl3MISAlJQ4r0dEbGAW MIGS9tF574uo+wbpUHGar38Ck4BKgCHbX8OFuns6jDLs4MVltGReSo3U5tQXc5SdJW 7z0wSLpwkQWM4owBxMv/L1TjSR4c3HsXclb6THqo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727936AbfH3NUi (ORCPT ); Fri, 30 Aug 2019 09:20:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:32950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727135AbfH3NUi (ORCPT ); Fri, 30 Aug 2019 09:20:38 -0400 Received: from localhost (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E0A72186A; Fri, 30 Aug 2019 13:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567171237; bh=SK7MIU26ekdFufN9wFcNBBpMKeHmFfdUbjP+h2nZYvI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kwwbxERsPTczwEsIdSPds2TKEG8g1kxDybF1PiA0Z0k+fDM25ivomVokZGGEPDksp V5RitlF0EmcbfhMrs9eRJRJvkJNLgEqIMUh1urS042x+/5RNzhWrXyLQOLdO8LwvzU U8zyEwOecd8CSGBUqh2E+L94YyODq2KLxmWw6Pco= Date: Fri, 30 Aug 2019 15:20:34 +0200 From: Maxime Ripard To: Marcel Holtmann Cc: megous@megous.com, Chen-Yu Tsai , Rob Herring , Johan Hedberg , Mark Rutland , "David S. Miller" , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org Subject: Re: [RESEND PATCH 0/5] Add bluetooth support for Orange Pi 3 Message-ID: <20190830132034.u65arlv7umh64lx6@flea> References: <20190823103139.17687-1-megous@megous.com> <5524D5E9-FA82-4244-A91F-78CF1C3FB3FB@holtmann.org> <20190830092104.odipmbflounqpffo@flea> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 30, 2019 at 02:43:48PM +0200, Marcel Holtmann wrote: > >>> (Resend to add missing lists, sorry for the noise.) > >>> > >>> This series implements bluetooth support for Xunlong Orange Pi 3 board. > >>> > >>> The board uses AP6256 WiFi/BT 5.0 chip. > >>> > >>> Summary of changes: > >>> > >>> - add more delay to let initialize the chip > >>> - let the kernel detect firmware file path > >>> - add new compatible and update dt-bindings > >>> - update Orange Pi 3 / H6 DTS > >>> > >>> Please take a look. > >>> > >>> thank you and regards, > >>> Ondrej Jirman > >>> > >>> Ondrej Jirman (5): > >>> dt-bindings: net: Add compatible for BCM4345C5 bluetooth device > >>> bluetooth: bcm: Add support for loading firmware for BCM4345C5 > >>> bluetooth: hci_bcm: Give more time to come out of reset > >>> arm64: dts: allwinner: h6: Add pin configs for uart1 > >>> arm64: dts: allwinner: orange-pi-3: Enable UART1 / Bluetooth > >>> > >>> .../bindings/net/broadcom-bluetooth.txt | 1 + > >>> .../dts/allwinner/sun50i-h6-orangepi-3.dts | 19 +++++++++++++++++++ > >>> arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 10 ++++++++++ > >>> drivers/bluetooth/btbcm.c | 3 +++ > >>> drivers/bluetooth/hci_bcm.c | 3 ++- > >>> 5 files changed, 35 insertions(+), 1 deletion(-) > >> > >> all 5 patches have been applied to bluetooth-next tree. > > > > The DTS patches (last 2) should go through the arm-soc tree, can you > > drop them? > > why is that? We have included DTS changes for Bluetooth devices > directly all the time. What is different with this hardware? I guess some maintainers are more relaxed with it than we are then, but for the why, well, it's the usual reasons, the most immediate one being that it reduces to a minimum the conflicts between trees. The other being that it's not really usual to merge patches supposed to be handled by another maintainer without (at least) his consent. I'm pretty sure you would have asked the same request if I would have merged the bluetooth patches through my tree without notice. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8EC8C3A5A4 for ; Fri, 30 Aug 2019 13:20:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9794922CE3 for ; Fri, 30 Aug 2019 13:20:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eaabeQU7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="kwwbxERs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9794922CE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=69cC3eKokNEazFVQFQp1xMA0IkWzydICIoJ/45lX5+Y=; b=eaabeQU7sFbuL1 wEgIlICzbH7PNi6I1YBxeln4JMqBhPi9y5dAlI26MHD6kEJyMRK9GHOHVHCJEy4lLR2a+FdBOUtaw VJXn8Xn15CKoLPA+ND8GwFe4FUvB7Be9Sv4r8sgvOtqveyFTZjLVDA1WBf1BrT2U6RElaj2kiijTp xsQmadDVIukgkid/kP1geH9H7P6vWpaq/iyFC4F0iefhpnnZuUAgTZBjw2iYJdJV4bI/RTRT74O60 YpR4uE8Rr+9V3pMWOrRuxXKMz8LuWrFvo0k6O8S57TW5azfCPEVdN9gvEMW2r0FdG7UKqVs19ZIqe shb5QaRits+4GpZBIyig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i3gpU-0000D0-NU; Fri, 30 Aug 2019 13:20:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i3gpR-0000Cb-Kt for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2019 13:20:39 +0000 Received: from localhost (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E0A72186A; Fri, 30 Aug 2019 13:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567171237; bh=SK7MIU26ekdFufN9wFcNBBpMKeHmFfdUbjP+h2nZYvI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kwwbxERsPTczwEsIdSPds2TKEG8g1kxDybF1PiA0Z0k+fDM25ivomVokZGGEPDksp V5RitlF0EmcbfhMrs9eRJRJvkJNLgEqIMUh1urS042x+/5RNzhWrXyLQOLdO8LwvzU U8zyEwOecd8CSGBUqh2E+L94YyODq2KLxmWw6Pco= Date: Fri, 30 Aug 2019 15:20:34 +0200 From: Maxime Ripard To: Marcel Holtmann Subject: Re: [RESEND PATCH 0/5] Add bluetooth support for Orange Pi 3 Message-ID: <20190830132034.u65arlv7umh64lx6@flea> References: <20190823103139.17687-1-megous@megous.com> <5524D5E9-FA82-4244-A91F-78CF1C3FB3FB@holtmann.org> <20190830092104.odipmbflounqpffo@flea> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190830_062037_712203_C82050F5 X-CRM114-Status: GOOD ( 19.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: megous@megous.com, Mark Rutland , Johan Hedberg , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, Chen-Yu Tsai , Rob Herring , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 30, 2019 at 02:43:48PM +0200, Marcel Holtmann wrote: > >>> (Resend to add missing lists, sorry for the noise.) > >>> > >>> This series implements bluetooth support for Xunlong Orange Pi 3 board. > >>> > >>> The board uses AP6256 WiFi/BT 5.0 chip. > >>> > >>> Summary of changes: > >>> > >>> - add more delay to let initialize the chip > >>> - let the kernel detect firmware file path > >>> - add new compatible and update dt-bindings > >>> - update Orange Pi 3 / H6 DTS > >>> > >>> Please take a look. > >>> > >>> thank you and regards, > >>> Ondrej Jirman > >>> > >>> Ondrej Jirman (5): > >>> dt-bindings: net: Add compatible for BCM4345C5 bluetooth device > >>> bluetooth: bcm: Add support for loading firmware for BCM4345C5 > >>> bluetooth: hci_bcm: Give more time to come out of reset > >>> arm64: dts: allwinner: h6: Add pin configs for uart1 > >>> arm64: dts: allwinner: orange-pi-3: Enable UART1 / Bluetooth > >>> > >>> .../bindings/net/broadcom-bluetooth.txt | 1 + > >>> .../dts/allwinner/sun50i-h6-orangepi-3.dts | 19 +++++++++++++++++++ > >>> arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 10 ++++++++++ > >>> drivers/bluetooth/btbcm.c | 3 +++ > >>> drivers/bluetooth/hci_bcm.c | 3 ++- > >>> 5 files changed, 35 insertions(+), 1 deletion(-) > >> > >> all 5 patches have been applied to bluetooth-next tree. > > > > The DTS patches (last 2) should go through the arm-soc tree, can you > > drop them? > > why is that? We have included DTS changes for Bluetooth devices > directly all the time. What is different with this hardware? I guess some maintainers are more relaxed with it than we are then, but for the why, well, it's the usual reasons, the most immediate one being that it reduces to a minimum the conflicts between trees. The other being that it's not really usual to merge patches supposed to be handled by another maintainer without (at least) his consent. I'm pretty sure you would have asked the same request if I would have merged the bluetooth patches through my tree without notice. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel