From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B8A7C3A59E for ; Mon, 2 Sep 2019 12:31:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2CD6A20820 for ; Mon, 2 Sep 2019 12:31:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="nZE3UBBQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731486AbfIBMba (ORCPT ); Mon, 2 Sep 2019 08:31:30 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:45292 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729999AbfIBMba (ORCPT ); Mon, 2 Sep 2019 08:31:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UtOXrhZ6Qo2E9DiEP7YXIr28AIXW+0S0Ci2r4SnPHSc=; b=nZE3UBBQdpl31RWqK8b4lIqyc YNuxzTF6JzAbvix1mEl6wIYepkdU5wsfqTp2AI2Z5LCz+DvE1PglTfCQkjncbxOcdLPmpxi+KWjV4 Rk/fESJLFGmo7mdQYNkbb8dq5A3BH6QbTcRnQ2rNyvZwMIdernWqo55AdvxwBMkj7No3/PcYu0Vlb oqonhW0z/6oPX3i1RL/OKFNUwyiTpkRanwau/B/TNZ6JhWY22G2VBP3DoBv5sghAgqE8GMdAkEqfU xWUBQmZrMYo5Vc1XQLIbyE76Yr08z0HT5raE7mEGwqHLk2ev/FFbbsmkgVuHAycF2Z0YVH1xSdLaO iyykZgaKg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i4lUS-0005TK-Qb; Mon, 02 Sep 2019 12:31:24 +0000 Date: Mon, 2 Sep 2019 05:31:24 -0700 From: Christoph Hellwig To: Gao Xiang Cc: Christoph Hellwig , Chao Yu , Greg Kroah-Hartman , linux-fsdevel@vger.kernel.org, devel@driverdev.osuosl.org, linux-erofs@lists.ozlabs.org, Chao Yu , Gao Xiang Subject: Re: [PATCH 20/21] erofs: kill use_vmap module parameter Message-ID: <20190902123124.GR15931@infradead.org> References: <20190802125347.166018-1-gaoxiang25@huawei.com> <20190901055130.30572-1-hsiangkao@aol.com> <20190901055130.30572-21-hsiangkao@aol.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190901055130.30572-21-hsiangkao@aol.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org > @@ -224,9 +220,6 @@ static void *erofs_vmap(struct page **pages, unsigned int count) > { > int i = 0; > > - if (use_vmap) > - return vmap(pages, count, VM_MAP, PAGE_KERNEL); > - > while (1) { > void *addr = vm_map_ram(pages, count, -1, PAGE_KERNEL); I think you can just open code this in the caller. > static void erofs_vunmap(const void *mem, unsigned int count) > { > - if (!use_vmap) > - vm_unmap_ram(mem, count); > - else > - vunmap(mem); > + vm_unmap_ram(mem, count); > } And this wrapper can go away entirely. And don't forget to report your performance observations to the arm64 maintainers! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 246BCC3A59E for ; Mon, 2 Sep 2019 12:31:39 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6D8020820 for ; Mon, 2 Sep 2019 12:31:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="nZE3UBBQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6D8020820 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 80EC420525; Mon, 2 Sep 2019 12:31:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qClpt+JTtsmX; Mon, 2 Sep 2019 12:31:33 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id A2EEC214FD; Mon, 2 Sep 2019 12:31:33 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 1F7571BF359 for ; Mon, 2 Sep 2019 12:31:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 164C2863F4 for ; Mon, 2 Sep 2019 12:31:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RetlbBoL5SZ9 for ; Mon, 2 Sep 2019 12:31:30 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by whitealder.osuosl.org (Postfix) with ESMTPS id CB0BF8674D for ; Mon, 2 Sep 2019 12:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UtOXrhZ6Qo2E9DiEP7YXIr28AIXW+0S0Ci2r4SnPHSc=; b=nZE3UBBQdpl31RWqK8b4lIqyc YNuxzTF6JzAbvix1mEl6wIYepkdU5wsfqTp2AI2Z5LCz+DvE1PglTfCQkjncbxOcdLPmpxi+KWjV4 Rk/fESJLFGmo7mdQYNkbb8dq5A3BH6QbTcRnQ2rNyvZwMIdernWqo55AdvxwBMkj7No3/PcYu0Vlb oqonhW0z/6oPX3i1RL/OKFNUwyiTpkRanwau/B/TNZ6JhWY22G2VBP3DoBv5sghAgqE8GMdAkEqfU xWUBQmZrMYo5Vc1XQLIbyE76Yr08z0HT5raE7mEGwqHLk2ev/FFbbsmkgVuHAycF2Z0YVH1xSdLaO iyykZgaKg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i4lUS-0005TK-Qb; Mon, 02 Sep 2019 12:31:24 +0000 Date: Mon, 2 Sep 2019 05:31:24 -0700 From: Christoph Hellwig To: Gao Xiang Subject: Re: [PATCH 20/21] erofs: kill use_vmap module parameter Message-ID: <20190902123124.GR15931@infradead.org> References: <20190802125347.166018-1-gaoxiang25@huawei.com> <20190901055130.30572-1-hsiangkao@aol.com> <20190901055130.30572-21-hsiangkao@aol.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190901055130.30572-21-hsiangkao@aol.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Chao Yu , Greg Kroah-Hartman , Chao Yu , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" > @@ -224,9 +220,6 @@ static void *erofs_vmap(struct page **pages, unsigned int count) > { > int i = 0; > > - if (use_vmap) > - return vmap(pages, count, VM_MAP, PAGE_KERNEL); > - > while (1) { > void *addr = vm_map_ram(pages, count, -1, PAGE_KERNEL); I think you can just open code this in the caller. > static void erofs_vunmap(const void *mem, unsigned int count) > { > - if (!use_vmap) > - vm_unmap_ram(mem, count); > - else > - vunmap(mem); > + vm_unmap_ram(mem, count); > } And this wrapper can go away entirely. And don't forget to report your performance observations to the arm64 maintainers! _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19649C3A59E for ; Mon, 2 Sep 2019 12:31:41 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9277220820 for ; Mon, 2 Sep 2019 12:31:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="nZE3UBBQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9277220820 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46MTwT6bMWzDqZD for ; Mon, 2 Sep 2019 22:31:37 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=bombadil.srs.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=batv+8d7e6b8ef813b711cfc0+5853+infradead.org+hch@bombadil.srs.infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="nZE3UBBQ"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46MTwN5s8HzDqH1 for ; Mon, 2 Sep 2019 22:31:32 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UtOXrhZ6Qo2E9DiEP7YXIr28AIXW+0S0Ci2r4SnPHSc=; b=nZE3UBBQdpl31RWqK8b4lIqyc YNuxzTF6JzAbvix1mEl6wIYepkdU5wsfqTp2AI2Z5LCz+DvE1PglTfCQkjncbxOcdLPmpxi+KWjV4 Rk/fESJLFGmo7mdQYNkbb8dq5A3BH6QbTcRnQ2rNyvZwMIdernWqo55AdvxwBMkj7No3/PcYu0Vlb oqonhW0z/6oPX3i1RL/OKFNUwyiTpkRanwau/B/TNZ6JhWY22G2VBP3DoBv5sghAgqE8GMdAkEqfU xWUBQmZrMYo5Vc1XQLIbyE76Yr08z0HT5raE7mEGwqHLk2ev/FFbbsmkgVuHAycF2Z0YVH1xSdLaO iyykZgaKg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i4lUS-0005TK-Qb; Mon, 02 Sep 2019 12:31:24 +0000 Date: Mon, 2 Sep 2019 05:31:24 -0700 From: Christoph Hellwig To: Gao Xiang Subject: Re: [PATCH 20/21] erofs: kill use_vmap module parameter Message-ID: <20190902123124.GR15931@infradead.org> References: <20190802125347.166018-1-gaoxiang25@huawei.com> <20190901055130.30572-1-hsiangkao@aol.com> <20190901055130.30572-21-hsiangkao@aol.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190901055130.30572-21-hsiangkao@aol.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" > @@ -224,9 +220,6 @@ static void *erofs_vmap(struct page **pages, unsigned int count) > { > int i = 0; > > - if (use_vmap) > - return vmap(pages, count, VM_MAP, PAGE_KERNEL); > - > while (1) { > void *addr = vm_map_ram(pages, count, -1, PAGE_KERNEL); I think you can just open code this in the caller. > static void erofs_vunmap(const void *mem, unsigned int count) > { > - if (!use_vmap) > - vm_unmap_ram(mem, count); > - else > - vunmap(mem); > + vm_unmap_ram(mem, count); > } And this wrapper can go away entirely. And don't forget to report your performance observations to the arm64 maintainers!