From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD644C3A59E for ; Mon, 2 Sep 2019 16:12:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CA732173E for ; Mon, 2 Sep 2019 16:12:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V0DDFQ4f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CA732173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U1K/ABcRneOLf5oCwsWecorh80v6MzjHNaVG9wGhmLI=; b=V0DDFQ4fpj82b+ 1S9wDInJpLyrGMVRUZRckrJkDI6lPyglZioq7o9I8Et4ddaGDydNvwSsIg11qLSAkJipymCdn7wsG MZ/pI6NCryXNXGgDRF8ExWKo6Rxjey8++8YJlp53Uk6Xy66XU3LiU/PE+XxKIM1Mx1+g8OJRiNO8L j3o0udCvYAgAaNvC+sEuoWhphCMASXhX0C332tlZ7CSHTQtsFgqqLGdAFB8M7QKZYHsYK/Ya2gN8d q7/BrPg/QOeBSfZtbufhQQcIGn0HkHdEx5Cw45j+69AO2PbIWdeZEIzM0X99uML7o5fsBe6uEgdrF 7vOAMFvjV/FBN3nQknqw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i4owO-0008Px-La; Mon, 02 Sep 2019 16:12:28 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i4owN-0008Po-Aq; Mon, 02 Sep 2019 16:12:27 +0000 Date: Mon, 2 Sep 2019 09:12:27 -0700 From: Christoph Hellwig To: James Smart Subject: Re: [PATCH] nvme: Treat discovery subsystems as unique subsystems Message-ID: <20190902161227.GA27231@infradead.org> References: <20190830201145.6729-1-jsmart2021@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190830201145.6729-1-jsmart2021@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-nvme@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Aug 30, 2019 at 01:11:45PM -0700, James Smart wrote: > @@ -2358,6 +2358,9 @@ static struct nvme_subsystem *__nvme_find_get_subsystem(const char *subsysnqn) > > lockdep_assert_held(&nvme_subsystems_lock); > > + if (!strcmp(subsysnqn, NVME_DISC_SUBSYS_NAME)) > + return NULL; > + Can you throw in a comment here? Otherwise this looks good: Reviewed-by: Christoph Hellwig _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme