All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libuwsc: new package
Date: Tue, 3 Sep 2019 08:20:47 +0300	[thread overview]
Message-ID: <20190903052047.vensyjfkuve7pgxf@sapphire.tkos.co.il> (raw)
In-Reply-To: <KL1PR0201MB21194E30E14A3D58B3090993FAB90@KL1PR0201MB2119.apcprd02.prod.outlook.com>

Hi Jianhui Zhao,

Thanks for your contribution.

I have a few comments below.

On Tue, Sep 03, 2019 at 04:54:00AM +0000, ? ?? wrote:
> Signed-off-by: Jianhui Zhao <zhaojh329@outlook.com>

Your sign-off name should match the patch author name which is taken from the 
email From: header by default.

> ---
> ?package/Config.in ? ? ? ? ?| ?1 +
> ?package/libuwsc/Config.in ?| ?8 ++++++++
> ?package/libuwsc/libuwsc.mk | 13 +++++++++++++

You should add a .hash file listing hashes of tarball and license file.

> ?3 files changed, 22 insertions(+)
> ?create mode 100644 package/libuwsc/Config.in
> ?create mode 100644 package/libuwsc/libuwsc.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 710ed12be0..d1ea644cd2 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1622,6 +1622,7 @@ menu "Networking"
> ? ? ? ? source "package/libupnp18/Config.in"
> ? ? ? ? source "package/libupnpp/Config.in"
> ? ? ? ? source "package/liburiparser/Config.in"
> + ? ? ? source "package/libuwsc/Config.in"
> ? ? ? ? source "package/libvncserver/Config.in"
> ? ? ? ? source "package/libwebsock/Config.in"
> ? ? ? ? source "package/libwebsockets/Config.in"
> diff --git a/package/libuwsc/Config.in b/package/libuwsc/Config.in
> new file mode 100644
> index 0000000000..ae99b6d2dc
> --- /dev/null
> +++ b/package/libuwsc/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_LIBUWSC
> + ? ? ? bool "libuwsc"
> + ? ? ? select BR2_PACKAGE_LIBEV
> + ? ? ? help
> + ? ? ? ? A Lightweight and fully asynchronous WebSocket client
> + ? ? ? ? library based on libev.
> +
> + ? ? ? ? https://github.com/zhaojh329/libuwsc
> diff --git a/package/libuwsc/libuwsc.mk b/package/libuwsc/libuwsc.mk
> new file mode 100644
> index 0000000000..354a866739
> --- /dev/null
> +++ b/package/libuwsc/libuwsc.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# libuwsc
> +#
> +################################################################################
> +
> +LIBUWSC_VERSION = 3.3.2
> +LIBUWSC_SITE = https://github.com/zhaojh329/libuwsc/releases/download/v$(LIBUWSC_VERSION)
> +LIBUWSC_LICENSE = MIT

Please add

  LIBUWSC_LICENSE_FILES = LICENSE

> +LIBUWSC_INSTALL_STAGING = YES
> +LIBUWSC_DEPENDENCIES = libev

README.md mentions optional dependency on openssl, mbedtls and wolfssl for 
SSL. It would be nice to optionally support that when one of them is enabled.

> +
> +$(eval $(cmake-package))

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2019-09-03  5:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-03  4:54 [Buildroot] [PATCH 1/1] libuwsc: new package 赵 建辉
2019-09-03  5:20 ` Baruch Siach [this message]
2019-09-03  8:29 赵建辉
2019-09-05 10:46 ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190903052047.vensyjfkuve7pgxf@sapphire.tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.