From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE80C3A5A8 for ; Tue, 3 Sep 2019 06:28:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C74DB21897 for ; Tue, 3 Sep 2019 06:28:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wL2ybVnw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726557AbfICG2M (ORCPT ); Tue, 3 Sep 2019 02:28:12 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:40498 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbfICG2L (ORCPT ); Tue, 3 Sep 2019 02:28:11 -0400 Received: by mail-pg1-f195.google.com with SMTP id w10so8546294pgj.7 for ; Mon, 02 Sep 2019 23:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3UjuVbvJVhJAU0IH4ZbNm2Jlx5L7+f9v4Qm0AxsrvR0=; b=wL2ybVnw/vZTE94Xlb5xNn6xFzOU0UBcajT5ZX8iLCFCwV0n5PB4oIlQz48eacDYVj ytsZyjwjhWQ1OyE6tUH5+Fw3vuDDJRwzLal/K5HBzVBwgrKvvmMe5GeNlWO1WhxyccUV TwlIgLZwtVm9qfRHB4O//OKoPLU1wfEtKHfj06We2tjZQBl2SBKGSCKkfScfh/XMv6a3 Jxwa+zf0f/0wDZhgKmHEzqJdf/zypEzxM+/ZA4H8i6bRuUpTHWUWP8CO2c1uSie3Gvy5 DPrjLacNZAls6mFBSNsEmMyRo9L784IaV/PYWdAlL4gBtSGkIK6Qvsz1M7uDfjwIDexd VLCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3UjuVbvJVhJAU0IH4ZbNm2Jlx5L7+f9v4Qm0AxsrvR0=; b=gc6BHYqLgq6nL6iarH8penouLseRo5HfcZ9+sNmWk4w20VJeOXpTQS/rM3CFU/Z57u sW1H15wSYPXctij3wEd6U5NOF0K3Ny941LIGXl61zgQ7WfYMU82aZyG+B1K5HpBy1rC+ 9E/sq2w6jQnWE12jatn9nsod3yD/gIKR53YaNm7Eug6x5ob5GVKN1vO7m3Drszb5XaH6 ZgEFqAeV4UB5VWIrhwzZL3Fcyg43rs88bP5vgRAGDfyCqx/2C1uIqyXq+f1WUNdWEN/5 c9CCfufjC7iJNpGZjbf9/T3F67htmr8SfoKKg5PeA2aCXsCUD8lysMxaIB9Qwpami9Cv wRDA== X-Gm-Message-State: APjAAAXc0Le0P7mE6HfTO92P+UOoiSA5kijhMJmO/WYNZFkkE+MJBcdX bJ20++ZPnGNj06x4hnIXdUtwiQ== X-Google-Smtp-Source: APXvYqwazyPlv855qi7l9Cvtv6Ry/4WLau0L7ow/Xvvtoyuzbt1Tlw+/d8AZcxMClQX/5LVzlajoKw== X-Received: by 2002:a62:e802:: with SMTP id c2mr2520855pfi.212.1567492090953; Mon, 02 Sep 2019 23:28:10 -0700 (PDT) Received: from localhost ([122.167.132.221]) by smtp.gmail.com with ESMTPSA id b5sm23696486pfp.38.2019.09.02.23.28.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Sep 2019 23:28:10 -0700 (PDT) Date: Tue, 3 Sep 2019 11:58:08 +0530 From: Viresh Kumar To: "H. Nikolaus Schaller" Cc: =?utf-8?Q?Beno=C3=AEt?= Cousson , Tony Lindgren , Rob Herring , Adam Ford , =?utf-8?B?QW5kcsOp?= Roth , Mark Rutland , "Rafael J. Wysocki" , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Subject: Re: [RFC 4/5] ARM: dts: omap3-n950-n9: remove opp-v1 table Message-ID: <20190903062808.p6jkgwylyqxcjs4z@vireshk-i7> References: <2f978667c1533e46e3a5df58871e9048f3eb74e9.1567421751.git.hns@goldelico.com> <20190903023635.44yf32jowpm3hgfp@vireshk-i7> <8BC1AEC9-7B24-4C07-8659-16741D018164@goldelico.com> <20190903061403.k3d333f54gj2kuxi@vireshk-i7> <6B7B0EDB-8A60-48A0-AFAB-8A266358300C@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6B7B0EDB-8A60-48A0-AFAB-8A266358300C@goldelico.com> User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03-09-19, 08:23, H. Nikolaus Schaller wrote: > > > Am 03.09.2019 um 08:14 schrieb Viresh Kumar : > > > > On 03-09-19, 08:01, H. Nikolaus Schaller wrote: > >> > >>> Am 03.09.2019 um 04:36 schrieb Viresh Kumar : > >>> > >>> On 02-09-19, 12:55, H. Nikolaus Schaller wrote: > >>>> With opp-v2 in omap36xx.dtsi and ti-cpufreq driver the > >>>> 1GHz capability is automatically detected. > >>>> > >>>> Signed-off-by: H. Nikolaus Schaller > >>>> --- > >>>> arch/arm/boot/dts/omap3-n950-n9.dtsi | 7 ------- > >>>> 1 file changed, 7 deletions(-) > >>>> > >>>> diff --git a/arch/arm/boot/dts/omap3-n950-n9.dtsi b/arch/arm/boot/dts/omap3-n950-n9.dtsi > >>>> index 5441e9ffdbb4..e98b0c615f19 100644 > >>>> --- a/arch/arm/boot/dts/omap3-n950-n9.dtsi > >>>> +++ b/arch/arm/boot/dts/omap3-n950-n9.dtsi > >>>> @@ -11,13 +11,6 @@ > >>>> cpus { > >>>> cpu@0 { > >>>> cpu0-supply = <&vcc>; > >>>> - operating-points = < > >>>> - /* kHz uV */ > >>>> - 300000 1012500 > >>>> - 600000 1200000 > >>>> - 800000 1325000 > >>>> - 1000000 1375000 > >>>> - >; > >>>> }; > >>>> }; > >>> > >>> This should be merged with 2/5 ? > >> > >> Well, it bloats 2/5. > > > > It is logically the right place to do this as that's where we are > > adding opp-v2. > > Well, sometimes the philosophy of patches is to add something new > first and remove the old in a second separate patch if the system > can live with both. This makes it easier to digest single patches > (because they are smaller) and might also better pinpoint an issue > by bisect. Right, but you already removed some of the opp-v1 stuff in patch 2/5. Why leave this one out ? > > > >> What I hope (I can't test) is that this opp-v1 table > >> is ignored if an opp-v2 table exists. So that it can be > >> removed by a separate follow-up patch. > > > > It should work as that's what we are doing in OPP core, but I still > > feel this better get merged with 2/5. > > Ok, I see. Noted for RFCv2. > > There will also be a big batch of changes for the compatible record > (omap3530->omap35xx, add omap34xx where needed) of ca. 10 board definition > DTS files. Should this then also become part of the new 2/5? Compatible thing should be separate patch anyway, I was just talking about replacing opp-v1 with v2. -- viresh