All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PULL v2 16/16] iotests: Unify cache mode quoting
Date: Tue,  3 Sep 2019 15:35:53 +0200	[thread overview]
Message-ID: <20190903133553.6500-17-mreitz@redhat.com> (raw)
In-Reply-To: <20190903133553.6500-1-mreitz@redhat.com>

From: Nir Soffer <nirsof@gmail.com>

Quoting cache mode is not needed, and most tests use unquoted values.
Unify all test to use the same style.

Message-id: 20190827173432.7656-1-nsoffer@redhat.com
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/026 | 4 ++--
 tests/qemu-iotests/039 | 4 ++--
 tests/qemu-iotests/052 | 2 +-
 tests/qemu-iotests/091 | 4 ++--
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/qemu-iotests/026 b/tests/qemu-iotests/026
index e30243608b..ffb18ab6b5 100755
--- a/tests/qemu-iotests/026
+++ b/tests/qemu-iotests/026
@@ -41,8 +41,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 # Currently only qcow2 supports rebasing
 _supported_fmt qcow2
 _supported_proto file
-_default_cache_mode "writethrough"
-_supported_cache_modes "writethrough" "none"
+_default_cache_mode writethrough
+_supported_cache_modes writethrough none
 # The refcount table tests expect a certain minimum width for refcount entries
 # (so that the refcount table actually needs to grow); that minimum is 16 bits,
 # being the default refcount entry width.
diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039
index 0d4e963bd4..7c730d94a7 100755
--- a/tests/qemu-iotests/039
+++ b/tests/qemu-iotests/039
@@ -42,8 +42,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 _supported_fmt qcow2
 _supported_proto file
 _supported_os Linux
-_default_cache_mode "writethrough"
-_supported_cache_modes "writethrough"
+_default_cache_mode writethrough
+_supported_cache_modes writethrough
 
 size=128M
 
diff --git a/tests/qemu-iotests/052 b/tests/qemu-iotests/052
index 6e2ecbfe21..45a140910d 100755
--- a/tests/qemu-iotests/052
+++ b/tests/qemu-iotests/052
@@ -40,7 +40,7 @@ _supported_fmt generic
 _supported_proto file
 
 # Don't do O_DIRECT on tmpfs
-_supported_cache_modes "writeback" "writethrough" "unsafe"
+_supported_cache_modes writeback writethrough unsafe
 
 size=128M
 _make_test_img $size
diff --git a/tests/qemu-iotests/091 b/tests/qemu-iotests/091
index d62ef18a02..f4b44659ae 100755
--- a/tests/qemu-iotests/091
+++ b/tests/qemu-iotests/091
@@ -46,8 +46,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 _supported_fmt qcow2
 _supported_proto file
 _supported_os Linux
-_default_cache_mode "none"
-_supported_cache_modes "writethrough" "none" "writeback"
+_default_cache_mode none
+_supported_cache_modes writethrough none writeback
 
 size=1G
 
-- 
2.21.0



  parent reply	other threads:[~2019-09-03 14:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-03 13:35 [Qemu-devel] [PULL v2 00/16] Block patches Max Reitz
2019-09-03 13:35 ` [Qemu-devel] [PULL v2 01/16] qemu-io: add pattern file for write command Max Reitz
2019-09-09 17:26   ` Peter Maydell
2019-09-10  7:19     ` Max Reitz
2019-09-10  7:23       ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2019-09-10  7:59         ` Denis Plotnikov
2019-09-03 13:35 ` [Qemu-devel] [PULL v2 02/16] block: fix permission update in bdrv_replace_node Max Reitz
2019-09-03 13:35 ` [Qemu-devel] [PULL v2 03/16] block: posix: Always allocate the first block Max Reitz
2019-09-03 13:35 ` [Qemu-devel] [PULL v2 04/16] iotests: Test allocate_first_block() with O_DIRECT Max Reitz
2019-09-03 13:35 ` [Qemu-devel] [PULL v2 05/16] iotests: Fix _filter_img_create() Max Reitz
2019-09-03 13:35 ` [Qemu-devel] [PULL v2 06/16] vmdk: Use bdrv_dirname() for relative extent paths Max Reitz
2019-09-03 13:35 ` [Qemu-devel] [PULL v2 07/16] iotests: Keep testing broken " Max Reitz
2019-09-03 13:35 ` [Qemu-devel] [PULL v2 08/16] vmdk: Reject invalid compressed writes Max Reitz
2019-09-03 13:35 ` [Qemu-devel] [PULL v2 09/16] iotests: Disable broken streamOptimized tests Max Reitz
2019-09-03 13:35 ` [Qemu-devel] [PULL v2 10/16] iotests: Disable 110 for vmdk.twoGbMaxExtentSparse Max Reitz
2019-09-03 13:35 ` [Qemu-devel] [PULL v2 11/16] iotests: Disable 126 for flat vmdk subformats Max Reitz
2019-09-03 13:35 ` [Qemu-devel] [PULL v2 12/16] file-posix: fix request_alignment typo Max Reitz
2019-09-03 13:35 ` [Qemu-devel] [PULL v2 13/16] iotests: Add -display none to the qemu options Max Reitz
2019-09-03 13:35 ` [Qemu-devel] [PULL v2 14/16] iotests: Check for enabled drivers before testing them Max Reitz
2019-09-03 13:35 ` [Qemu-devel] [PULL v2 15/16] tests/check-block: Skip iotests when sanitizers are enabled Max Reitz
2019-09-03 13:35 ` Max Reitz [this message]
2019-09-04 12:58 ` [Qemu-devel] [PULL v2 00/16] Block patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190903133553.6500-17-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.