From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A8DCC3A5A2 for ; Tue, 3 Sep 2019 17:15:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FE8321881 for ; Tue, 3 Sep 2019 17:15:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="XNENZrSG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729921AbfICRP6 (ORCPT ); Tue, 3 Sep 2019 13:15:58 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:58522 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729644AbfICRP6 (ORCPT ); Tue, 3 Sep 2019 13:15:58 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x83HEmHY075748; Tue, 3 Sep 2019 17:15:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=cm5GfM2EYao3i13gWuQKtAMJheqvO1OixMftqPwl+sY=; b=XNENZrSGEEh0it3hS5M4643CqbNUMSZfNp+utM3towyR363KXmecUHW0OypjZSowrUsl kRFeGsFU1y8ojvq7gHXyvKg5YYRwds8PJgB2AePXc3Ifs3eIu639I09C5asQUg1lIsoG WOgeF6hXSTCNhZh/XBCoC096ronBbuTzKoSeHB5mCS+CkpLefmTvFNsMRQqtFHJNLFC0 u2YY+TKLhV7Px7rRx5DGzefFeVM1F19nSlrWbGxmZQT0WRpPxtLC5+mwShRijCR7deJi f7N3QeyF4lMbwpKA0Z3E7v/dO0mIZ91gZQUbpD/MtEgY/9T8S2GRDoSedNNsoYCYGHiL 6A== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2usvd60095-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Sep 2019 17:15:55 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x83H2rAj167398; Tue, 3 Sep 2019 17:15:55 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 2usu50ttrq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Sep 2019 17:15:54 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x83HFrOD019775; Tue, 3 Sep 2019 17:15:54 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 03 Sep 2019 10:15:53 -0700 Date: Tue, 3 Sep 2019 10:15:52 -0700 From: "Darrick J. Wong" To: Dave Chinner Cc: gg@magnolia, sandeen@sandeen.net, linux-xfs@vger.kernel.org Subject: Re: [PATCH 02/12] libxfs: move topology declarations into separate header Message-ID: <20190903171552.GG568270@magnolia> References: <156633307176.1215978.17394956977918540525.stgit@magnolia> <156633308405.1215978.11329921136072672886.stgit@magnolia> <20190830054304.GD1119@dread.disaster.area> <20190830203402.GF5354@magnolia> <20190902223345.GS1119@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190902223345.GS1119@dread.disaster.area> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9369 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1909030174 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9369 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=-1004 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1909030174 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Sep 03, 2019 at 08:33:46AM +1000, Dave Chinner wrote: > On Fri, Aug 30, 2019 at 01:34:02PM -0700, Darrick J. Wong wrote: > > > > From: Darrick J. Wong > > > > > > > > The topology functions live in libfrog now, which means their > > > > declarations don't belong in libxcmd.h. Create new header file for > > > > them. > > > > > > > > Signed-off-by: Darrick J. Wong > > > > --- > > > > include/libxcmd.h | 31 ------------------------------- > > > > include/topology.h | 39 +++++++++++++++++++++++++++++++++++++++ > > > > libfrog/topology.c | 1 + > > > > mkfs/xfs_mkfs.c | 2 +- > > > > repair/sb.c | 1 + > > > > 5 files changed, 42 insertions(+), 32 deletions(-) > > > > create mode 100644 include/topology.h > > > > > > I like the idea, but I'm wondering if we should have a similar > > > setup to libxfs header files here. > > > > > > i.e. the header file lives in libfrog/, and the install-headers make > > > command creates include/libxfrog and links them for the build. That > > > way the includes become namespaced like: > > > > > > #include "libxfrog/topology,h" > > > > > > and we don't pollute include with random header files from all > > > different parts of xfsprogs... > > > > What if I leave topology.h in libfrog/ and then create an > > include/libfrog.h that pulls in all the libfrog header files like > > libxfs.h does, and then put -I$(TOPDIR)/libfrog in GCFLAGS? > > libxfs is a basket case - it's done that way so we don't need all > the whacky games we play to shim the kernel functionality correctly > in every xfsprogs file that needs libxfs functionality. > > libxfrog is very different - we have progs that just need topology > or number conversion, but not both. I'd prefer for libxfrog we only > include the headers we require, that way avoiding defining things we > don't actually need... Ok. I will go clean that up too.... --D > Cheers, > > Dave. > -- > Dave Chinner > david@fromorbit.com