From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1395C3A5A2 for ; Tue, 3 Sep 2019 18:19:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76AB722DBF for ; Tue, 3 Sep 2019 18:19:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567534791; bh=sZ9Pc23+pIpH3xhR8mnJ/YptPq7C/EftEWGYfNbPqiI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=v2+QjBuNrFCs54gznz/ULGO+5Ndeu2nZ7q+s1Z09xXWoejcfq1q/No96e9NDdPkdZ imdg1Uhgeb+WcFtqFRbWZF/n/606oVSwGAkNZsjFTgHtQib5fTGSyQPLTcvfrJFLhk mcUTldTNQAq/RsoN3Wdk24rhbrzFmMCzDpRccmD4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730160AbfICSTu (ORCPT ); Tue, 3 Sep 2019 14:19:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:44170 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727667AbfICSTt (ORCPT ); Tue, 3 Sep 2019 14:19:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B805321897; Tue, 3 Sep 2019 18:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567534789; bh=sZ9Pc23+pIpH3xhR8mnJ/YptPq7C/EftEWGYfNbPqiI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dh7G22g6v9ojEhQhVyP1bQ/i7z2f1oIkxxHtCGOY6RDiXWQD7u7/QSXHRgbGwau/n uHPXNz2NgbAskDei6VvjB7YxC5hId24MVESEYTJbvsJSrtgEo9mW6G0YdSBJaT3Q38 zuiFU2GN38N73ixi1XEPwHFyLkiFXe75E1Ey/NBI= Date: Tue, 3 Sep 2019 20:19:46 +0200 From: Greg Kroah-Hartman To: Al Viro Cc: Valentin Vidic , devel@driverdev.osuosl.org, Valdis Kletnieks , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: exfat: cleanup braces for if/else statements Message-ID: <20190903181946.GA14349@kroah.com> References: <20190903164732.14194-1-vvidic@valentin-vidic.from.hr> <20190903173249.GL1131@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190903173249.GL1131@ZenIV.linux.org.uk> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 03, 2019 at 06:32:49PM +0100, Al Viro wrote: > On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote: > > + } else if (uni == 0xFFFF) { > > skip = TRUE; > > While we are at it, could you get rid of that 'TRUE' macro? > Or added > > #define THE_TRUTH_AND_THATS_CUTTIN_ME_OWN_THROAT true > > if you want to properly emphasize it... No, we don't :) I cleaned up a bunch of those, there are a lot more still left, it is a mess... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A85C3C3A5A2 for ; Tue, 3 Sep 2019 18:19:53 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80BD122D6D for ; Tue, 3 Sep 2019 18:19:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Dh7G22g6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80BD122D6D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 4ED0B88461; Tue, 3 Sep 2019 18:19:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vQlJrh6QtQFp; Tue, 3 Sep 2019 18:19:50 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id E919A8845E; Tue, 3 Sep 2019 18:19:50 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id CE1811BF5A6 for ; Tue, 3 Sep 2019 18:19:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id CB795228D5 for ; Tue, 3 Sep 2019 18:19:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 48hewq3ZCSgl for ; Tue, 3 Sep 2019 18:19:49 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by silver.osuosl.org (Postfix) with ESMTPS id 644C22286F for ; Tue, 3 Sep 2019 18:19:49 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B805321897; Tue, 3 Sep 2019 18:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567534789; bh=sZ9Pc23+pIpH3xhR8mnJ/YptPq7C/EftEWGYfNbPqiI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dh7G22g6v9ojEhQhVyP1bQ/i7z2f1oIkxxHtCGOY6RDiXWQD7u7/QSXHRgbGwau/n uHPXNz2NgbAskDei6VvjB7YxC5hId24MVESEYTJbvsJSrtgEo9mW6G0YdSBJaT3Q38 zuiFU2GN38N73ixi1XEPwHFyLkiFXe75E1Ey/NBI= Date: Tue, 3 Sep 2019 20:19:46 +0200 From: Greg Kroah-Hartman To: Al Viro Subject: Re: [PATCH] staging: exfat: cleanup braces for if/else statements Message-ID: <20190903181946.GA14349@kroah.com> References: <20190903164732.14194-1-vvidic@valentin-vidic.from.hr> <20190903173249.GL1131@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190903173249.GL1131@ZenIV.linux.org.uk> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Valentin Vidic , Valdis Kletnieks , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Tue, Sep 03, 2019 at 06:32:49PM +0100, Al Viro wrote: > On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote: > > + } else if (uni == 0xFFFF) { > > skip = TRUE; > > While we are at it, could you get rid of that 'TRUE' macro? > Or added > > #define THE_TRUTH_AND_THATS_CUTTIN_ME_OWN_THROAT true > > if you want to properly emphasize it... No, we don't :) I cleaned up a bunch of those, there are a lot more still left, it is a mess... _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel