From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jiri Palecek <jpalecek@web.de>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] kvm: Nested KVM MMUs need PAE root too
Date: Tue, 3 Sep 2019 13:33:46 -0700 [thread overview]
Message-ID: <20190903203345.GL10768@linux.intel.com> (raw)
In-Reply-To: <6aa83eaf-ca9c-74ea-1a62-98ccd0d516d7@web.de>
On Sat, Aug 31, 2019 at 02:45:43PM +0200, Jiri Palecek wrote:
> >>Signed-off-by: Jiri Palecek <jpalecek@web.de>
> >>Tested-by: Jiri Palecek <jpalecek@web.de>
> >This is weird. I always thought "Signed-off-by" implies some form of
> >testing (unless stated otherwise) :-)
> Well, I thought it was quite common that someone authors a patch but
> doesn't have means to test it. Anyway, after reading Kernel Newbies, I
> added that to indicate that I did test it and if there's need to test
> anything reasonably sized on this particualr configuration, I'm open for it.
Not being able to test a patch isn't uncommon in the absolute sense, but
it's certainly uncommon when viewed as a percentage of the total number of
patches sent to LKML. A SoB is generally taken to imply basic functional
testing unless otherwise stated, e.g. most folks add a note in the cover
letter or patch comment when something has only been compile tested or not
tested at all.
next prev parent reply other threads:[~2019-09-03 20:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-22 17:42 [PATCH] kvm: Nested KVM MMUs need PAE root too Jiří Paleček
2019-08-26 12:16 ` Vitaly Kuznetsov
2019-08-26 16:11 ` Sean Christopherson
2019-08-31 12:45 ` Jiri Palecek
2019-09-03 20:33 ` Sean Christopherson [this message]
2019-09-11 16:04 ` Paolo Bonzini
[not found] <87y2z7rmgw.fsf@debian>
2019-09-04 9:53 ` Vitaly Kuznetsov
2019-09-04 11:03 ` Jiri Palecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903203345.GL10768@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=jpalecek@web.de \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.