From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8116C3A5A2 for ; Tue, 3 Sep 2019 20:51:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 977FA2339E for ; Tue, 3 Sep 2019 20:51:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726925AbfICUva (ORCPT ); Tue, 3 Sep 2019 16:51:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48988 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbfICUva (ORCPT ); Tue, 3 Sep 2019 16:51:30 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 699CF8980EF; Tue, 3 Sep 2019 20:51:30 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AB0D960126; Tue, 3 Sep 2019 20:51:27 +0000 (UTC) Date: Tue, 3 Sep 2019 16:51:26 -0400 From: Mike Snitzer To: Ard Biesheuvel Cc: "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Herbert Xu , Eric Biggers , linux-fscrypt@vger.kernel.org, Gilad Ben-Yossef , device-mapper development , Milan Broz Subject: Re: [PATCH v13 5/6] md: dm-crypt: switch to ESSIV crypto API template Message-ID: <20190903205126.GA13753@redhat.com> References: <20190819141738.1231-1-ard.biesheuvel@linaro.org> <20190819141738.1231-6-ard.biesheuvel@linaro.org> <20190903185537.GC13472@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.67]); Tue, 03 Sep 2019 20:51:30 +0000 (UTC) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Sep 03 2019 at 3:16pm -0400, Ard Biesheuvel wrote: > On Tue, 3 Sep 2019 at 11:55, Mike Snitzer wrote: > > > > On Mon, Aug 19 2019 at 10:17am -0400, > > Ard Biesheuvel wrote: > > > > > Replace the explicit ESSIV handling in the dm-crypt driver with calls > > > into the crypto API, which now possesses the capability to perform > > > this processing within the crypto subsystem. > > > > > > Note that we reorder the AEAD cipher_api string parsing with the TFM > > > instantiation: this is needed because cipher_api is mangled by the > > > ESSIV handling, and throws off the parsing of "authenc(" otherwise. > > > > > > Signed-off-by: Ard Biesheuvel > > > > I really like to see this type of factoring out to the crypto API; > > nicely done. > > > > Acked-by: Mike Snitzer > > > > Herbert, please feel free to pull this, and the next 6/6 patch, into > > your crypto tree for 5.4. I see no need to complicate matters by me > > having to rebase my dm-5.4 branch ontop of the crypto tree, etc. > > > > Thanks Mike. > > There is no need to rebase your branch - there is only a single > dependency, which is the essiv template itself, and the patch that > adds that (#1 in this series) was acked by Herbert, specifically so > that it can be taken via another tree. The crypto tree has no > interdependencies with this template, and the other patches in this > series are not required for essiv in dm-crypt. Ah ok, thanks for clarifying. I just picked up patches 1, 5, and 6 and staged them in linux-next via dm-5.4, please see: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-5.4 Thanks, Mike From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:48988 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbfICUva (ORCPT ); Tue, 3 Sep 2019 16:51:30 -0400 Date: Tue, 3 Sep 2019 16:51:26 -0400 From: Mike Snitzer Subject: Re: [PATCH v13 5/6] md: dm-crypt: switch to ESSIV crypto API template Message-ID: <20190903205126.GA13753@redhat.com> References: <20190819141738.1231-1-ard.biesheuvel@linaro.org> <20190819141738.1231-6-ard.biesheuvel@linaro.org> <20190903185537.GC13472@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fscrypt-owner@vger.kernel.org To: Ard Biesheuvel Cc: "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Herbert Xu , Eric Biggers , linux-fscrypt@vger.kernel.org, Gilad Ben-Yossef , device-mapper development , Milan Broz List-ID: On Tue, Sep 03 2019 at 3:16pm -0400, Ard Biesheuvel wrote: > On Tue, 3 Sep 2019 at 11:55, Mike Snitzer wrote: > > > > On Mon, Aug 19 2019 at 10:17am -0400, > > Ard Biesheuvel wrote: > > > > > Replace the explicit ESSIV handling in the dm-crypt driver with calls > > > into the crypto API, which now possesses the capability to perform > > > this processing within the crypto subsystem. > > > > > > Note that we reorder the AEAD cipher_api string parsing with the TFM > > > instantiation: this is needed because cipher_api is mangled by the > > > ESSIV handling, and throws off the parsing of "authenc(" otherwise. > > > > > > Signed-off-by: Ard Biesheuvel > > > > I really like to see this type of factoring out to the crypto API; > > nicely done. > > > > Acked-by: Mike Snitzer > > > > Herbert, please feel free to pull this, and the next 6/6 patch, into > > your crypto tree for 5.4. I see no need to complicate matters by me > > having to rebase my dm-5.4 branch ontop of the crypto tree, etc. > > > > Thanks Mike. > > There is no need to rebase your branch - there is only a single > dependency, which is the essiv template itself, and the patch that > adds that (#1 in this series) was acked by Herbert, specifically so > that it can be taken via another tree. The crypto tree has no > interdependencies with this template, and the other patches in this > series are not required for essiv in dm-crypt. Ah ok, thanks for clarifying. I just picked up patches 1, 5, and 6 and staged them in linux-next via dm-5.4, please see: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-5.4 Thanks, Mike From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH v13 5/6] md: dm-crypt: switch to ESSIV crypto API template Date: Tue, 3 Sep 2019 16:51:26 -0400 Message-ID: <20190903205126.GA13753@redhat.com> References: <20190819141738.1231-1-ard.biesheuvel@linaro.org> <20190819141738.1231-6-ard.biesheuvel@linaro.org> <20190903185537.GC13472@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Ard Biesheuvel Cc: Herbert Xu , Eric Biggers , device-mapper development , Gilad Ben-Yossef , linux-fscrypt@vger.kernel.org, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Milan Broz List-Id: dm-devel.ids On Tue, Sep 03 2019 at 3:16pm -0400, Ard Biesheuvel wrote: > On Tue, 3 Sep 2019 at 11:55, Mike Snitzer wrote: > > > > On Mon, Aug 19 2019 at 10:17am -0400, > > Ard Biesheuvel wrote: > > > > > Replace the explicit ESSIV handling in the dm-crypt driver with calls > > > into the crypto API, which now possesses the capability to perform > > > this processing within the crypto subsystem. > > > > > > Note that we reorder the AEAD cipher_api string parsing with the TFM > > > instantiation: this is needed because cipher_api is mangled by the > > > ESSIV handling, and throws off the parsing of "authenc(" otherwise. > > > > > > Signed-off-by: Ard Biesheuvel > > > > I really like to see this type of factoring out to the crypto API; > > nicely done. > > > > Acked-by: Mike Snitzer > > > > Herbert, please feel free to pull this, and the next 6/6 patch, into > > your crypto tree for 5.4. I see no need to complicate matters by me > > having to rebase my dm-5.4 branch ontop of the crypto tree, etc. > > > > Thanks Mike. > > There is no need to rebase your branch - there is only a single > dependency, which is the essiv template itself, and the patch that > adds that (#1 in this series) was acked by Herbert, specifically so > that it can be taken via another tree. The crypto tree has no > interdependencies with this template, and the other patches in this > series are not required for essiv in dm-crypt. Ah ok, thanks for clarifying. I just picked up patches 1, 5, and 6 and staged them in linux-next via dm-5.4, please see: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-5.4 Thanks, Mike