From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3C49C3A59E for ; Wed, 4 Sep 2019 04:22:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A817922DBF for ; Wed, 4 Sep 2019 04:22:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WTaHHGrv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725966AbfIDEWI (ORCPT ); Wed, 4 Sep 2019 00:22:08 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:39568 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725877AbfIDEWH (ORCPT ); Wed, 4 Sep 2019 00:22:07 -0400 Received: by mail-pf1-f196.google.com with SMTP id s12so5382532pfe.6 for ; Tue, 03 Sep 2019 21:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mp9OFto0GZk4OjRyXFJjH2s7yGAsAoKG/MS1RCQlOQQ=; b=WTaHHGrvlniplupbKSJNlsKOyzptXQwVRIDf/qjEm017VJXU41Gqqe7UGNTMvw+xr1 X/Exx7zSW6qtWV0hqB/b1rm6eB8sFQZF3IEyfn4muy2wof4P7S9FI4Ih2W+phAM/mB6v MH0YehfS5rswTZLZ5xuvJWwKp3LhQyQci8S6k0ayZhWecsjSeTTGyImkQ8hKFty96iAv XqIF2NlBPKrvRq4n2tvwHudYolOwY3909VFrEpPhf4MO0gDSYIbyABo1OrcRUEisCNY+ Y04TNkzvmezmQ08TLjm54UkOF6PngEAWlWs/gFJAjfXrpUS/OKhkbgDaibCdA7illKDe 0s0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mp9OFto0GZk4OjRyXFJjH2s7yGAsAoKG/MS1RCQlOQQ=; b=pbGK2efUS625T7RsuqK67AKqsVGb/8s5BlVgLoOOGEmR6m3dHWu8EqTCdSzKVphRAa W2lq7zZZ5R8VAEiVdcn/q0R10Gfiz74h39eBmE0kwnWhIXEMkuFIB5UhFzzSYt47N/l9 ZSouUGkYfIWOYiu39V6Daya5Nsmv/tvliJqz1mfDFy/5GkwOQsEnKXPoM1il2sWTrdME 5WIx6MpGJGesktGqu2vv3taIvqpYRUAZJcBpK/jlqqG0P43v9BUBkY6nnnUxEBnCesEN dJHYQHEgwFbt0XSqTyjK7ehB27t+snbWT0lU8Vulkt8iWnppzSOnrBJGaAH/ZRHrgw2s Cl9A== X-Gm-Message-State: APjAAAUBpwSmMtpMGvyeP7dAGGMBIgwfaUjT9zO6lSg/+pg6VKENk7vV 0OPoVE/HIAUaB8jjUYcVc1fbvA== X-Google-Smtp-Source: APXvYqy5gQpkWB1S0s/wrl3Q+cVrKMEMuWNE1UjfGFaNKX5PQ/qnJ8QVZhQCfwLSEncF+vh+M6lJhA== X-Received: by 2002:aa7:8a98:: with SMTP id a24mr40799576pfc.101.1567570927082; Tue, 03 Sep 2019 21:22:07 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id j7sm10505053pfi.96.2019.09.03.21.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 21:22:06 -0700 (PDT) Date: Tue, 3 Sep 2019 21:22:03 -0700 From: Bjorn Andersson To: Georgi Djakov Cc: Stanimir Varbanov , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Vikash Garodia , Andy Gross , Aniket Masule , Linux PM list Subject: Re: [PATCH 1/2] venus: use on-chip interconnect API Message-ID: <20190904042203.GC3081@tuxbook-pro> References: <20190814084701.25455-1-stanimir.varbanov@linaro.org> <20190814084701.25455-2-stanimir.varbanov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue 20 Aug 02:34 PDT 2019, Georgi Djakov wrote: > Hi Stan, > > On 8/14/19 11:47, Stanimir Varbanov wrote: > > This aims to add a requests for bandwidth scaling depending > > on the resolution and framerate (macroblocks per second). The > > exact value ff the requested bandwidth is get from a > > s/ff/of/ > > > pre-calculated tables for encoder and decoder. > > > > Signed-off-by: Stanimir Varbanov > > --- > > drivers/media/platform/qcom/venus/core.c | 34 +++++++++++ > > drivers/media/platform/qcom/venus/core.h | 14 +++++ > > drivers/media/platform/qcom/venus/helpers.c | 67 ++++++++++++++++++++- > > 3 files changed, 114 insertions(+), 1 deletion(-) > > It looks like venus can be built-in, so how about the case when venus is > built-in and the interconnect provider is a module? Maybe add a dependency in > Kconfig to depend on INTERCONNECT || !INTERCONNECT? > I've been struggling down this road for remoteproc et al for a long time, I strongly suggest that you make the INTERCONNECT config bool, to ensure that we don't see this problem for every client. The interconnect framework should hide the fact that the provider is module. But with this in place is there actually a dependency? Won't the include file provide stubs in the case of !INTERCONNECT? Regards, Bjorn > > > > diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c > > index 0acc7576cc58..19cbe9d5d028 100644 > > --- a/drivers/media/platform/qcom/venus/core.c > > +++ b/drivers/media/platform/qcom/venus/core.c > > @@ -5,6 +5,7 @@ > > */ > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -239,6 +240,14 @@ static int venus_probe(struct platform_device *pdev) > > if (IS_ERR(core->base)) > > return PTR_ERR(core->base); > > > > + core->video_path = of_icc_get(dev, "video-mem"); > > + if (IS_ERR(core->video_path)) > > + return PTR_ERR(core->video_path); > > + > > + core->cpucfg_path = of_icc_get(dev, "cpu-cfg"); > > + if (IS_ERR(core->cpucfg_path)) > > + return PTR_ERR(core->cpucfg_path); > > + > > core->irq = platform_get_irq(pdev, 0); > > if (core->irq < 0) > > return core->irq; > > @@ -273,6 +282,10 @@ static int venus_probe(struct platform_device *pdev) > > if (ret) > > return ret; > > > > + ret = icc_set_bw(core->cpucfg_path, 0, kbps_to_icc(1000)); > > + if (ret) > > + return ret; > > + > > ret = hfi_create(core, &venus_core_ops); > > if (ret) > > return ret; > > @@ -355,6 +368,9 @@ static int venus_remove(struct platform_device *pdev) > > pm_runtime_put_sync(dev); > > pm_runtime_disable(dev); > > > > + icc_put(core->video_path); > > + icc_put(core->cpucfg_path); > > + > > Do you have any plans to scale the bandwidth on suspend/resume too? > > Thanks, > Georgi