From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A1AC3A5A7 for ; Wed, 4 Sep 2019 10:43:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3E4A2339D for ; Wed, 4 Sep 2019 10:43:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729268AbfIDKnf (ORCPT ); Wed, 4 Sep 2019 06:43:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:57592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbfIDKnf (ORCPT ); Wed, 4 Sep 2019 06:43:35 -0400 Received: from oasis.local.home (bl11-233-114.dsl.telepac.pt [85.244.233.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1E35422DBF; Wed, 4 Sep 2019 10:43:32 +0000 (UTC) Date: Wed, 4 Sep 2019 06:43:27 -0400 From: Steven Rostedt To: Tom Zanussi Cc: Zhengjun Xing , mingo@redhat.com, tom.zanussi@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] trace:Add "gfp_t" support in synthetic_events Message-ID: <20190904064327.28876d71@oasis.local.home> In-Reply-To: <1562947506.12920.0.camel@kernel.org> References: <20190712015308.9908-1-zhengjun.xing@linux.intel.com> <1562947506.12920.0.camel@kernel.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Jul 2019 11:05:06 -0500 Tom Zanussi wrote: > Hi Zhengjun, > > On Fri, 2019-07-12 at 09:53 +0800, Zhengjun Xing wrote: > > Add "gfp_t" support in synthetic_events, then the "gfp_t" type > > parameter in some functions can be traced. > > > > Prints the gfp flags as hex in addition to the human-readable flag > > string. Example output: > > > > whoopsie-630 [000] ...1 78.969452: testevent: bar=b20 > > (GFP_ATOMIC|__GFP_ZERO) > > rcuc/0-11 [000] ...1 81.097555: testevent: bar=a20 (GFP_ATOMIC) > > rcuc/0-11 [000] ...1 81.583123: testevent: bar=a20 (GFP_ATOMIC) > > > > Signed-off-by: Tom Zanussi Why is this Signed-off-by Tom? Tom, did you author part of this?? -- Steve > > Signed-off-by: Zhengjun Xing > > Looks good to me, thanks! > > Tom > > > --- > > kernel/trace/trace_events_hist.c | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/kernel/trace/trace_events_hist.c > > b/kernel/trace/trace_events_hist.c > > index ca6b0dff60c5..30f0f32aca62 100644 > > --- a/kernel/trace/trace_events_hist.c > > +++ b/kernel/trace/trace_events_hist.c > > @@ -13,6 +13,10 @@ > > #include > > #include > > > > +/* for gfp flag names */ > > +#include > > +#include > > + > > #include "tracing_map.h" > > #include "trace.h" > > #include "trace_dynevent.h" > > @@ -752,6 +756,8 @@ static int synth_field_size(char *type) > > size = sizeof(unsigned long); > > else if (strcmp(type, "pid_t") == 0) > > size = sizeof(pid_t); > > + else if (strcmp(type, "gfp_t") == 0) > > + size = sizeof(gfp_t); > > else if (synth_field_is_string(type)) > > size = synth_field_string_size(type); > > > > @@ -792,6 +798,8 @@ static const char *synth_field_fmt(char *type) > > fmt = "%lu"; > > else if (strcmp(type, "pid_t") == 0) > > fmt = "%d"; > > + else if (strcmp(type, "gfp_t") == 0) > > + fmt = "%x"; > > else if (synth_field_is_string(type)) > > fmt = "%s"; > > > > @@ -834,9 +842,20 @@ static enum print_line_t > > print_synth_event(struct trace_iterator *iter, > > i == se->n_fields - 1 ? "" > > : " "); > > n_u64 += STR_VAR_LEN_MAX / sizeof(u64); > > } else { > > + struct trace_print_flags __flags[] = { > > + __def_gfpflag_names, {-1, NULL} }; > > + > > trace_seq_printf(s, print_fmt, se- > > >fields[i]->name, > > entry->fields[n_u64], > > i == se->n_fields - 1 ? "" > > : " "); > > + > > + if (strcmp(se->fields[i]->type, "gfp_t") == > > 0) { > > + trace_seq_puts(s, " ("); > > + trace_print_flags_seq(s, "|", > > + entry- > > >fields[n_u64], > > + __flags); > > + trace_seq_putc(s, ')'); > > + } > > n_u64++; > > } > > }