From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mail.openembedded.org (Postfix) with ESMTP id 8378B6C13D for ; Wed, 4 Sep 2019 07:37:02 +0000 (UTC) Received: by mail-wr1-f46.google.com with SMTP id h7so18726985wrt.13 for ; Wed, 04 Sep 2019 00:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=28myQsA45Il1gR0LI0zHeztj1thPMoek3GOGgegI+Cw=; b=TepHQRYLkUJNeY/VVCYg5n8AEPZL7S6NotqvzJIy1lEG5gSyzzTQoMVzUbJj+WEjKv cbqb0UH7AclE2Oj8m7wzU59NtUgHzjb8bcgS39aNoM/DfyAI+fXm+lx/ifPW1SHE02BC 9Fz/m48gQq+uJ3btJRdWnhxDPOwYGe8OVN3TCSD6/Tdjb3i1KbXzBrislT1HVG5aFsCI ZZ6bm2pu5UkUqcUrH+k1+18PfOlYZhdSPzrda2BULZf+aYDUB0O3ZzV+32aAZocaOo9L UJNkuPjR3djZy9EeQ4p913l9Zl/cYvC9bR+9dz9MANDJhXSEDCJPs90j0ZZPRnPGczFe zOFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=28myQsA45Il1gR0LI0zHeztj1thPMoek3GOGgegI+Cw=; b=nqzWAz80TbT+9gekcXh6sAl/6R90WKyttHZTa0+VYYu1L1y1S9JEfNu2M3AXnCVp++ nrwxZiyoEjWGVHStJR8bT9kqrrgJ5OeMoY8C5VvUt6i5+Wn8N5rjuSxI4xSvCjthJYTV k8uy/ByM8qyi0Fduy81OEr/7SZKnzP5nbpKoHe7JFxh7OXX2QIWPE3ptlzDALd0SC1zo DHohReHZ3Jpqy1ouyc1dGKruWgkr0hXH86yTJ9BDe1ofPQZEOAM39fq4avTHUpp0Kvla eJwThFyuGNJMSUJMYd4nHlapRwo2hm5sr9rZEs+yg66nrCW+zVnhkAF+ZDP4RtcqHtA+ plcA== X-Gm-Message-State: APjAAAVrkCXuimUIrG9EOLZ1oBhlY2++28hlSdU0bibvU755xqnaf04M w+AtiYRz/cFWbKZJobd8rMmG2YsET2Y= X-Google-Smtp-Source: APXvYqx0PdKJ0wj94Niak09uF7OdWTXgVs9/g2BrRzZDLyMZNEkasFqv3Vvz2AQNH6/7Jhm8LrI7fA== X-Received: by 2002:adf:f846:: with SMTP id d6mr28038392wrq.67.1567582622911; Wed, 04 Sep 2019 00:37:02 -0700 (PDT) Received: from localhost (ip-217-030-068-212.aim-net.cz. [217.30.68.212]) by smtp.gmail.com with ESMTPSA id s3sm1548035wmj.48.2019.09.04.00.37.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Sep 2019 00:37:02 -0700 (PDT) From: Martin Jansa X-Google-Original-From: Martin Jansa To: bitbake-devel@lists.openembedded.org Date: Wed, 4 Sep 2019 07:37:00 +0000 Message-Id: <20190904073700.2566796-2-Martin.Jansa@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190904073700.2566796-1-Martin.Jansa@gmail.com> References: <20190904073700.2566796-1-Martin.Jansa@gmail.com> Subject: [1.40][PATCH 2/2] fetch2: show warning when renaming the archive with bad checksum failed X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussion that advance bitbake development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2019 07:37:02 -0000 From: Martin Jansa * noticed on read-only sshfs premirror * it was showing the warning about renaming the file: WARNING: laser-geometry-1.6.4-r0 do_fetch: Renaming /jenkins/mjansa/sshfs/webos-ose-thud/downloads/laser_geometry-1.6.4.tar.gz to /jenkins/mjansa/sshfs/webos-ose-thud/downloads/laser_geometry-1.6.4.tar.gz_bad-checksum_1ee7479b8c5914b4ffae996945121441 and then failed because of movefile() issue with python3 (fixed in previous commit): ERROR: laser-geometry-1.6.4-r0 do_fetch: Error executing a python function in exec_python_func() autogenerated: with movefile() fixed, it let do_fetch continue and re-fetch locally with the right checksum, but still the renamed file didn't exist, because of movefile failure - add another warning when the movefile fails - for whatever reason - unfortunately movefile prints error messages with just print() so the real error is hidden only in log.do_fetch in this case: movefile: Failed to move /jenkins/mjansa/sshfs/webos-ose-thud/downloads/laser_geometry-1.6.4.tar.gz to /jenkins/mjansa/sshfs/webos-ose-thud/downloads/laser_geometry-1.6.4.tar.gz_bad-checksum_1ee7479b8c5914b4ffae996945121441 [Errno 30] Read-only file system: '/jenkins/mjansa/sshfs/webos-ose-thud/downloads/laser_geometry-1.6.4.tar.gz' -> '/jenkins/mjansa/sshfs/webos-ose-thud/downloads/laser_geometry-1.6.4.tar.gz_bad-checksum_1ee7479b8c5914b4ffae996945121441' Signed-off-by: Martin Jansa Signed-off-by: Richard Purdie --- lib/bb/fetch2/__init__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py index 709372e1..708b83db 100644 --- a/lib/bb/fetch2/__init__.py +++ b/lib/bb/fetch2/__init__.py @@ -966,7 +966,8 @@ def rename_bad_checksum(ud, suffix): new_localpath = "%s_bad-checksum_%s" % (ud.localpath, suffix) bb.warn("Renaming %s to %s" % (ud.localpath, new_localpath)) - bb.utils.movefile(ud.localpath, new_localpath) + if not bb.utils.movefile(ud.localpath, new_localpath): + bb.warn("Renaming %s to %s failed, grep movefile in log.do_fetch to see why" % (ud.localpath, new_localpath)) def try_mirror_url(fetch, origud, ud, ld, check = False): -- 2.17.1