All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] tools lib trace-cmd: Fix typo with file descriptors conditions.
       [not found] <E9875C329132824C9E8D827BD6069E125C64F045@irsmsx110.ger.corp.intel.com>
@ 2019-09-04 11:50 ` Steven Rostedt
  0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2019-09-04 11:50 UTC (permalink / raw)
  To: Uhanov, Kirill; +Cc: 'linux-trace-devel@vger.kernel.org'

On Wed, 4 Sep 2019 10:48:37 +0000
"Uhanov, Kirill" <kirill.uhanov@intel.com> wrote:

Hmm, Patchwork doesn't want to pick this up. Probably because of the
strange mime format that your mail client is using. I'll send this
patch for you (using a From line for you). But if you want to
contribute to Linux related projects, it may be a good idea to work
with other intel developers to fix your mail client such that patches
work as inlined.

Thanks!

-- Steve


> tools lib trace-cmd: Fix typo with file descriptor conditions
> 
> Signed-off-by: Kirill Uhanov <kirill.uhanov@intel.com>
> 
> 
> 
> diff --git a/lib/trace-cmd/trace-recorder.c b/lib/trace-cmd/trace-recorder.c
> 
> index 0bd0657..650b259 100644
> 
> --- a/lib/trace-cmd/trace-recorder.c
> 
> +++ b/lib/trace-cmd/trace-recorder.c
> 
> @@ -244,7 +244,7 @@ tracecmd_create_buffer_recorder_maxkb(const char *file, int cpu, unsigned flags,
> 
>                              goto out;
> 
>                fd2 = open(file2, O_RDWR | O_CREAT | O_TRUNC | O_LARGEFILE, 0644);
> 
> -              if (fd < 0)
> 
> +             if (fd2 < 0)
> 
>                              goto err;
> 
>                recorder = tracecmd_create_buffer_recorder_fd2(fd, fd2, cpu, flags, buffer, maxkb);
> 
> 
> 
> --------------------------------------------------------------------
> Joint Stock Company Intel A/O
> Registered legal address: Krylatsky Hills Business Park,
> 17 Krylatskaya Str., Bldg 4, Moscow 121614,
> Russian Federation
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-09-04 11:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <E9875C329132824C9E8D827BD6069E125C64F045@irsmsx110.ger.corp.intel.com>
2019-09-04 11:50 ` [PATCH] tools lib trace-cmd: Fix typo with file descriptors conditions Steven Rostedt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.