All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
	"Joel Fernandes (Google)" <joel@joelfernandes.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Jonathan Derrick <jonathan.derrick@intel.com>,
	Keith Busch <keith.busch@intel.com>,
	linux-pci@vger.kernel.org,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH 1/2] pci: Convert to use built-in RCU list checking
Date: Wed, 4 Sep 2019 12:06:43 +0800	[thread overview]
Message-ID: <201909041108.RSjNvfDL%lkp@intel.com> (raw)
In-Reply-To: <20190830231817.76862-1-joel@joelfernandes.org>

[-- Attachment #1: Type: text/plain, Size: 2339 bytes --]

Hi "Joel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc7 next-20190903]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Joel-Fernandes-Google/pci-Convert-to-use-built-in-RCU-list-checking/20190901-211013
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   drivers/pci/controller/vmd.c: In function 'vmd_irq':
>> drivers/pci/controller/vmd.c:722:37: error: macro "list_for_each_entry_rcu" passed 4 arguments, but takes just 3
        srcu_read_lock_held(&irqs->srcu))
                                        ^
>> drivers/pci/controller/vmd.c:721:2: error: unknown type name 'list_for_each_entry_rcu'
     list_for_each_entry_rcu(vmdirq, &irqs->irq_list, node,
     ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/pci/controller/vmd.c:723:28: error: expected ')' before '->' token
      generic_handle_irq(vmdirq->virq);
                               ^~
>> drivers/pci/controller/vmd.c:721:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     list_for_each_entry_rcu(vmdirq, &irqs->irq_list, node,
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/pci/controller/vmd.c:717:18: warning: unused variable 'vmdirq' [-Wunused-variable]
     struct vmd_irq *vmdirq;
                     ^~~~~~

vim +/list_for_each_entry_rcu +722 drivers/pci/controller/vmd.c

   713	
   714	static irqreturn_t vmd_irq(int irq, void *data)
   715	{
   716		struct vmd_irq_list *irqs = data;
   717		struct vmd_irq *vmdirq;
   718		int idx;
   719	
   720		idx = srcu_read_lock(&irqs->srcu);
 > 721		list_for_each_entry_rcu(vmdirq, &irqs->irq_list, node,
 > 722					srcu_read_lock_held(&irqs->srcu))
 > 723			generic_handle_irq(vmdirq->virq);
   724		srcu_read_unlock(&irqs->srcu, idx);
   725	
   726		return IRQ_HANDLED;
   727	}
   728	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 48019 bytes --]

  parent reply	other threads:[~2019-09-04  4:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30 23:18 [PATCH 1/2] pci: Convert to use built-in RCU list checking Joel Fernandes (Google)
2019-08-30 23:18 ` [PATCH 2/2] ipc/sem: " Joel Fernandes (Google)
2019-09-04  5:09   ` kbuild test robot
2019-09-04  4:06 ` kbuild test robot [this message]
2019-09-04  5:04   ` [PATCH 1/2] pci: " Joel Fernandes
2019-09-04 17:13     ` Andy Shevchenko
2019-09-04 18:01       ` Joel Fernandes
2019-09-04 19:36         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201909041108.RSjNvfDL%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=gustavo@embeddedor.com \
    --cc=joel@joelfernandes.org \
    --cc=jonathan.derrick@intel.com \
    --cc=kbuild-all@01.org \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.