From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Wed, 04 Sep 2019 11:50:57 +0000 Subject: Re: [PATCH] drm: panel-lvds: Potential Oops in probe error handling Message-Id: <20190904115057.GC4811@pendragon.ideasonboard.com> List-Id: References: <20190904100329.GE7007@mwanda> In-Reply-To: <20190904100329.GE7007@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Laurent Pinchart , David Airlie , Mark Brown , kernel-janitors@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Thierry Reding , Sam Ravnborg Hi Dan, Thank you for the patch. On Wed, Sep 04, 2019 at 01:03:29PM +0300, Dan Carpenter wrote: > The "lvds->backlight" pointer could be NULl if of_parse_phandle() > returns NULL. > > Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/panel/panel-lvds.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c > index ad47cc95459e..3b4eb959e994 100644 > --- a/drivers/gpu/drm/panel/panel-lvds.c > +++ b/drivers/gpu/drm/panel/panel-lvds.c > @@ -272,7 +272,8 @@ static int panel_lvds_probe(struct platform_device *pdev) > return 0; > > error: > - put_device(&lvds->backlight->dev); > + if (lvds->backlight) > + put_device(&lvds->backlight->dev); How about simply - put_device(&lvds->backlight->dev); + backlight_put(lvds->backlight); ? > return ret; > } > -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm: panel-lvds: Potential Oops in probe error handling Date: Wed, 4 Sep 2019 14:50:57 +0300 Message-ID: <20190904115057.GC4811@pendragon.ideasonboard.com> References: <20190904100329.GE7007@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2648A898C4 for ; Wed, 4 Sep 2019 11:51:06 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190904100329.GE7007@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter Cc: Laurent Pinchart , David Airlie , Mark Brown , kernel-janitors@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Thierry Reding , Sam Ravnborg List-Id: dri-devel@lists.freedesktop.org SGkgRGFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBXZWQsIFNlcCAwNCwgMjAxOSBh dCAwMTowMzoyOVBNICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOgo+IFRoZSAibHZkcy0+YmFj a2xpZ2h0IiBwb2ludGVyIGNvdWxkIGJlIE5VTGwgaWYgb2ZfcGFyc2VfcGhhbmRsZSgpCj4gcmV0 dXJucyBOVUxMLgo+IAo+IEZpeGVzOiA3YzlkZmY1YmQ2NDMgKCJkcm06IHBhbmVsczogQWRkIExW RFMgcGFuZWwgZHJpdmVyIikKPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2Fy cGVudGVyQG9yYWNsZS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1s dmRzLmMgfCAzICsrLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1sdmRz LmMgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtbHZkcy5jCj4gaW5kZXggYWQ0N2NjOTU0 NTllLi4zYjRlYjk1OWU5OTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3Bh bmVsLWx2ZHMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1sdmRzLmMKPiBA QCAtMjcyLDcgKzI3Miw4IEBAIHN0YXRpYyBpbnQgcGFuZWxfbHZkc19wcm9iZShzdHJ1Y3QgcGxh dGZvcm1fZGV2aWNlICpwZGV2KQo+ICAJcmV0dXJuIDA7Cj4gIAo+ICBlcnJvcjoKPiAtCXB1dF9k ZXZpY2UoJmx2ZHMtPmJhY2tsaWdodC0+ZGV2KTsKPiArCWlmIChsdmRzLT5iYWNrbGlnaHQpCj4g KwkJcHV0X2RldmljZSgmbHZkcy0+YmFja2xpZ2h0LT5kZXYpOwoKSG93IGFib3V0IHNpbXBseQoK LQlwdXRfZGV2aWNlKCZsdmRzLT5iYWNrbGlnaHQtPmRldik7CisJYmFja2xpZ2h0X3B1dChsdmRz LT5iYWNrbGlnaHQpOwoKPwoKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAgCgotLSAKUmVnYXJkcywK CkxhdXJlbnQgUGluY2hhcnQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVs