From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0981C3A5A7 for ; Wed, 4 Sep 2019 11:53:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B695122DBF for ; Wed, 4 Sep 2019 11:53:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567598025; bh=6yE3IUv7qBSVFJ6+Mf00UxE1PnKsLJ0VJifYwWdQq1Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zfGTQyXyCNdsdF3u7H6aL9EJw+To+QmD00UQOMofpMVKC5UtiwIE5XqNNYKxXs/8F 0K/QB0Jop5rh0IZeR+2ACD6rmxxuWGjFF4qZkTEOu3/xyefq9kfS+Nde/+nJyDoOmw a/ehxkQKdIAlKUFJSLVEu/cg4r2/HrTNhk7iUxAQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726240AbfIDLxp (ORCPT ); Wed, 4 Sep 2019 07:53:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:35260 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbfIDLxp (ORCPT ); Wed, 4 Sep 2019 07:53:45 -0400 Received: from localhost (unknown [122.182.201.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2C20722CF5; Wed, 4 Sep 2019 11:53:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567598024; bh=6yE3IUv7qBSVFJ6+Mf00UxE1PnKsLJ0VJifYwWdQq1Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bINwaOQTuFOWx7V12YuIGe2FCJ+xjHqhhW3BE3LSzwuFSEyTJsQ1SW8/5NIU8zUQy DpAM0NqtkKvoWpvFGBSP9qhjJlOM834TBGmJpNbdMCItmQx0hKRfmQN5iU9krCQYkh rSM7PF0SdS00ITRfSqCIRGCPqVzc+Dc7JDvuXR9I= Date: Wed, 4 Sep 2019 17:22:34 +0530 From: Vinod Koul To: Lee Jones Cc: agross@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, bjorn.andersson@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: Add Lenovo Yoga C630 Message-ID: <20190904115234.GV2672@vkoul-mobl> References: <20190904113917.15223-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190904113917.15223-1-lee.jones@linaro.org> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 04-09-19, 12:39, Lee Jones wrote: > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -12,5 +12,6 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r2.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-mtp.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb Can we keep this sorted, so before mtp. > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > new file mode 100644 > index 000000000000..ad160c718b33 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > @@ -0,0 +1,454 @@ > +// SPDX-License-Identifier: GPL-2.0 Are we going to make this dual? or BSD.. > +&apps_rsc { > + pm8998-rpmh-regulators { > + compatible = "qcom,pm8998-rpmh-regulators"; > + qcom,pmic-id = "a"; > + > + vdd-l2-l8-l17-supply = <&vreg_s3a_1p35>; > + vdd-l7-l12-l14-l15-supply = <&vreg_s5a_2p04>; > + > + vreg_s2a_1p125: smps2 { > + }; > + > + vreg_s3a_1p35: smps3 { > + regulator-min-microvolt = <1352000>; > + regulator-max-microvolt = <1352000>; > + regulator-initial-mode = ; > + }; > + > + vreg_s4a_1p8: smps4 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-initial-mode = ; > + }; > + > + vreg_s5a_2p04: smps5 { > + regulator-min-microvolt = <2040000>; > + regulator-max-microvolt = <2040000>; > + regulator-initial-mode = ; > + }; > + > + vreg_s7a_1p025: smps7 { Any reason why we dont specify the mode and min/max voltage for this and few others below..? > +&i2c1 { > + status = "okay"; > + clock-frequency = <400000>; > + qcom,geni-se-fifo; > + > + battery@70 { > + compatible = "some,battery"; some,battery ..? > +&qup_i2c12_default { Please move the qup nodes up so that nodes are sorted alphabetically -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0909AC3A5A7 for ; Wed, 4 Sep 2019 11:53:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD5C822CF5 for ; Wed, 4 Sep 2019 11:53:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o70iIBbZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bINwaOQT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD5C822CF5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6ogjDh7iccl9hvJHyETx3wOlgorMhltdL/1Wwu/tmkE=; b=o70iIBbZqI8jwg LAj1aB2HocPgecenT9NfE2GvIhUAdFmDThjS8eVg1aQDeBgsBFEnoyRuwTbfr5lXeyBigSSwGiKo+ N02bQpRHhqZKgqtuLsHJakQPtJPNbMIwYeP1HTbAD5umemNc5XqFwVyRAc0kyHGvG6crz6Fq61nnd tF1Z++LC62c5FTCJ6v2PWzeNNvHYpBtD1DroEhaR/vFYFj96xmDRG/HskJrSPGDE4JsCI2vfjeiCp YUJ91ldNFIKsZzocGPw4v1fllz23mhXaJeyn02HrhCU6q1kf2tXxFTLYLwxxHourqrz6fkv7U1YDq ZlN7qUjROOWSdzZbdsYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5Tr9-0008TP-GI; Wed, 04 Sep 2019 11:53:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i5Tr6-0008T1-Ne for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2019 11:53:45 +0000 Received: from localhost (unknown [122.182.201.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2C20722CF5; Wed, 4 Sep 2019 11:53:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567598024; bh=6yE3IUv7qBSVFJ6+Mf00UxE1PnKsLJ0VJifYwWdQq1Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bINwaOQTuFOWx7V12YuIGe2FCJ+xjHqhhW3BE3LSzwuFSEyTJsQ1SW8/5NIU8zUQy DpAM0NqtkKvoWpvFGBSP9qhjJlOM834TBGmJpNbdMCItmQx0hKRfmQN5iU9krCQYkh rSM7PF0SdS00ITRfSqCIRGCPqVzc+Dc7JDvuXR9I= Date: Wed, 4 Sep 2019 17:22:34 +0530 From: Vinod Koul To: Lee Jones Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: Add Lenovo Yoga C630 Message-ID: <20190904115234.GV2672@vkoul-mobl> References: <20190904113917.15223-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190904113917.15223-1-lee.jones@linaro.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190904_045344_793673_4E3A99CB X-CRM114-Status: GOOD ( 12.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04-09-19, 12:39, Lee Jones wrote: > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -12,5 +12,6 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r2.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-mtp.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb Can we keep this sorted, so before mtp. > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > new file mode 100644 > index 000000000000..ad160c718b33 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > @@ -0,0 +1,454 @@ > +// SPDX-License-Identifier: GPL-2.0 Are we going to make this dual? or BSD.. > +&apps_rsc { > + pm8998-rpmh-regulators { > + compatible = "qcom,pm8998-rpmh-regulators"; > + qcom,pmic-id = "a"; > + > + vdd-l2-l8-l17-supply = <&vreg_s3a_1p35>; > + vdd-l7-l12-l14-l15-supply = <&vreg_s5a_2p04>; > + > + vreg_s2a_1p125: smps2 { > + }; > + > + vreg_s3a_1p35: smps3 { > + regulator-min-microvolt = <1352000>; > + regulator-max-microvolt = <1352000>; > + regulator-initial-mode = ; > + }; > + > + vreg_s4a_1p8: smps4 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-initial-mode = ; > + }; > + > + vreg_s5a_2p04: smps5 { > + regulator-min-microvolt = <2040000>; > + regulator-max-microvolt = <2040000>; > + regulator-initial-mode = ; > + }; > + > + vreg_s7a_1p025: smps7 { Any reason why we dont specify the mode and min/max voltage for this and few others below..? > +&i2c1 { > + status = "okay"; > + clock-frequency = <400000>; > + qcom,geni-se-fifo; > + > + battery@70 { > + compatible = "some,battery"; some,battery ..? > +&qup_i2c12_default { Please move the qup nodes up so that nodes are sorted alphabetically -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel