From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Cc: Evgeniy Polyakov <zbr@ioremap.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] w1: add 1-wire master driver for IP block found in SGI ASICs
Date: Wed, 4 Sep 2019 14:06:46 +0200 [thread overview]
Message-ID: <20190904120646.GA11400@kroah.com> (raw)
In-Reply-To: <20190904140134.698aaf5f5ec204a5305c1177@suse.de>
On Wed, Sep 04, 2019 at 02:01:34PM +0200, Thomas Bogendoerfer wrote:
> On Wed, 4 Sep 2019 13:48:37 +0200
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> > On Sat, Aug 31, 2019 at 10:26:21AM +0200, Thomas Bogendoerfer wrote:
> > > Starting with SGI Origin machines nearly every new SGI ASIC contains
> > > an 1-Wire master. They are used for attaching One-Wire prom devices,
> > > which contain information about part numbers, revision numbers,
> > > serial number etc. and MAC addresses for ethernet interfaces.
> > > This patch adds a master driver to support this IP block.
> > > It also adds an extra field dev_id to struct w1_bus_master, which
> > > could be in used in slave drivers for creating unique device names.
> > >
> > > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> > > ---
> > > drivers/w1/masters/Kconfig | 9 +++
> > > drivers/w1/masters/Makefile | 1 +
> > > drivers/w1/masters/sgi_w1.c | 130 +++++++++++++++++++++++++++++++++++
> > > include/linux/platform_data/sgi-w1.h | 13 ++++
> >
> > Why platform data? I thought that was the "old way", and the "proper
> > way" now is to use device tree?
>
> this machine is old and doesn't have device tree at all.
Your text says "every new SGI ASIC". So new devices are being made for
old systems?
confused,
greg k-h
next prev parent reply other threads:[~2019-09-04 12:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 8:26 [PATCH v3 0/2] W1 drivers for devices used in SGI systems Thomas Bogendoerfer
2019-08-31 8:26 ` [PATCH v3 1/2] w1: add 1-wire master driver for IP block found in SGI ASICs Thomas Bogendoerfer
2019-09-04 11:48 ` Greg Kroah-Hartman
2019-09-04 12:01 ` Thomas Bogendoerfer
2019-09-04 12:06 ` Greg Kroah-Hartman [this message]
2019-09-04 12:14 ` Thomas Bogendoerfer
2019-09-04 12:33 ` Greg Kroah-Hartman
2019-09-04 12:47 ` Thomas Bogendoerfer
2019-08-31 8:26 ` [PATCH v3 2/2] w1: add DS2501, DS2502, DS2505 EPROM device driver Thomas Bogendoerfer
2019-09-01 12:49 ` [PATCH v3 0/2] W1 drivers for devices used in SGI systems Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904120646.GA11400@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tbogendoerfer@suse.de \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.