From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39E8CC3A5A7 for ; Wed, 4 Sep 2019 12:09:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C21722CED for ; Wed, 4 Sep 2019 12:09:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="J7ZfwMvx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729798AbfIDMJA (ORCPT ); Wed, 4 Sep 2019 08:09:00 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:35697 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726943AbfIDMJA (ORCPT ); Wed, 4 Sep 2019 08:09:00 -0400 Received: by mail-wr1-f65.google.com with SMTP id g7so21026308wrx.2 for ; Wed, 04 Sep 2019 05:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=cXNd5NFyo+yXcDkUhbL4DCnkYm1i1knViowjla1FTwE=; b=J7ZfwMvx+pjJ1KtIMg2FP2iKHNJugtUCVhDT0Q9A9FjR6NMHgbC3mf/LmljjuOidey UGqdxc1zMZTpTvw6hwHC1aHs7rOmo6aaccw1sRY2uRZlabi29r5B6lNG+s3zzZaSMH1C Z4tIH6+/totYd97oYlUmHDWy1h6khLfBmvhCz9+UhOpEsL4SaAa/cdlQqBtVm5+jEaqA pmtDQIzmxpohUiucVvUBP3ioD3mO7zvmxsdxwuhe2oZBFcdQjCUZoBHbidQ1ORP4VLq4 wOtK4aZ8XgNv6wyaIbNj/9icjZy0TFMaGC6OnEW61BxKyj7/2fRktWn8svHDF0t6B7Db tOlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=cXNd5NFyo+yXcDkUhbL4DCnkYm1i1knViowjla1FTwE=; b=Kj0CuGNeweXZTH1yncduAIVJnym9dW07KrycMnA88gqV84BpEiPyRCjWeUswsKHbr7 ytd+fnFRePzbqaLN8o4Ho5Ww45KQmGQduQV7nLLDMIlc+nMuzW5e/fzrHfySd4UQcba+ SnFRxICLcrvwWCXGz3VzekH3DliD7WIN5H6mfZz3BPLq/rhZWLBTmLWHnWNcCDm34uM/ jhyQUrpQw+DyVB1do6QRis47C8vsmvVUMDl3phDEMi6YfKg6iguACqDb6yqbE8MdkK1v JtEISUrtdnesnhDFb3mupQaqZDL68TASHD/jq6D5ygPeC44/SHftfyIaj9DBpf47OLG/ G7Xw== X-Gm-Message-State: APjAAAVj+vmjX0VMPUgnjG7sqpmjv1dmtFd6TQKvx4GTYKM61PoOhx46 rr3p1OiVR3k35l1M5GJmf+9spg== X-Google-Smtp-Source: APXvYqzoDt1j5nXwZfg6kdlNZiEWEaIC+6f7Yyq3ssLHAa5vCsy93S4qA0vTD5oeY0IsGHeo93JgRQ== X-Received: by 2002:a5d:4d81:: with SMTP id b1mr50990154wru.27.1567598937914; Wed, 04 Sep 2019 05:08:57 -0700 (PDT) Received: from dell ([95.147.198.36]) by smtp.gmail.com with ESMTPSA id j22sm3005688wre.45.2019.09.04.05.08.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Sep 2019 05:08:57 -0700 (PDT) Date: Wed, 4 Sep 2019 13:08:55 +0100 From: Lee Jones To: Vinod Koul Cc: agross@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, bjorn.andersson@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: Add Lenovo Yoga C630 Message-ID: <20190904120855.GJ26880@dell> References: <20190904113917.15223-1-lee.jones@linaro.org> <20190904115234.GV2672@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190904115234.GV2672@vkoul-mobl> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, 04 Sep 2019, Vinod Koul wrote: > On 04-09-19, 12:39, Lee Jones wrote: > > --- a/arch/arm64/boot/dts/qcom/Makefile > > +++ b/arch/arm64/boot/dts/qcom/Makefile > > @@ -12,5 +12,6 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r2.dtb > > dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb > > dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb > > dtb-$(CONFIG_ARCH_QCOM) += sdm845-mtp.dtb > > +dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb > > Can we keep this sorted, so before mtp. Look closer. :) > > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > > new file mode 100644 > > index 000000000000..ad160c718b33 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > > @@ -0,0 +1,454 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > Are we going to make this dual? or BSD.. This patches the DTS files already in this directory. > > +&apps_rsc { > > + pm8998-rpmh-regulators { > > + compatible = "qcom,pm8998-rpmh-regulators"; > > + qcom,pmic-id = "a"; > > + > > + vdd-l2-l8-l17-supply = <&vreg_s3a_1p35>; > > + vdd-l7-l12-l14-l15-supply = <&vreg_s5a_2p04>; > > + > > + vreg_s2a_1p125: smps2 { > > + }; > > + > > + vreg_s3a_1p35: smps3 { > > + regulator-min-microvolt = <1352000>; > > + regulator-max-microvolt = <1352000>; > > + regulator-initial-mode = ; > > + }; > > + > > + vreg_s4a_1p8: smps4 { > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-initial-mode = ; > > + }; > > + > > + vreg_s5a_2p04: smps5 { > > + regulator-min-microvolt = <2040000>; > > + regulator-max-microvolt = <2040000>; > > + regulator-initial-mode = ; > > + }; > > + > > + vreg_s7a_1p025: smps7 { > > Any reason why we dont specify the mode and min/max voltage for this > and few others below..? Might have to ask Bjorn that one. > > +&i2c1 { > > + status = "okay"; > > + clock-frequency = <400000>; > > + qcom,geni-se-fifo; > > + > > + battery@70 { > > + compatible = "some,battery"; > > some,battery ..? Good spot. This the battery level/AC detection driver that isn't upstream yet. Will remove. > > +&qup_i2c12_default { > > Please move the qup nodes up so that nodes are sorted alphabetically Sure. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: Add Lenovo Yoga C630 Date: Wed, 4 Sep 2019 13:08:55 +0100 Message-ID: <20190904120855.GJ26880@dell> References: <20190904113917.15223-1-lee.jones@linaro.org> <20190904115234.GV2672@vkoul-mobl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190904115234.GV2672@vkoul-mobl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Vinod Koul Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gV2VkLCAwNCBTZXAgMjAxOSwgVmlub2QgS291bCB3cm90ZToKCj4gT24gMDQtMDktMTksIDEy OjM5LCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3Fjb20v TWFrZWZpbGUKPiA+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcWNvbS9NYWtlZmlsZQo+ID4g QEAgLTEyLDUgKzEyLDYgQEAgZHRiLSQoQ09ORklHX0FSQ0hfUUNPTSkJKz0gc2RtODQ1LWNoZXph LXIyLmR0Ygo+ID4gIGR0Yi0kKENPTkZJR19BUkNIX1FDT00pCSs9IHNkbTg0NS1jaGV6YS1yMy5k dGIKPiA+ICBkdGItJChDT05GSUdfQVJDSF9RQ09NKQkrPSBzZG04NDUtZGI4NDVjLmR0Ygo+ID4g IGR0Yi0kKENPTkZJR19BUkNIX1FDT00pCSs9IHNkbTg0NS1tdHAuZHRiCj4gPiArZHRiLSQoQ09O RklHX0FSQ0hfUUNPTSkJKz0gc2RtODUwLWxlbm92by15b2dhLWM2MzAuZHRiCj4gCj4gQ2FuIHdl IGtlZXAgdGhpcyBzb3J0ZWQsIHNvIGJlZm9yZSBtdHAuCgpMb29rIGNsb3Nlci4gOikKCj4gPiAg ZHRiLSQoQ09ORklHX0FSQ0hfUUNPTSkJKz0gcWNzNDA0LWV2Yi0xMDAwLmR0Ygo+ID4gIGR0Yi0k KENPTkZJR19BUkNIX1FDT00pCSs9IHFjczQwNC1ldmItNDAwMC5kdGIKPiA+IGRpZmYgLS1naXQg YS9hcmNoL2FybTY0L2Jvb3QvZHRzL3Fjb20vc2RtODUwLWxlbm92by15b2dhLWM2MzAuZHRzIGIv YXJjaC9hcm02NC9ib290L2R0cy9xY29tL3NkbTg1MC1sZW5vdm8teW9nYS1jNjMwLmR0cwo+ID4g bmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+IGluZGV4IDAwMDAwMDAwMDAwMC4uYWQxNjBjNzE4YjMz Cj4gPiAtLS0gL2Rldi9udWxsCj4gPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3Fjb20vc2Rt ODUwLWxlbm92by15b2dhLWM2MzAuZHRzCj4gPiBAQCAtMCwwICsxLDQ1NCBAQAo+ID4gKy8vIFNQ RFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wCj4gCj4gQXJlIHdlIGdvaW5nIHRvIG1ha2Ug dGhpcyBkdWFsPyBvciBCU0QuLgoKVGhpcyBwYXRjaGVzIHRoZSBEVFMgZmlsZXMgYWxyZWFkeSBp biB0aGlzIGRpcmVjdG9yeS4KCj4gPiArJmFwcHNfcnNjIHsKPiA+ICsJcG04OTk4LXJwbWgtcmVn dWxhdG9ycyB7Cj4gPiArCQljb21wYXRpYmxlID0gInFjb20scG04OTk4LXJwbWgtcmVndWxhdG9y cyI7Cj4gPiArCQlxY29tLHBtaWMtaWQgPSAiYSI7Cj4gPiArCj4gPiArCQl2ZGQtbDItbDgtbDE3 LXN1cHBseSA9IDwmdnJlZ19zM2FfMXAzNT47Cj4gPiArCQl2ZGQtbDctbDEyLWwxNC1sMTUtc3Vw cGx5ID0gPCZ2cmVnX3M1YV8ycDA0PjsKPiA+ICsKPiA+ICsJCXZyZWdfczJhXzFwMTI1OiBzbXBz MiB7Cj4gPiArCQl9Owo+ID4gKwo+ID4gKwkJdnJlZ19zM2FfMXAzNTogc21wczMgewo+ID4gKwkJ CXJlZ3VsYXRvci1taW4tbWljcm92b2x0ID0gPDEzNTIwMDA+Owo+ID4gKwkJCXJlZ3VsYXRvci1t YXgtbWljcm92b2x0ID0gPDEzNTIwMDA+Owo+ID4gKwkJCXJlZ3VsYXRvci1pbml0aWFsLW1vZGUg PSA8UlBNSF9SRUdVTEFUT1JfTU9ERV9IUE0+Owo+ID4gKwkJfTsKPiA+ICsKPiA+ICsJCXZyZWdf czRhXzFwODogc21wczQgewo+ID4gKwkJCXJlZ3VsYXRvci1taW4tbWljcm92b2x0ID0gPDE4MDAw MDA+Owo+ID4gKwkJCXJlZ3VsYXRvci1tYXgtbWljcm92b2x0ID0gPDE4MDAwMDA+Owo+ID4gKwkJ CXJlZ3VsYXRvci1pbml0aWFsLW1vZGUgPSA8UlBNSF9SRUdVTEFUT1JfTU9ERV9IUE0+Owo+ID4g KwkJfTsKPiA+ICsKPiA+ICsJCXZyZWdfczVhXzJwMDQ6IHNtcHM1IHsKPiA+ICsJCQlyZWd1bGF0 b3ItbWluLW1pY3Jvdm9sdCA9IDwyMDQwMDAwPjsKPiA+ICsJCQlyZWd1bGF0b3ItbWF4LW1pY3Jv dm9sdCA9IDwyMDQwMDAwPjsKPiA+ICsJCQlyZWd1bGF0b3ItaW5pdGlhbC1tb2RlID0gPFJQTUhf UkVHVUxBVE9SX01PREVfSFBNPjsKPiA+ICsJCX07Cj4gPiArCj4gPiArCQl2cmVnX3M3YV8xcDAy NTogc21wczcgewo+IAo+IEFueSByZWFzb24gd2h5IHdlIGRvbnQgc3BlY2lmeSB0aGUgbW9kZSBh bmQgbWluL21heCB2b2x0YWdlIGZvciB0aGlzCj4gYW5kIGZldyBvdGhlcnMgYmVsb3cuLj8KCk1p Z2h0IGhhdmUgdG8gYXNrIEJqb3JuIHRoYXQgb25lLgoKPiA+ICsmaTJjMSB7Cj4gPiArCXN0YXR1 cyA9ICJva2F5IjsKPiA+ICsJY2xvY2stZnJlcXVlbmN5ID0gPDQwMDAwMD47Cj4gPiArCXFjb20s Z2VuaS1zZS1maWZvOwo+ID4gKwo+ID4gKwliYXR0ZXJ5QDcwIHsKPiA+ICsJCWNvbXBhdGlibGUg PSAic29tZSxiYXR0ZXJ5IjsKPiAKPiBzb21lLGJhdHRlcnkgLi4/CgpHb29kIHNwb3QuICBUaGlz IHRoZSBiYXR0ZXJ5IGxldmVsL0FDIGRldGVjdGlvbiBkcml2ZXIgdGhhdCBpc24ndAp1cHN0cmVh bSB5ZXQuICBXaWxsIHJlbW92ZS4KCj4gPiArJnF1cF9pMmMxMl9kZWZhdWx0IHsKPiAKPiBQbGVh c2UgbW92ZSB0aGUgcXVwIG5vZGVzIHVwIHNvIHRoYXQgbm9kZXMgYXJlIHNvcnRlZCBhbHBoYWJl dGljYWxseQoKU3VyZS4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KTGluYXJvIFNlcnZpY2Vz IFRlY2huaWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBB Uk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==