From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2432C3A5A7 for ; Wed, 4 Sep 2019 12:48:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B3A0321883 for ; Wed, 4 Sep 2019 12:48:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730061AbfIDMsA convert rfc822-to-8bit (ORCPT ); Wed, 4 Sep 2019 08:48:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:46238 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727675AbfIDMsA (ORCPT ); Wed, 4 Sep 2019 08:48:00 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 51CE3AF47; Wed, 4 Sep 2019 12:47:59 +0000 (UTC) Date: Wed, 4 Sep 2019 14:47:59 +0200 From: Thomas Bogendoerfer To: Greg Kroah-Hartman Cc: Evgeniy Polyakov , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] w1: add 1-wire master driver for IP block found in SGI ASICs Message-Id: <20190904144759.39294ab80882bfdb9eeb78d0@suse.de> In-Reply-To: <20190904123351.GA15401@kroah.com> References: <20190831082623.15627-1-tbogendoerfer@suse.de> <20190831082623.15627-2-tbogendoerfer@suse.de> <20190904114837.GA9153@kroah.com> <20190904140134.698aaf5f5ec204a5305c1177@suse.de> <20190904120646.GA11400@kroah.com> <20190904141434.7d05c6bcd2852d2060ba91ce@suse.de> <20190904123351.GA15401@kroah.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Sep 2019 14:33:51 +0200 Greg Kroah-Hartman wrote: > On Wed, Sep 04, 2019 at 02:14:34PM +0200, Thomas Bogendoerfer wrote: > > On Wed, 4 Sep 2019 14:06:46 +0200 > > Greg Kroah-Hartman wrote: > > > > > On Wed, Sep 04, 2019 at 02:01:34PM +0200, Thomas Bogendoerfer wrote: > > > > On Wed, 4 Sep 2019 13:48:37 +0200 > > > > Greg Kroah-Hartman wrote: > > > > > > > > > On Sat, Aug 31, 2019 at 10:26:21AM +0200, Thomas Bogendoerfer wrote: > > > > > > Starting with SGI Origin machines nearly every new SGI ASIC contains > > > > > > an 1-Wire master. They are used for attaching One-Wire prom devices, > > > > > > which contain information about part numbers, revision numbers, > > > > > > serial number etc. and MAC addresses for ethernet interfaces. > > > > > > This patch adds a master driver to support this IP block. > > > > > > It also adds an extra field dev_id to struct w1_bus_master, which > > > > > > could be in used in slave drivers for creating unique device names. > > > > > > > > > > > > Signed-off-by: Thomas Bogendoerfer > > > > > > --- > > > > > > drivers/w1/masters/Kconfig | 9 +++ > > > > > > drivers/w1/masters/Makefile | 1 + > > > > > > drivers/w1/masters/sgi_w1.c | 130 +++++++++++++++++++++++++++++++++++ > > > > > > include/linux/platform_data/sgi-w1.h | 13 ++++ > > > > > > > > > > Why platform data? I thought that was the "old way", and the "proper > > > > > way" now is to use device tree? > > > > > > > > this machine is old and doesn't have device tree at all. > > > > > > Your text says "every new SGI ASIC". So new devices are being made for > > > old systems? > > > > > > confused, > > > > ok, now I see where the confusion comes from. New in the meaning of latest > > produced SGI MIPS system. > > > > Is it better, if I rephrase this to latest line of MIPS system ASICs ? > > Nah, I'll take this now, it's ok, thanks for the explanation. thank you, Thomas. -- SUSE Software Solutions Germany GmbH HRB 247165 (AG München) Geschäftsführer: Felix Imendörffer