From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 04 Sep 2019 18:55:07 +0000 Subject: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling Message-Id: <20190904185507.GA3634@mwanda> List-Id: References: <20190904115057.GC4811@pendragon.ideasonboard.com> In-Reply-To: <20190904115057.GC4811@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thierry Reding , Laurent Pinchart Cc: David Airlie , kernel-janitors@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Mark Brown , Sam Ravnborg The "lvds->backlight" pointer could be NULL in situations were of_parse_phandle() returns NULL. Also it's slightly cleaner to use backlight_put() which already has a check for NULL built in. Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver") Signed-off-by: Dan Carpenter --- v2: Use backlight_put(). Thanks, Laurent! drivers/gpu/drm/panel/panel-lvds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c index ad47cc95459e..05e8885db7ed 100644 --- a/drivers/gpu/drm/panel/panel-lvds.c +++ b/drivers/gpu/drm/panel/panel-lvds.c @@ -272,7 +272,7 @@ static int panel_lvds_probe(struct platform_device *pdev) return 0; error: - put_device(&lvds->backlight->dev); + backlight_put(lvds->backlight); return ret; } -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling Date: Wed, 4 Sep 2019 21:55:07 +0300 Message-ID: <20190904185507.GA3634@mwanda> References: <20190904115057.GC4811@pendragon.ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1ECD589C25 for ; Wed, 4 Sep 2019 18:55:42 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190904115057.GC4811@pendragon.ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding , Laurent Pinchart Cc: David Airlie , kernel-janitors@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Mark Brown , Sam Ravnborg List-Id: dri-devel@lists.freedesktop.org VGhlICJsdmRzLT5iYWNrbGlnaHQiIHBvaW50ZXIgY291bGQgYmUgTlVMTCBpbiBzaXR1YXRpb25z IHdlcmUKb2ZfcGFyc2VfcGhhbmRsZSgpIHJldHVybnMgTlVMTC4gIEFsc28gaXQncyBzbGlnaHRs eSBjbGVhbmVyIHRvIHVzZQpiYWNrbGlnaHRfcHV0KCkgd2hpY2ggYWxyZWFkeSBoYXMgYSBjaGVj ayBmb3IgTlVMTCBidWlsdCBpbi4KCkZpeGVzOiA3YzlkZmY1YmQ2NDMgKCJkcm06IHBhbmVsczog QWRkIExWRFMgcGFuZWwgZHJpdmVyIikKU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFu LmNhcnBlbnRlckBvcmFjbGUuY29tPgotLS0KdjI6IFVzZSBiYWNrbGlnaHRfcHV0KCkuICBUaGFu a3MsIExhdXJlbnQhCgogZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLWx2ZHMuYyB8IDIgKy0K IDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1sdmRzLmMgYi9kcml2ZXJzL2dwdS9kcm0v cGFuZWwvcGFuZWwtbHZkcy5jCmluZGV4IGFkNDdjYzk1NDU5ZS4uMDVlODg4NWRiN2VkIDEwMDY0 NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtbHZkcy5jCisrKyBiL2RyaXZlcnMv Z3B1L2RybS9wYW5lbC9wYW5lbC1sdmRzLmMKQEAgLTI3Miw3ICsyNzIsNyBAQCBzdGF0aWMgaW50 IHBhbmVsX2x2ZHNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKIAlyZXR1cm4g MDsKIAogZXJyb3I6Ci0JcHV0X2RldmljZSgmbHZkcy0+YmFja2xpZ2h0LT5kZXYpOworCWJhY2ts aWdodF9wdXQobHZkcy0+YmFja2xpZ2h0KTsKIAlyZXR1cm4gcmV0OwogfQogCi0tIAoyLjIwLjEK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==