All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm: panel-lvds: Potential Oops in probe error handling
@ 2019-09-04 10:03 ` Dan Carpenter
  0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2019-09-04 10:03 UTC (permalink / raw)
  To: Thierry Reding, Laurent Pinchart
  Cc: David Airlie, kernel-janitors, Liam Girdwood, dri-devel,
	Mark Brown, Sam Ravnborg

The "lvds->backlight" pointer could be NULl if of_parse_phandle()
returns NULL.

Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/panel/panel-lvds.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
index ad47cc95459e..3b4eb959e994 100644
--- a/drivers/gpu/drm/panel/panel-lvds.c
+++ b/drivers/gpu/drm/panel/panel-lvds.c
@@ -272,7 +272,8 @@ static int panel_lvds_probe(struct platform_device *pdev)
 	return 0;
 
 error:
-	put_device(&lvds->backlight->dev);
+	if (lvds->backlight)
+		put_device(&lvds->backlight->dev);
 	return ret;
 }
 
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2019-09-10 13:32 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 10:03 [PATCH] drm: panel-lvds: Potential Oops in probe error handling Dan Carpenter
2019-09-04 10:03 ` Dan Carpenter
2019-09-04 11:50 ` Laurent Pinchart
2019-09-04 11:50   ` Laurent Pinchart
2019-09-04 12:57   ` Dan Carpenter
2019-09-04 12:57     ` Dan Carpenter
2019-09-04 18:55   ` [PATCH v2] " Dan Carpenter
2019-09-04 18:55     ` Dan Carpenter
2019-09-04 21:48     ` Laurent Pinchart
2019-09-04 21:48       ` Laurent Pinchart
2019-09-08 16:04     ` Sam Ravnborg
2019-09-08 16:04       ` Sam Ravnborg
2019-09-10 13:32       ` Dan Carpenter
2019-09-10 13:32         ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.