* [PATCH] drm: panel-lvds: Potential Oops in probe error handling
@ 2019-09-04 10:03 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2019-09-04 10:03 UTC (permalink / raw)
To: Thierry Reding, Laurent Pinchart
Cc: David Airlie, kernel-janitors, Liam Girdwood, dri-devel,
Mark Brown, Sam Ravnborg
The "lvds->backlight" pointer could be NULl if of_parse_phandle()
returns NULL.
Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/panel/panel-lvds.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
index ad47cc95459e..3b4eb959e994 100644
--- a/drivers/gpu/drm/panel/panel-lvds.c
+++ b/drivers/gpu/drm/panel/panel-lvds.c
@@ -272,7 +272,8 @@ static int panel_lvds_probe(struct platform_device *pdev)
return 0;
error:
- put_device(&lvds->backlight->dev);
+ if (lvds->backlight)
+ put_device(&lvds->backlight->dev);
return ret;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] drm: panel-lvds: Potential Oops in probe error handling
@ 2019-09-04 10:03 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2019-09-04 10:03 UTC (permalink / raw)
To: Thierry Reding, Laurent Pinchart
Cc: David Airlie, kernel-janitors, Liam Girdwood, dri-devel,
Mark Brown, Sam Ravnborg
The "lvds->backlight" pointer could be NULl if of_parse_phandle()
returns NULL.
Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/panel/panel-lvds.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
index ad47cc95459e..3b4eb959e994 100644
--- a/drivers/gpu/drm/panel/panel-lvds.c
+++ b/drivers/gpu/drm/panel/panel-lvds.c
@@ -272,7 +272,8 @@ static int panel_lvds_probe(struct platform_device *pdev)
return 0;
error:
- put_device(&lvds->backlight->dev);
+ if (lvds->backlight)
+ put_device(&lvds->backlight->dev);
return ret;
}
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] drm: panel-lvds: Potential Oops in probe error handling
2019-09-04 10:03 ` Dan Carpenter
@ 2019-09-04 11:50 ` Laurent Pinchart
-1 siblings, 0 replies; 14+ messages in thread
From: Laurent Pinchart @ 2019-09-04 11:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: Laurent Pinchart, David Airlie, Mark Brown, kernel-janitors,
Liam Girdwood, dri-devel, Thierry Reding, Sam Ravnborg
Hi Dan,
Thank you for the patch.
On Wed, Sep 04, 2019 at 01:03:29PM +0300, Dan Carpenter wrote:
> The "lvds->backlight" pointer could be NULl if of_parse_phandle()
> returns NULL.
>
> Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/panel/panel-lvds.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
> index ad47cc95459e..3b4eb959e994 100644
> --- a/drivers/gpu/drm/panel/panel-lvds.c
> +++ b/drivers/gpu/drm/panel/panel-lvds.c
> @@ -272,7 +272,8 @@ static int panel_lvds_probe(struct platform_device *pdev)
> return 0;
>
> error:
> - put_device(&lvds->backlight->dev);
> + if (lvds->backlight)
> + put_device(&lvds->backlight->dev);
How about simply
- put_device(&lvds->backlight->dev);
+ backlight_put(lvds->backlight);
?
> return ret;
> }
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm: panel-lvds: Potential Oops in probe error handling
@ 2019-09-04 11:50 ` Laurent Pinchart
0 siblings, 0 replies; 14+ messages in thread
From: Laurent Pinchart @ 2019-09-04 11:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: Laurent Pinchart, David Airlie, Mark Brown, kernel-janitors,
Liam Girdwood, dri-devel, Thierry Reding, Sam Ravnborg
Hi Dan,
Thank you for the patch.
On Wed, Sep 04, 2019 at 01:03:29PM +0300, Dan Carpenter wrote:
> The "lvds->backlight" pointer could be NULl if of_parse_phandle()
> returns NULL.
>
> Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/panel/panel-lvds.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
> index ad47cc95459e..3b4eb959e994 100644
> --- a/drivers/gpu/drm/panel/panel-lvds.c
> +++ b/drivers/gpu/drm/panel/panel-lvds.c
> @@ -272,7 +272,8 @@ static int panel_lvds_probe(struct platform_device *pdev)
> return 0;
>
> error:
> - put_device(&lvds->backlight->dev);
> + if (lvds->backlight)
> + put_device(&lvds->backlight->dev);
How about simply
- put_device(&lvds->backlight->dev);
+ backlight_put(lvds->backlight);
?
> return ret;
> }
>
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm: panel-lvds: Potential Oops in probe error handling
2019-09-04 11:50 ` Laurent Pinchart
@ 2019-09-04 12:57 ` Dan Carpenter
-1 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2019-09-04 12:57 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Laurent Pinchart, David Airlie, Mark Brown, kernel-janitors,
Liam Girdwood, dri-devel, Thierry Reding, Sam Ravnborg
On Wed, Sep 04, 2019 at 02:50:57PM +0300, Laurent Pinchart wrote:
> > error:
> > - put_device(&lvds->backlight->dev);
> > + if (lvds->backlight)
> > + put_device(&lvds->backlight->dev);
>
> How about simply
>
> - put_device(&lvds->backlight->dev);
> + backlight_put(lvds->backlight);
Yeah. That's cleaner. I will resend.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm: panel-lvds: Potential Oops in probe error handling
@ 2019-09-04 12:57 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2019-09-04 12:57 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Laurent Pinchart, David Airlie, Mark Brown, kernel-janitors,
Liam Girdwood, dri-devel, Thierry Reding, Sam Ravnborg
On Wed, Sep 04, 2019 at 02:50:57PM +0300, Laurent Pinchart wrote:
> > error:
> > - put_device(&lvds->backlight->dev);
> > + if (lvds->backlight)
> > + put_device(&lvds->backlight->dev);
>
> How about simply
>
> - put_device(&lvds->backlight->dev);
> + backlight_put(lvds->backlight);
Yeah. That's cleaner. I will resend.
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling
2019-09-04 11:50 ` Laurent Pinchart
@ 2019-09-04 18:55 ` Dan Carpenter
-1 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2019-09-04 18:55 UTC (permalink / raw)
To: Thierry Reding, Laurent Pinchart
Cc: David Airlie, kernel-janitors, Liam Girdwood, dri-devel,
Mark Brown, Sam Ravnborg
The "lvds->backlight" pointer could be NULL in situations were
of_parse_phandle() returns NULL. Also it's slightly cleaner to use
backlight_put() which already has a check for NULL built in.
Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: Use backlight_put(). Thanks, Laurent!
drivers/gpu/drm/panel/panel-lvds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
index ad47cc95459e..05e8885db7ed 100644
--- a/drivers/gpu/drm/panel/panel-lvds.c
+++ b/drivers/gpu/drm/panel/panel-lvds.c
@@ -272,7 +272,7 @@ static int panel_lvds_probe(struct platform_device *pdev)
return 0;
error:
- put_device(&lvds->backlight->dev);
+ backlight_put(lvds->backlight);
return ret;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling
@ 2019-09-04 18:55 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2019-09-04 18:55 UTC (permalink / raw)
To: Thierry Reding, Laurent Pinchart
Cc: David Airlie, kernel-janitors, Liam Girdwood, dri-devel,
Mark Brown, Sam Ravnborg
The "lvds->backlight" pointer could be NULL in situations were
of_parse_phandle() returns NULL. Also it's slightly cleaner to use
backlight_put() which already has a check for NULL built in.
Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: Use backlight_put(). Thanks, Laurent!
drivers/gpu/drm/panel/panel-lvds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
index ad47cc95459e..05e8885db7ed 100644
--- a/drivers/gpu/drm/panel/panel-lvds.c
+++ b/drivers/gpu/drm/panel/panel-lvds.c
@@ -272,7 +272,7 @@ static int panel_lvds_probe(struct platform_device *pdev)
return 0;
error:
- put_device(&lvds->backlight->dev);
+ backlight_put(lvds->backlight);
return ret;
}
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling
2019-09-04 18:55 ` Dan Carpenter
@ 2019-09-04 21:48 ` Laurent Pinchart
-1 siblings, 0 replies; 14+ messages in thread
From: Laurent Pinchart @ 2019-09-04 21:48 UTC (permalink / raw)
To: Dan Carpenter
Cc: Laurent Pinchart, David Airlie, Mark Brown, kernel-janitors,
Liam Girdwood, dri-devel, Thierry Reding, Sam Ravnborg
Hi Dan,
Thank you for the patch.
On Wed, Sep 04, 2019 at 09:55:07PM +0300, Dan Carpenter wrote:
> The "lvds->backlight" pointer could be NULL in situations were
> of_parse_phandle() returns NULL. Also it's slightly cleaner to use
> backlight_put() which already has a check for NULL built in.
>
> Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Sam, would you be able to pick this patch ?
> ---
> v2: Use backlight_put(). Thanks, Laurent!
>
> drivers/gpu/drm/panel/panel-lvds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
> index ad47cc95459e..05e8885db7ed 100644
> --- a/drivers/gpu/drm/panel/panel-lvds.c
> +++ b/drivers/gpu/drm/panel/panel-lvds.c
> @@ -272,7 +272,7 @@ static int panel_lvds_probe(struct platform_device *pdev)
> return 0;
>
> error:
> - put_device(&lvds->backlight->dev);
> + backlight_put(lvds->backlight);
> return ret;
> }
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling
@ 2019-09-04 21:48 ` Laurent Pinchart
0 siblings, 0 replies; 14+ messages in thread
From: Laurent Pinchart @ 2019-09-04 21:48 UTC (permalink / raw)
To: Dan Carpenter
Cc: Laurent Pinchart, David Airlie, Mark Brown, kernel-janitors,
Liam Girdwood, dri-devel, Thierry Reding, Sam Ravnborg
Hi Dan,
Thank you for the patch.
On Wed, Sep 04, 2019 at 09:55:07PM +0300, Dan Carpenter wrote:
> The "lvds->backlight" pointer could be NULL in situations were
> of_parse_phandle() returns NULL. Also it's slightly cleaner to use
> backlight_put() which already has a check for NULL built in.
>
> Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Sam, would you be able to pick this patch ?
> ---
> v2: Use backlight_put(). Thanks, Laurent!
>
> drivers/gpu/drm/panel/panel-lvds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
> index ad47cc95459e..05e8885db7ed 100644
> --- a/drivers/gpu/drm/panel/panel-lvds.c
> +++ b/drivers/gpu/drm/panel/panel-lvds.c
> @@ -272,7 +272,7 @@ static int panel_lvds_probe(struct platform_device *pdev)
> return 0;
>
> error:
> - put_device(&lvds->backlight->dev);
> + backlight_put(lvds->backlight);
> return ret;
> }
>
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling
2019-09-04 18:55 ` Dan Carpenter
@ 2019-09-08 16:04 ` Sam Ravnborg
-1 siblings, 0 replies; 14+ messages in thread
From: Sam Ravnborg @ 2019-09-08 16:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Laurent Pinchart, David Airlie, kernel-janitors, Liam Girdwood,
dri-devel, Mark Brown, Thierry Reding
Hi Dan.
On Wed, Sep 04, 2019 at 09:55:07PM +0300, Dan Carpenter wrote:
> The "lvds->backlight" pointer could be NULL in situations were
> of_parse_phandle() returns NULL. Also it's slightly cleaner to use
> backlight_put() which already has a check for NULL built in.
>
> Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
A much better fix would be to introduce use of devm_of_find_backlight().
Then you do not have to worry about put().
Care to respin a v3 that does this?
Sam
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling
@ 2019-09-08 16:04 ` Sam Ravnborg
0 siblings, 0 replies; 14+ messages in thread
From: Sam Ravnborg @ 2019-09-08 16:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Laurent Pinchart, David Airlie, kernel-janitors, Liam Girdwood,
dri-devel, Mark Brown, Thierry Reding
Hi Dan.
On Wed, Sep 04, 2019 at 09:55:07PM +0300, Dan Carpenter wrote:
> The "lvds->backlight" pointer could be NULL in situations were
> of_parse_phandle() returns NULL. Also it's slightly cleaner to use
> backlight_put() which already has a check for NULL built in.
>
> Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
A much better fix would be to introduce use of devm_of_find_backlight().
Then you do not have to worry about put().
Care to respin a v3 that does this?
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling
2019-09-08 16:04 ` Sam Ravnborg
@ 2019-09-10 13:32 ` Dan Carpenter
-1 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2019-09-10 13:32 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Laurent Pinchart, David Airlie, kernel-janitors, Liam Girdwood,
dri-devel, Mark Brown, Thierry Reding
On Sun, Sep 08, 2019 at 06:04:28PM +0200, Sam Ravnborg wrote:
> Hi Dan.
>
> On Wed, Sep 04, 2019 at 09:55:07PM +0300, Dan Carpenter wrote:
> > The "lvds->backlight" pointer could be NULL in situations were
> > of_parse_phandle() returns NULL. Also it's slightly cleaner to use
> > backlight_put() which already has a check for NULL built in.
> >
> > Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> A much better fix would be to introduce use of devm_of_find_backlight().
> Then you do not have to worry about put().
>
> Care to respin a v3 that does this?
Sure. That does look nice. I will resend tomorrow.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling
@ 2019-09-10 13:32 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2019-09-10 13:32 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Laurent Pinchart, David Airlie, kernel-janitors, Liam Girdwood,
dri-devel, Mark Brown, Thierry Reding
On Sun, Sep 08, 2019 at 06:04:28PM +0200, Sam Ravnborg wrote:
> Hi Dan.
>
> On Wed, Sep 04, 2019 at 09:55:07PM +0300, Dan Carpenter wrote:
> > The "lvds->backlight" pointer could be NULL in situations were
> > of_parse_phandle() returns NULL. Also it's slightly cleaner to use
> > backlight_put() which already has a check for NULL built in.
> >
> > Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> A much better fix would be to introduce use of devm_of_find_backlight().
> Then you do not have to worry about put().
>
> Care to respin a v3 that does this?
Sure. That does look nice. I will resend tomorrow.
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-09-10 13:32 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 10:03 [PATCH] drm: panel-lvds: Potential Oops in probe error handling Dan Carpenter
2019-09-04 10:03 ` Dan Carpenter
2019-09-04 11:50 ` Laurent Pinchart
2019-09-04 11:50 ` Laurent Pinchart
2019-09-04 12:57 ` Dan Carpenter
2019-09-04 12:57 ` Dan Carpenter
2019-09-04 18:55 ` [PATCH v2] " Dan Carpenter
2019-09-04 18:55 ` Dan Carpenter
2019-09-04 21:48 ` Laurent Pinchart
2019-09-04 21:48 ` Laurent Pinchart
2019-09-08 16:04 ` Sam Ravnborg
2019-09-08 16:04 ` Sam Ravnborg
2019-09-10 13:32 ` Dan Carpenter
2019-09-10 13:32 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.