All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: kbuild-all@01.org, linux-gpio@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>
Subject: [pinctrl:for-next 16/77] drivers/pinctrl/bcm/pinctrl-bcm2835.c:995:10: error: incompatible types when assigning to type 'volatile struct SHIFTER' from type 'unsigned int'
Date: Wed, 4 Sep 2019 19:07:10 +0800	[thread overview]
Message-ID: <201909041904.FgFKdAf7%lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 5181 bytes --]

Hi Stefan,

FYI, the error/warning still remains.

tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git for-next
head:   bacada1c3fb4f116c8a1ebc864a9bd4ffd14e2d2
commit: e38a9a437fb93ddafab5030165e4c6a3a5021669 [16/77] pinctrl: bcm2835: Add support for BCM2711 pull-up functionality
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout e38a9a437fb93ddafab5030165e4c6a3a5021669
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/m68k/include/asm/io_mm.h:32:0,
                    from arch/m68k/include/asm/io.h:8,
                    from include/linux/io.h:13,
                    from include/linux/irq.h:20,
                    from include/linux/gpio/driver.h:7,
                    from drivers/pinctrl/bcm/pinctrl-bcm2835.c:17:
   drivers/pinctrl/bcm/pinctrl-bcm2835.c: In function 'bcm2711_pull_config_set':
>> arch/m68k/include/asm/atarihw.h:190:22: error: expected identifier or '(' before 'volatile'
    # define shifter ((*(volatile struct SHIFTER *)SHF_BAS))
                         ^
   drivers/pinctrl/bcm/pinctrl-bcm2835.c:990:6: note: in expansion of macro 'shifter'
     u32 shifter;
         ^~~~~~~
>> arch/m68k/include/asm/atarihw.h:172:17: error: expected ')' before '(' token
    #define SHF_BAS (0xffff8200)
                    ^
   arch/m68k/include/asm/atarihw.h:190:48: note: in expansion of macro 'SHF_BAS'
    # define shifter ((*(volatile struct SHIFTER *)SHF_BAS))
                                                   ^~~~~~~
   drivers/pinctrl/bcm/pinctrl-bcm2835.c:990:6: note: in expansion of macro 'shifter'
     u32 shifter;
         ^~~~~~~
>> drivers/pinctrl/bcm/pinctrl-bcm2835.c:995:10: error: incompatible types when assigning to type 'volatile struct SHIFTER' from type 'unsigned int'
     shifter = PUD_2711_REG_SHIFT(pin);
             ^
>> drivers/pinctrl/bcm/pinctrl-bcm2835.c:998:27: error: invalid operands to binary << (have 'int' and 'volatile struct SHIFTER')
     value &= ~(PUD_2711_MASK << shifter);
                              ^~
>> drivers/pinctrl/bcm/pinctrl-bcm2835.c:999:16: error: invalid operands to binary << (have 'unsigned int' and 'volatile struct SHIFTER')
     value |= (arg << shifter);
                   ^~
--
   In file included from arch/m68k/include/asm/io_mm.h:32:0,
                    from arch/m68k/include/asm/io.h:8,
                    from include/linux/io.h:13,
                    from include/linux/irq.h:20,
                    from include/linux/gpio/driver.h:7,
                    from drivers/pinctrl//bcm/pinctrl-bcm2835.c:17:
   drivers/pinctrl//bcm/pinctrl-bcm2835.c: In function 'bcm2711_pull_config_set':
>> arch/m68k/include/asm/atarihw.h:190:22: error: expected identifier or '(' before 'volatile'
    # define shifter ((*(volatile struct SHIFTER *)SHF_BAS))
                         ^
   drivers/pinctrl//bcm/pinctrl-bcm2835.c:990:6: note: in expansion of macro 'shifter'
     u32 shifter;
         ^~~~~~~
>> arch/m68k/include/asm/atarihw.h:172:17: error: expected ')' before '(' token
    #define SHF_BAS (0xffff8200)
                    ^
   arch/m68k/include/asm/atarihw.h:190:48: note: in expansion of macro 'SHF_BAS'
    # define shifter ((*(volatile struct SHIFTER *)SHF_BAS))
                                                   ^~~~~~~
   drivers/pinctrl//bcm/pinctrl-bcm2835.c:990:6: note: in expansion of macro 'shifter'
     u32 shifter;
         ^~~~~~~
   drivers/pinctrl//bcm/pinctrl-bcm2835.c:995:10: error: incompatible types when assigning to type 'volatile struct SHIFTER' from type 'unsigned int'
     shifter = PUD_2711_REG_SHIFT(pin);
             ^
   drivers/pinctrl//bcm/pinctrl-bcm2835.c:998:27: error: invalid operands to binary << (have 'int' and 'volatile struct SHIFTER')
     value &= ~(PUD_2711_MASK << shifter);
                              ^~
   drivers/pinctrl//bcm/pinctrl-bcm2835.c:999:16: error: invalid operands to binary << (have 'unsigned int' and 'volatile struct SHIFTER')
     value |= (arg << shifter);
                   ^~

vim +995 drivers/pinctrl/bcm/pinctrl-bcm2835.c

   986	
   987	static void bcm2711_pull_config_set(struct bcm2835_pinctrl *pc,
   988					    unsigned int pin, unsigned int arg)
   989	{
 > 990		u32 shifter;
   991		u32 value;
   992		u32 off;
   993	
   994		off = PUD_2711_REG_OFFSET(pin);
 > 995		shifter = PUD_2711_REG_SHIFT(pin);
   996	
   997		value = bcm2835_gpio_rd(pc, GP_GPIO_PUP_PDN_CNTRL_REG0 + (off * 4));
 > 998		value &= ~(PUD_2711_MASK << shifter);
 > 999		value |= (arg << shifter);
  1000		bcm2835_gpio_wr(pc, GP_GPIO_PUP_PDN_CNTRL_REG0 + (off * 4), value);
  1001	}
  1002	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50881 bytes --]

             reply	other threads:[~2019-09-04 11:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04 11:07 kbuild test robot [this message]
2019-09-04 11:44 ` [pinctrl:for-next 16/77] drivers/pinctrl/bcm/pinctrl-bcm2835.c:995:10: error: incompatible types when assigning to type 'volatile struct SHIFTER' from type 'unsigned int' Geert Uytterhoeven
2019-09-04 13:20   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201909041904.FgFKdAf7%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.