From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Wed, 04 Sep 2019 21:48:49 +0000 Subject: Re: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling Message-Id: <20190904214849.GM5433@pendragon.ideasonboard.com> List-Id: References: <20190904115057.GC4811@pendragon.ideasonboard.com> <20190904185507.GA3634@mwanda> In-Reply-To: <20190904185507.GA3634@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Laurent Pinchart , David Airlie , Mark Brown , kernel-janitors@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Thierry Reding , Sam Ravnborg Hi Dan, Thank you for the patch. On Wed, Sep 04, 2019 at 09:55:07PM +0300, Dan Carpenter wrote: > The "lvds->backlight" pointer could be NULL in situations were > of_parse_phandle() returns NULL. Also it's slightly cleaner to use > backlight_put() which already has a check for NULL built in. > > Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver") > Signed-off-by: Dan Carpenter Reviewed-by: Laurent Pinchart Sam, would you be able to pick this patch ? > --- > v2: Use backlight_put(). Thanks, Laurent! > > drivers/gpu/drm/panel/panel-lvds.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c > index ad47cc95459e..05e8885db7ed 100644 > --- a/drivers/gpu/drm/panel/panel-lvds.c > +++ b/drivers/gpu/drm/panel/panel-lvds.c > @@ -272,7 +272,7 @@ static int panel_lvds_probe(struct platform_device *pdev) > return 0; > > error: > - put_device(&lvds->backlight->dev); > + backlight_put(lvds->backlight); > return ret; > } > -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2] drm: panel-lvds: Potential Oops in probe error handling Date: Thu, 5 Sep 2019 00:48:49 +0300 Message-ID: <20190904214849.GM5433@pendragon.ideasonboard.com> References: <20190904115057.GC4811@pendragon.ideasonboard.com> <20190904185507.GA3634@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4AD0A8914E for ; Wed, 4 Sep 2019 21:48:57 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190904185507.GA3634@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter Cc: Laurent Pinchart , David Airlie , Mark Brown , kernel-janitors@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Thierry Reding , Sam Ravnborg List-Id: dri-devel@lists.freedesktop.org SGkgRGFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBXZWQsIFNlcCAwNCwgMjAxOSBh dCAwOTo1NTowN1BNICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOgo+IFRoZSAibHZkcy0+YmFj a2xpZ2h0IiBwb2ludGVyIGNvdWxkIGJlIE5VTEwgaW4gc2l0dWF0aW9ucyB3ZXJlCj4gb2ZfcGFy c2VfcGhhbmRsZSgpIHJldHVybnMgTlVMTC4gIEFsc28gaXQncyBzbGlnaHRseSBjbGVhbmVyIHRv IHVzZQo+IGJhY2tsaWdodF9wdXQoKSB3aGljaCBhbHJlYWR5IGhhcyBhIGNoZWNrIGZvciBOVUxM IGJ1aWx0IGluLgo+IAo+IEZpeGVzOiA3YzlkZmY1YmQ2NDMgKCJkcm06IHBhbmVsczogQWRkIExW RFMgcGFuZWwgZHJpdmVyIikKPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2Fy cGVudGVyQG9yYWNsZS5jb20+CgpSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVu dC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoKU2FtLCB3b3VsZCB5b3UgYmUgYWJsZSB0byBw aWNrIHRoaXMgcGF0Y2ggPwoKPiAtLS0KPiB2MjogVXNlIGJhY2tsaWdodF9wdXQoKS4gIFRoYW5r cywgTGF1cmVudCEKPiAKPiAgZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLWx2ZHMuYyB8IDIg Ky0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1sdmRzLmMgYi9kcml2ZXJz L2dwdS9kcm0vcGFuZWwvcGFuZWwtbHZkcy5jCj4gaW5kZXggYWQ0N2NjOTU0NTllLi4wNWU4ODg1 ZGI3ZWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLWx2ZHMuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1sdmRzLmMKPiBAQCAtMjcyLDcgKzI3 Miw3IEBAIHN0YXRpYyBpbnQgcGFuZWxfbHZkc19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl ICpwZGV2KQo+ICAJcmV0dXJuIDA7Cj4gIAo+ICBlcnJvcjoKPiAtCXB1dF9kZXZpY2UoJmx2ZHMt PmJhY2tsaWdodC0+ZGV2KTsKPiArCWJhY2tsaWdodF9wdXQobHZkcy0+YmFja2xpZ2h0KTsKPiAg CXJldHVybiByZXQ7Cj4gIH0KPiAgCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs