From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC59C3A59E for ; Thu, 5 Sep 2019 00:01:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6AE1421881 for ; Thu, 5 Sep 2019 00:01:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730196AbfIEAB1 (ORCPT ); Wed, 4 Sep 2019 20:01:27 -0400 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:46263 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727156AbfIEAB0 (ORCPT ); Wed, 4 Sep 2019 20:01:26 -0400 Received: from dread.disaster.area (pa49-181-255-194.pa.nsw.optusnet.com.au [49.181.255.194]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 062A72ADA66; Thu, 5 Sep 2019 10:01:24 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92) (envelope-from ) id 1i5fDH-0000NT-TO; Thu, 05 Sep 2019 10:01:23 +1000 Date: Thu, 5 Sep 2019 10:01:23 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org Subject: Re: [PATCH 4/4] xfs_spaceman: convert open-coded unit conversions to helpers Message-ID: <20190905000123.GC1119@dread.disaster.area> References: <156757189636.1838733.8025635445292375382.stgit@magnolia> <156757192700.1838733.16850596931923084140.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <156757192700.1838733.16850596931923084140.stgit@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=D+Q3ErZj c=1 sm=1 tr=0 a=YO9NNpcXwc8z/SaoS+iAiA==:117 a=YO9NNpcXwc8z/SaoS+iAiA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=J70Eh1EUuV4A:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=IGSD2V0JfsNlH-3_hC0A:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Sep 03, 2019 at 09:38:47PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Create xfrog analogues of the libxfs byte/sector/block conversion > functions and convert spaceman to use them instead of open-coded > arithmatic we do now. > > Signed-off-by: Darrick J. Wong > --- > libfrog/fsgeom.c | 1 + > libfrog/fsgeom.h | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > spaceman/freesp.c | 15 +++------ > spaceman/trim.c | 9 +++--- > 4 files changed, 96 insertions(+), 14 deletions(-) Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com