From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Nishad Kamdar" <nishadkamdar@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: siano: Use the correct style for SPDX License Identifier
Date: Thu, 5 Sep 2019 07:46:58 -0300 [thread overview]
Message-ID: <20190905074658.0f229587@coco.lan> (raw)
In-Reply-To: <f65bf8e7bc3234358d5956f94e3b4df81bc204e6.camel@perches.com>
Em Thu, 05 Sep 2019 02:28:05 -0700
Joe Perches <joe@perches.com> escreveu:
> On Thu, 2019-09-05 at 05:56 -0300, Mauro Carvalho Chehab wrote:
> > I'll accept
> > this patch and keep such rule in mind for next SPDX changes.
> >
> > Anyway, with regards to script, we need to change the rules in order to
> > allow adding SPDX for python scripts, as otherwise the addition of SPDX
> > headers may cause regressions.
>
> Not really.
>
> $ git grep -n '^# SPDX-License-Identifier' -- '*.py' | wc -l
> 62
> $ git grep -n '^# SPDX-License-Identifier' -- '*.py' | \
> cut -f2 -d: | sort | uniq -c
> 32 1
> 27 2
> 3 3
> $ git grep -n '^# SPDX-License-Identifier' -- '*.py' | \
> cut -f1 -d: | xargs ./scripts/spdxcheck.py --verbose
>
> License files: 14
> Exception files: 2
> License IDs 19
> Exception IDs 2
>
> Files checked: 62
> Lines checked: 95
> Files with SPDX: 62
> Files with errors: 0
Not quite sure what you're meant with the above, but:
1) this won't cover all python scripts, as there are some without
.py extension:
$ git grep -lE "\#\!.*python"|grep -v \.py$
drivers/staging/greybus/tools/lbtest
scripts/bloat-o-meter
scripts/diffconfig
scripts/show_delta
tools/hv/lsvmbus
tools/kvm/kvm_stat/kvm_stat
2) we have already some files that are violating PEP-263 due to
SPDX headers. On a quick look at the results of:
$ git grep -lE "^\#.*coding" $(git grep -lE "\#\!.*python")
Documentation/sphinx/kernel_include.py
Documentation/sphinx/rstFlatTable.py
tools/perf/python/tracepoint.py
tools/perf/python/twatch.py
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
Those three files already have such problem:
tools/perf/python/tracepoint.py
tools/perf/python/twatch.py
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
On those scripts, the coding line is not at the right place, and will be
silently ignored by python, causing them to crash with UTF-8 encoding
chars, if any.
And the other two doesn't have a SPDX header file. Adding a SPDX header
there would violate the "up to the second line" rule.
Thanks,
Mauro
prev parent reply other threads:[~2019-09-05 10:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 15:11 [PATCH] media: siano: Use the correct style for SPDX License Identifier Nishad Kamdar
2019-09-04 18:34 ` Mauro Carvalho Chehab
2019-09-04 18:36 ` Greg Kroah-Hartman
2019-09-04 19:00 ` Mauro Carvalho Chehab
2019-09-04 19:26 ` Joe Perches
2019-09-05 5:54 ` Greg Kroah-Hartman
2019-09-05 8:56 ` Mauro Carvalho Chehab
2019-09-05 9:23 ` [PATCH] docs: license-rules.txt: cover SPDX headers on Python scripts Mauro Carvalho Chehab
2019-09-05 9:27 ` Greg Kroah-Hartman
2019-09-05 10:50 ` Mauro Carvalho Chehab
2019-09-05 11:01 ` [PATCH 1/3] docs: sphinx: add SPDX header for some sphinx extensions Mauro Carvalho Chehab
2019-09-05 11:01 ` [PATCH 2/3] tools: perf: fix SPDX header in the light of PEP-263 Mauro Carvalho Chehab
2019-09-05 11:01 ` [PATCH 3/3] tools: intel_pstate_tracer.py: " Mauro Carvalho Chehab
2019-09-05 12:07 ` [PATCH] docs: license-rules.txt: cover SPDX headers on Python scripts Mauro Carvalho Chehab
2019-09-05 17:45 ` Joe Perches
2019-09-06 11:34 ` Mauro Carvalho Chehab
2019-09-06 11:37 ` Mauro Carvalho Chehab
2019-09-06 12:20 ` Joe Perches
2019-09-06 14:45 ` Mauro Carvalho Chehab
2019-09-06 16:20 ` Joe Perches
2019-09-06 17:33 ` Joe Perches
2019-09-06 18:17 ` Mauro Carvalho Chehab
2019-09-06 18:30 ` Joe Perches
2019-09-06 18:12 ` [RFC PATCH] tools: Add SPDX license to man pages Joe Perches
2019-09-06 19:53 ` Mauro Carvalho Chehab
2019-09-05 12:57 ` [PATCH] docs: license-rules.txt: cover SPDX headers on Python scripts Jonathan Corbet
2019-09-05 14:17 ` Greg Kroah-Hartman
2019-09-05 17:10 ` Mauro Carvalho Chehab
2019-09-06 16:41 ` Markus Heiser
2019-09-05 19:28 ` Mauro Carvalho Chehab
2019-09-05 19:40 ` Jonathan Corbet
2019-09-05 20:07 ` Mauro Carvalho Chehab
2019-09-06 15:18 ` Markus Heiser
2019-09-05 9:28 ` [PATCH] media: siano: Use the correct style for SPDX License Identifier Joe Perches
2019-09-05 10:46 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905074658.0f229587@coco.lan \
--to=mchehab@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nishadkamdar@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.