From: Dave Chinner <david@fromorbit.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 1/8 v2] xfs: log race fixes and cleanups
Date: Thu, 5 Sep 2019 18:47:09 +1000 [thread overview]
Message-ID: <20190905084717.30308-1-david@fromorbit.com> (raw)
Hi folks,
This is a followup to the original patchset here:
https://lore.kernel.org/linux-xfs/20190905072856.GE1119@dread.disaster.area/T/#m8ae6bdccbf4248b5d219ad40ab5caa92f9e0a979
It is aimed at solving the hangs occurring in generic/530 and
cleaning up the code around the iclog completion. This version is
largely just changes for review comments, though there is a new
patch (#3) to address what is probably the underlying cause of
all the issues.
Chandan has tested the new unbound workqueue change and it solved
the hang on his test machine, passes all the log group tests on my
test machines.
Cheers,
Dave.
Version 3:
- add patch to yeild the CPU in AGI unlinked list processing and to
allow the CIL push work to be done on any CPU so it doesn't get
stuck on a CPU that isn't being yeilded.
- Added comment to explain the AIL push added to an unsuccessful
wakeup in xlog_grant_head_wake()
- removed "did callbacks" parameter from
xlog_state_callback_check_state and cleaned up comments
- fixed detection of the icloglock being dropped during the iclog
state scan.
- fixed unintended logic change with iclogs in IOERROR state when
factoring out state processing
- other small whitespace and cleanup bits.
next reply other threads:[~2019-09-05 8:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 8:47 Dave Chinner [this message]
2019-09-05 8:47 ` [PATCH 1/8] xfs: push the AIL in xlog_grant_head_wake Dave Chinner
2019-09-05 15:18 ` Darrick J. Wong
2019-09-05 22:02 ` Dave Chinner
2019-09-05 8:47 ` [PATCH 2/8] xfs: fix missed wakeup on l_flush_wait Dave Chinner
2019-09-05 15:21 ` Darrick J. Wong
2019-09-05 8:47 ` [PATCH 3/8] xfs: prevent CIL push holdoff in log recovery Dave Chinner
2019-09-05 15:26 ` Darrick J. Wong
2019-09-05 22:10 ` Dave Chinner
2019-09-05 8:47 ` [PATCH 4/8] xfs: factor debug code out of xlog_state_do_callback() Dave Chinner
2019-09-05 15:30 ` Darrick J. Wong
2019-09-05 22:14 ` Dave Chinner
2019-09-05 8:47 ` [PATCH 5/8] xfs: factor callbacks " Dave Chinner
2019-09-05 15:39 ` Darrick J. Wong
2019-09-05 22:17 ` Dave Chinner
2019-09-05 8:47 ` [PATCH 6/8] xfs: factor iclog state processing " Dave Chinner
2019-09-05 15:45 ` Darrick J. Wong
2019-09-05 8:47 ` [PATCH 7/8] xfs: push iclog state cleaning into xlog_state_clean_log Dave Chinner
2019-09-05 15:48 ` Darrick J. Wong
2019-09-05 22:28 ` Dave Chinner
2019-09-05 8:47 ` [PATCH 8/8] xfs: push the grant head when the log head moves forward Dave Chinner
2019-09-05 16:00 ` Darrick J. Wong
2019-09-05 15:44 ` [PATCH 1/8 v2] xfs: log race fixes and cleanups Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905084717.30308-1-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.