From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC PATCH V2 3/4] media: platform: Add Mediatek FD driver KConfig Date: Thu, 5 Sep 2019 15:30:54 +0300 Message-ID: <20190905123054.GL5035@pendragon.ideasonboard.com> References: <1562661672-22439-1-git-send-email-Jerry-Ch.chen@mediatek.com> <1562661672-22439-4-git-send-email-Jerry-Ch.chen@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1562661672-22439-4-git-send-email-Jerry-Ch.chen@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jerry-ch Chen Cc: devicetree@vger.kernel.org, Sean.Cheng@mediatek.com, laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com, christie.yu@mediatek.com, srv_heupstream@mediatek.com, po-yang.huang@mediatek.com, suleiman@chromium.org, shik@chromium.org, tfiga@chromium.org, jungo.lin@mediatek.com, sj.huang@mediatek.com, yuzhao@chromium.org, hans.verkuil@cisco.com, zwisler@chromium.org, frederic.chen@mediatek.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Jerry, Thank you for the patch. On Tue, Jul 09, 2019 at 04:41:11PM +0800, Jerry-ch Chen wrote: > From: Jerry-ch Chen > > This patch adds KConfig for Mediatek Face Detection driver (FD). > FD is embedded in Mediatek SoCs. It can provide hardware > accelerated face detection function. > > Signed-off-by: Jerry-ch Chen You can squash this patch with 4/4, there's no need to keep it separate. > --- > drivers/media/platform/Kconfig | 2 ++ > drivers/media/platform/mtk-isp/fd/Kconfig | 17 +++++++++++++++++ > 2 files changed, 19 insertions(+) > create mode 100644 drivers/media/platform/mtk-isp/fd/Kconfig > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index a505e9f..ae99258e 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -32,6 +32,8 @@ source "drivers/media/platform/davinci/Kconfig" > > source "drivers/media/platform/omap/Kconfig" > > +source "drivers/media/platform/mtk-isp/fd/Kconfig" > + > config VIDEO_ASPEED > tristate "Aspeed AST2400 and AST2500 Video Engine driver" > depends on VIDEO_V4L2 > diff --git a/drivers/media/platform/mtk-isp/fd/Kconfig b/drivers/media/platform/mtk-isp/fd/Kconfig > new file mode 100644 > index 0000000..0c5eaf0 > --- /dev/null > +++ b/drivers/media/platform/mtk-isp/fd/Kconfig > @@ -0,0 +1,17 @@ > +config VIDEO_MEDIATEK_FD > + bool "Mediatek face detection processing function" > + select DMA_SHARED_BUFFER > + select VIDEOBUF2_DMA_CONTIG > + select VIDEOBUF2_CORE > + select VIDEOBUF2_V4L2 > + select VIDEOBUF2_MEMOPS > + select VIDEOBUF2_VMALLOC Do you need both VIDEOBUF2_DMA_CONTIG and VIDEOBUF2_VMALLOC ? The driver doesn't seem to make use of VIDEOBUF2_VMALLOC. > + select MEDIA_CONTROLLER > + > + default n > + help > + Support the Face Detectioin (FD) feature. s/Detectioin/Detection/ Maybe "... feature found in the Mediatek SoCs." ? > + > + FD driver is a V4L2 memory-to-memory device driver which > + provides hardware accelerated face detection function, > + it can detect different sizes of faces in a raw image. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36A33C3A5A5 for ; Thu, 5 Sep 2019 12:31:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 098E72080C for ; Thu, 5 Sep 2019 12:31:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="lzOsnyIr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389257AbfIEMbE (ORCPT ); Thu, 5 Sep 2019 08:31:04 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:54746 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387432AbfIEMbE (ORCPT ); Thu, 5 Sep 2019 08:31:04 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C344ECC; Thu, 5 Sep 2019 14:31:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1567686661; bh=xcSubn/iQCGjwJ8OJH7HDlSa5Fjf8PeWVmKESKQ8p40=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lzOsnyIrOPL6NFMqF9UISBuYcxDt79qCl/uAKMc6YZIGIIRtLO4Uhm1U2r/qc4x3n WyIvsjFuGJyhKkMwwQv5vKC4/2Hw8GWFs3k7FAiC4eSD3+RDmgIdGnSmYOprlu+fmT IClX+wGvXOHjv4bm62vgi5T45SoZHznzXCpO7JeE= Date: Thu, 5 Sep 2019 15:30:54 +0300 From: Laurent Pinchart To: Jerry-ch Chen Cc: hans.verkuil@cisco.com, laurent.pinchart+renesas@ideasonboard.com, tfiga@chromium.org, matthias.bgg@gmail.com, mchehab@kernel.org, yuzhao@chromium.org, zwisler@chromium.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Sean.Cheng@mediatek.com, sj.huang@mediatek.com, christie.yu@mediatek.com, frederic.chen@mediatek.com, jungo.lin@mediatek.com, Rynn.Wu@mediatek.com, po-yang.huang@mediatek.com, shik@chromium.org, suleiman@chromium.org, linux-media@vger.kernel.org, srv_heupstream@mediatek.com, devicetree@vger.kernel.org Subject: Re: [RFC PATCH V2 3/4] media: platform: Add Mediatek FD driver KConfig Message-ID: <20190905123054.GL5035@pendragon.ideasonboard.com> References: <1562661672-22439-1-git-send-email-Jerry-Ch.chen@mediatek.com> <1562661672-22439-4-git-send-email-Jerry-Ch.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1562661672-22439-4-git-send-email-Jerry-Ch.chen@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Jerry, Thank you for the patch. On Tue, Jul 09, 2019 at 04:41:11PM +0800, Jerry-ch Chen wrote: > From: Jerry-ch Chen > > This patch adds KConfig for Mediatek Face Detection driver (FD). > FD is embedded in Mediatek SoCs. It can provide hardware > accelerated face detection function. > > Signed-off-by: Jerry-ch Chen You can squash this patch with 4/4, there's no need to keep it separate. > --- > drivers/media/platform/Kconfig | 2 ++ > drivers/media/platform/mtk-isp/fd/Kconfig | 17 +++++++++++++++++ > 2 files changed, 19 insertions(+) > create mode 100644 drivers/media/platform/mtk-isp/fd/Kconfig > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index a505e9f..ae99258e 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -32,6 +32,8 @@ source "drivers/media/platform/davinci/Kconfig" > > source "drivers/media/platform/omap/Kconfig" > > +source "drivers/media/platform/mtk-isp/fd/Kconfig" > + > config VIDEO_ASPEED > tristate "Aspeed AST2400 and AST2500 Video Engine driver" > depends on VIDEO_V4L2 > diff --git a/drivers/media/platform/mtk-isp/fd/Kconfig b/drivers/media/platform/mtk-isp/fd/Kconfig > new file mode 100644 > index 0000000..0c5eaf0 > --- /dev/null > +++ b/drivers/media/platform/mtk-isp/fd/Kconfig > @@ -0,0 +1,17 @@ > +config VIDEO_MEDIATEK_FD > + bool "Mediatek face detection processing function" > + select DMA_SHARED_BUFFER > + select VIDEOBUF2_DMA_CONTIG > + select VIDEOBUF2_CORE > + select VIDEOBUF2_V4L2 > + select VIDEOBUF2_MEMOPS > + select VIDEOBUF2_VMALLOC Do you need both VIDEOBUF2_DMA_CONTIG and VIDEOBUF2_VMALLOC ? The driver doesn't seem to make use of VIDEOBUF2_VMALLOC. > + select MEDIA_CONTROLLER > + > + default n > + help > + Support the Face Detectioin (FD) feature. s/Detectioin/Detection/ Maybe "... feature found in the Mediatek SoCs." ? > + > + FD driver is a V4L2 memory-to-memory device driver which > + provides hardware accelerated face detection function, > + it can detect different sizes of faces in a raw image. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E20FEC3A5A5 for ; Thu, 5 Sep 2019 12:31:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B276A2080C for ; Thu, 5 Sep 2019 12:31:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bBp2kUGl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="lzOsnyIr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B276A2080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W2M8Z2hFzWSUKRW6aPlCNkge1VmiRAlgIRgJiikFFXc=; b=bBp2kUGldplQES hW/Nz4gWpmmLr+CY7hlUrrZzAycie5HlOpqKt742+CMrmf7QOXev4/WlqYQ4LxpceKHG0cME+lgLQ mynSmBAOV+Rz99ZsrwCKOdRNGMenELWb2L8kyg0spOQTIS1Q9C3fxO3aHECisek0SpQnNybjIPvK/ 6ol9s+OrLq6xxPm6ntv06TZ4VQbIdugWcDKtjSwzCQcBKac6w2KS+Stt/Urs3B0EZe0jcnYwAADqU 2lHToCEwa9/4Bl0B9Xx85Q/jsE9oYz3K8BKB+NNiwv2ZHEottqjCmbWyEWp5phZXcoFxewikcU5xi 9+0euyJq5Kzp1OLGdfNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5quv-0004Ju-FW; Thu, 05 Sep 2019 12:31:13 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i5qur-0004JB-U9; Thu, 05 Sep 2019 12:31:12 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C344ECC; Thu, 5 Sep 2019 14:31:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1567686661; bh=xcSubn/iQCGjwJ8OJH7HDlSa5Fjf8PeWVmKESKQ8p40=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lzOsnyIrOPL6NFMqF9UISBuYcxDt79qCl/uAKMc6YZIGIIRtLO4Uhm1U2r/qc4x3n WyIvsjFuGJyhKkMwwQv5vKC4/2Hw8GWFs3k7FAiC4eSD3+RDmgIdGnSmYOprlu+fmT IClX+wGvXOHjv4bm62vgi5T45SoZHznzXCpO7JeE= Date: Thu, 5 Sep 2019 15:30:54 +0300 From: Laurent Pinchart To: Jerry-ch Chen Subject: Re: [RFC PATCH V2 3/4] media: platform: Add Mediatek FD driver KConfig Message-ID: <20190905123054.GL5035@pendragon.ideasonboard.com> References: <1562661672-22439-1-git-send-email-Jerry-Ch.chen@mediatek.com> <1562661672-22439-4-git-send-email-Jerry-Ch.chen@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1562661672-22439-4-git-send-email-Jerry-Ch.chen@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190905_053110_131857_53093782 X-CRM114-Status: GOOD ( 14.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sean.Cheng@mediatek.com, laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com, christie.yu@mediatek.com, srv_heupstream@mediatek.com, po-yang.huang@mediatek.com, suleiman@chromium.org, shik@chromium.org, tfiga@chromium.org, jungo.lin@mediatek.com, sj.huang@mediatek.com, yuzhao@chromium.org, hans.verkuil@cisco.com, zwisler@chromium.org, frederic.chen@mediatek.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jerry, Thank you for the patch. On Tue, Jul 09, 2019 at 04:41:11PM +0800, Jerry-ch Chen wrote: > From: Jerry-ch Chen > > This patch adds KConfig for Mediatek Face Detection driver (FD). > FD is embedded in Mediatek SoCs. It can provide hardware > accelerated face detection function. > > Signed-off-by: Jerry-ch Chen You can squash this patch with 4/4, there's no need to keep it separate. > --- > drivers/media/platform/Kconfig | 2 ++ > drivers/media/platform/mtk-isp/fd/Kconfig | 17 +++++++++++++++++ > 2 files changed, 19 insertions(+) > create mode 100644 drivers/media/platform/mtk-isp/fd/Kconfig > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index a505e9f..ae99258e 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -32,6 +32,8 @@ source "drivers/media/platform/davinci/Kconfig" > > source "drivers/media/platform/omap/Kconfig" > > +source "drivers/media/platform/mtk-isp/fd/Kconfig" > + > config VIDEO_ASPEED > tristate "Aspeed AST2400 and AST2500 Video Engine driver" > depends on VIDEO_V4L2 > diff --git a/drivers/media/platform/mtk-isp/fd/Kconfig b/drivers/media/platform/mtk-isp/fd/Kconfig > new file mode 100644 > index 0000000..0c5eaf0 > --- /dev/null > +++ b/drivers/media/platform/mtk-isp/fd/Kconfig > @@ -0,0 +1,17 @@ > +config VIDEO_MEDIATEK_FD > + bool "Mediatek face detection processing function" > + select DMA_SHARED_BUFFER > + select VIDEOBUF2_DMA_CONTIG > + select VIDEOBUF2_CORE > + select VIDEOBUF2_V4L2 > + select VIDEOBUF2_MEMOPS > + select VIDEOBUF2_VMALLOC Do you need both VIDEOBUF2_DMA_CONTIG and VIDEOBUF2_VMALLOC ? The driver doesn't seem to make use of VIDEOBUF2_VMALLOC. > + select MEDIA_CONTROLLER > + > + default n > + help > + Support the Face Detectioin (FD) feature. s/Detectioin/Detection/ Maybe "... feature found in the Mediatek SoCs." ? > + > + FD driver is a V4L2 memory-to-memory device driver which > + provides hardware accelerated face detection function, > + it can detect different sizes of faces in a raw image. -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel