From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82B14C43331 for ; Thu, 5 Sep 2019 14:20:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 956C1207E0 for ; Thu, 5 Sep 2019 14:20:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732612AbfIEOU2 (ORCPT ); Thu, 5 Sep 2019 10:20:28 -0400 Received: from foss.arm.com ([217.140.110.172]:46002 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725290AbfIEOU1 (ORCPT ); Thu, 5 Sep 2019 10:20:27 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3188528; Thu, 5 Sep 2019 07:20:27 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 494B93F67D; Thu, 5 Sep 2019 07:20:26 -0700 (PDT) Date: Thu, 5 Sep 2019 15:20:24 +0100 From: Dave Martin To: Cristian Marussi Cc: amit.kachhap@arm.com, andreyknvl@google.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 09/11] kselftest: arm64: fake_sigreturn_duplicated_fpsimd Message-ID: <20190905142023.GF27757@arm.com> References: <20190902112932.36129-1-cristian.marussi@arm.com> <20190902112932.36129-10-cristian.marussi@arm.com> <20190904114923.GZ27757@arm.com> <20190905123904.GD27757@arm.com> <365b527e-793e-ad83-47a8-5d8692ed50c4@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <365b527e-793e-ad83-47a8-5d8692ed50c4@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, Sep 05, 2019 at 02:32:09PM +0100, Cristian Marussi wrote: > On 05/09/2019 13:39, Dave Martin wrote: > > On Thu, Sep 05, 2019 at 01:15:58PM +0100, Cristian Marussi wrote: > >> Hi > >> > >> On 04/09/2019 12:49, Dave Martin wrote: > >>> On Mon, Sep 02, 2019 at 12:29:30pm +0100, Cristian Marussi wrote: > >>>> Add a simple fake_sigreturn testcase which builds a ucontext_t with > >>>> an anomalous additional fpsimd_context and place it onto the stack. > >>>> Expects a SIGSEGV on test PASS. > >>>> > >>>> Signed-off-by: Cristian Marussi > >>>> --- > >>>> v3 --> v4 > >>>> - fix commit > >>>> - missing include > >>>> - using new get_starting_head() helper > >>>> - added test description > >>>> --- > >>>> .../fake_sigreturn_duplicated_fpsimd.c | 52 +++++++++++++++++++ > >>>> 1 file changed, 52 insertions(+) > >>>> create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c > >>>> > >>>> diff --git a/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c > >>>> new file mode 100644 > >>>> index 000000000000..c7122c44f53f > >>>> --- /dev/null > >>>> +++ b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c > >>>> @@ -0,0 +1,52 @@ > >>>> +// SPDX-License-Identifier: GPL-2.0 > >>>> +/* > >>>> + * Copyright (C) 2019 ARM Limited > >>>> + * > >>>> + * Place a fake sigframe on the stack including an additional FPSIMD > >>>> + * record: on sigreturn Kernel must spot this attempt and the test > >>>> + * case is expected to be terminated via SEGV. > >>>> + */ > >>>> + > >>>> +#include > >>>> +#include > >>>> + > >>>> +#include "test_signals_utils.h" > >>>> +#include "testcases.h" > >>>> + > >>>> +struct fake_sigframe sf; > >>>> + > >>>> +static int fake_sigreturn_duplicated_fpsimd_run(struct tdescr *td, > >>>> + siginfo_t *si, ucontext_t *uc) > >>>> +{ > >>>> + size_t resv_sz, need_sz; > >>>> + struct _aarch64_ctx *shead = GET_SF_RESV_HEAD(sf), *head; > >>>> + > >>>> + /* just to fill the ucontext_t with something real */ > >>>> + if (!get_current_context(td, &sf.uc)) > >>>> + return 1; > >>>> + > >>>> + resv_sz = GET_SF_RESV_SIZE(sf); > >>>> + need_sz = HDR_SZ + sizeof(struct fpsimd_context); > >>> > >>> Nit: Maybe write this sum in the same order as the records we're going > >>> o append, i.e.: > >>> > >>> need_sz = sizeof(struct fpsimd_context) + HDR_SZ; /* for terminator */ > >> > >> Ok > >> > >>> > >>> Also, maybe fail this test if there is no fpsimd_context in the initial > >>> frame from get_current_context(): that would be a kernel bug, but we > >>> wouldn't be giving fake_sigreturn() duplicate fpsimd_contexts in that > >>> case -- so this test wouldn't test the thing it's supposed to test. > >>> > >> > >> Any context grabbed by get_current_context() is verified at first to be sane > >> when is copied in the handler by ASSERT_GOOD_CONTEXT() > >> > >>> } else if (signum == sig_copyctx && current->live_uc) { > >>> memcpy(current->live_uc, uc, current->live_sz); > >>> ASSERT_GOOD_CONTEXT(current->live_uc); > >>> current->live_uc_valid = 1; > >> > >> A missing fpsimd in the original sigframe would lead to an abort() > >> straight away while preparing the test, and the test will fail. > > > > OK, but there is no abort() in ASSERT_GOOD_CONTEXT(), only assert(0). > > Can you add an abort() after the assert() in there in patch 2? > > > Ok yes, I meant the abort coming from assert(0) in fact....I'll review all > the critical asserts for additional aborts in V6 OK -- I guess this only matters for things that should be reported as test failures. Things that are purely bugs in the test are less of a concern. Cheers ---Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67212C43331 for ; Thu, 5 Sep 2019 14:20:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 697C8206A5 for ; Thu, 5 Sep 2019 14:20:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EZf0cZeO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 697C8206A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8chSlpvETX9BwEygfio7yjRmCKzjr2bowDkCtSqZC5g=; b=EZf0cZeOmq8Ce9 P3CDyqfb/cdI3TpMkfZgc9AFvnt04zBAehlvYP+oMXbBcB8IM6lofgb7o4dWFKS2G3pXNdN7JijA6 H3Nh/jAJ85gxnQI2a7SOVWubGaYQF8c1A2LXv9j2+EjrZUcifG4Bw8xkN3GfVxWFfZ2lunSlzAqvJ QWmu2VDlXujFRX7hxujwGdB3QFHfmMM+pFavkBIyIJsk7d1v+K8w6s3Wnb/+rt4Q/X2Rv/u8X9HnV bA1oNVY56Med7GNz0EaRSpEK6aLso7XbLR8P0tb/Ig2/EBdDcIHPBS1kDfmFbqClG6vCsf4ncxLp/ 6s3DuVgce4g3yEZO3Usg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5sch-0005GZ-18; Thu, 05 Sep 2019 14:20:31 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5sce-0005GD-7P for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2019 14:20:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3188528; Thu, 5 Sep 2019 07:20:27 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 494B93F67D; Thu, 5 Sep 2019 07:20:26 -0700 (PDT) Date: Thu, 5 Sep 2019 15:20:24 +0100 From: Dave Martin To: Cristian Marussi Subject: Re: [PATCH v5 09/11] kselftest: arm64: fake_sigreturn_duplicated_fpsimd Message-ID: <20190905142023.GF27757@arm.com> References: <20190902112932.36129-1-cristian.marussi@arm.com> <20190902112932.36129-10-cristian.marussi@arm.com> <20190904114923.GZ27757@arm.com> <20190905123904.GD27757@arm.com> <365b527e-793e-ad83-47a8-5d8692ed50c4@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <365b527e-793e-ad83-47a8-5d8692ed50c4@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190905_072028_356933_2625F6BE X-CRM114-Status: GOOD ( 21.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amit.kachhap@arm.com, andreyknvl@google.com, shuah@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 05, 2019 at 02:32:09PM +0100, Cristian Marussi wrote: > On 05/09/2019 13:39, Dave Martin wrote: > > On Thu, Sep 05, 2019 at 01:15:58PM +0100, Cristian Marussi wrote: > >> Hi > >> > >> On 04/09/2019 12:49, Dave Martin wrote: > >>> On Mon, Sep 02, 2019 at 12:29:30pm +0100, Cristian Marussi wrote: > >>>> Add a simple fake_sigreturn testcase which builds a ucontext_t with > >>>> an anomalous additional fpsimd_context and place it onto the stack. > >>>> Expects a SIGSEGV on test PASS. > >>>> > >>>> Signed-off-by: Cristian Marussi > >>>> --- > >>>> v3 --> v4 > >>>> - fix commit > >>>> - missing include > >>>> - using new get_starting_head() helper > >>>> - added test description > >>>> --- > >>>> .../fake_sigreturn_duplicated_fpsimd.c | 52 +++++++++++++++++++ > >>>> 1 file changed, 52 insertions(+) > >>>> create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c > >>>> > >>>> diff --git a/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c > >>>> new file mode 100644 > >>>> index 000000000000..c7122c44f53f > >>>> --- /dev/null > >>>> +++ b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c > >>>> @@ -0,0 +1,52 @@ > >>>> +// SPDX-License-Identifier: GPL-2.0 > >>>> +/* > >>>> + * Copyright (C) 2019 ARM Limited > >>>> + * > >>>> + * Place a fake sigframe on the stack including an additional FPSIMD > >>>> + * record: on sigreturn Kernel must spot this attempt and the test > >>>> + * case is expected to be terminated via SEGV. > >>>> + */ > >>>> + > >>>> +#include > >>>> +#include > >>>> + > >>>> +#include "test_signals_utils.h" > >>>> +#include "testcases.h" > >>>> + > >>>> +struct fake_sigframe sf; > >>>> + > >>>> +static int fake_sigreturn_duplicated_fpsimd_run(struct tdescr *td, > >>>> + siginfo_t *si, ucontext_t *uc) > >>>> +{ > >>>> + size_t resv_sz, need_sz; > >>>> + struct _aarch64_ctx *shead = GET_SF_RESV_HEAD(sf), *head; > >>>> + > >>>> + /* just to fill the ucontext_t with something real */ > >>>> + if (!get_current_context(td, &sf.uc)) > >>>> + return 1; > >>>> + > >>>> + resv_sz = GET_SF_RESV_SIZE(sf); > >>>> + need_sz = HDR_SZ + sizeof(struct fpsimd_context); > >>> > >>> Nit: Maybe write this sum in the same order as the records we're going > >>> o append, i.e.: > >>> > >>> need_sz = sizeof(struct fpsimd_context) + HDR_SZ; /* for terminator */ > >> > >> Ok > >> > >>> > >>> Also, maybe fail this test if there is no fpsimd_context in the initial > >>> frame from get_current_context(): that would be a kernel bug, but we > >>> wouldn't be giving fake_sigreturn() duplicate fpsimd_contexts in that > >>> case -- so this test wouldn't test the thing it's supposed to test. > >>> > >> > >> Any context grabbed by get_current_context() is verified at first to be sane > >> when is copied in the handler by ASSERT_GOOD_CONTEXT() > >> > >>> } else if (signum == sig_copyctx && current->live_uc) { > >>> memcpy(current->live_uc, uc, current->live_sz); > >>> ASSERT_GOOD_CONTEXT(current->live_uc); > >>> current->live_uc_valid = 1; > >> > >> A missing fpsimd in the original sigframe would lead to an abort() > >> straight away while preparing the test, and the test will fail. > > > > OK, but there is no abort() in ASSERT_GOOD_CONTEXT(), only assert(0). > > Can you add an abort() after the assert() in there in patch 2? > > > Ok yes, I meant the abort coming from assert(0) in fact....I'll review all > the critical asserts for additional aborts in V6 OK -- I guess this only matters for things that should be reported as test failures. Things that are purely bugs in the test are less of a concern. Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel