From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aleksa Sarai Date: Thu, 05 Sep 2019 17:01:06 +0000 Subject: Re: [PATCH v12 01/12] lib: introduce copy_struct_{to,from}_user helpers Message-Id: <20190905170106.7j4nmgwnvkcwn6md@yavin.dot.cyphar.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="kmvm5dxbzyhfjvqj" List-Id: References: <20190904201933.10736-1-cyphar@cyphar.com> <20190904201933.10736-2-cyphar@cyphar.com> <20190905073205.GY2332@hirez.programming.kicks-ass.net> <20190905092622.tlb6nn3uisssdfbu@yavin.dot.cyphar.com> <20190905094305.GJ2349@hirez.programming.kicks-ass.net> In-Reply-To: <20190905094305.GJ2349@hirez.programming.kicks-ass.net> To: Peter Zijlstra Cc: Al Viro , Jeff Layton , "J. Bruce Fields" , Arnd Bergmann , David Howells , Shuah Khan , Shuah Khan , Ingo Molnar , Christian Brauner , Rasmus Villemoes , Eric Biederman , Andy Lutomirski , Andrew Morton , Alexei Starovoitov , Kees Cook , Jann Horn , Tycho Andersen , David Drysdale , Chanho Min , Oleg Nesterov , Alexander --kmvm5dxbzyhfjvqj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2019-09-05, Peter Zijlstra wrote: > On Thu, Sep 05, 2019 at 07:26:22PM +1000, Aleksa Sarai wrote: > > On 2019-09-05, Peter Zijlstra wrote: > > > On Thu, Sep 05, 2019 at 06:19:22AM +1000, Aleksa Sarai wrote: > > > > + > > > > + while (rest > 0) { > > > > + size_t bufsize =3D min(rest, sizeof(buffer)); > > > > + > > > > + if (__copy_from_user(buffer, addr, bufsize)) > > > > + return -EFAULT; > > > > + if (memchr_inv(buffer, 0, bufsize)) > > > > + return -E2BIG; > > > > + > > > > + addr +=3D bufsize; > > > > + rest -=3D bufsize; > > > > + } > > >=20 > > > The perf implementation uses get_user(); but if that is too slow, sur= ely > > > we can do something with uaccess_try() here? > >=20 > > Is there a non-x86-specific way to do that (unless I'm mistaken only x86 > > has uaccess_try() or the other *_try() wrappers)? The main "performance > > improvement" (if you can even call it that) is that we use memchr_inv() > > which finds non-matching characters more efficiently than just doing a > > loop. >=20 > Oh, you're right, that's x86 only :/ Though, I just had an idea -- am I wrong to think that the following would work just as well (without the need for an intermediate buffer)? if (memchr_inv((const char __force *) src + size, 0, rest)) return -E2BIG; Or is this type of thing very much frowned upon? What if it was a separate memchr_inv_user() instead -- I feel as though there's not a strong argument for needing to use a buffer when we're single-passing the __user buffer and doing a basic boolean check. --=20 Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH --kmvm5dxbzyhfjvqj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSxZm6dtfE8gxLLfYqdlLljIbnQEgUCXXE/TgAKCRCdlLljIbnQ Eo4lAP4vz7qxi6aZbZTeed0ZbnEtPkuMnCkFo0v18rHfgnM6xgD/bV/SICkzrufH DwNHgRAu5z8daivqeybakfQqvQMhpA4= =SteT -----END PGP SIGNATURE----- --kmvm5dxbzyhfjvqj-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 905B6C43331 for ; Thu, 5 Sep 2019 17:01:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D1A920825 for ; Thu, 5 Sep 2019 17:01:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390917AbfIERBl (ORCPT ); Thu, 5 Sep 2019 13:01:41 -0400 Received: from mx2.mailbox.org ([80.241.60.215]:61604 "EHLO mx2.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733299AbfIERBk (ORCPT ); Thu, 5 Sep 2019 13:01:40 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id A0FCBA01CE; Thu, 5 Sep 2019 19:01:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter05.heinlein-hosting.de (spamfilter05.heinlein-hosting.de [80.241.56.123]) (amavisd-new, port 10030) with ESMTP id l96lis2EinZ8; Thu, 5 Sep 2019 19:01:30 +0200 (CEST) Date: Fri, 6 Sep 2019 03:01:06 +1000 From: Aleksa Sarai To: Peter Zijlstra Cc: Al Viro , Jeff Layton , "J. Bruce Fields" , Arnd Bergmann , David Howells , Shuah Khan , Shuah Khan , Ingo Molnar , Christian Brauner , Rasmus Villemoes , Eric Biederman , Andy Lutomirski , Andrew Morton , Alexei Starovoitov , Kees Cook , Jann Horn , Tycho Andersen , David Drysdale , Chanho Min , Oleg Nesterov , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Aleksa Sarai , Linus Torvalds , containers@lists.linux-foundation.org, linux-alpha@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v12 01/12] lib: introduce copy_struct_{to,from}_user helpers Message-ID: <20190905170106.7j4nmgwnvkcwn6md@yavin.dot.cyphar.com> References: <20190904201933.10736-1-cyphar@cyphar.com> <20190904201933.10736-2-cyphar@cyphar.com> <20190905073205.GY2332@hirez.programming.kicks-ass.net> <20190905092622.tlb6nn3uisssdfbu@yavin.dot.cyphar.com> <20190905094305.GJ2349@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kmvm5dxbzyhfjvqj" Content-Disposition: inline In-Reply-To: <20190905094305.GJ2349@hirez.programming.kicks-ass.net> Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org --kmvm5dxbzyhfjvqj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2019-09-05, Peter Zijlstra wrote: > On Thu, Sep 05, 2019 at 07:26:22PM +1000, Aleksa Sarai wrote: > > On 2019-09-05, Peter Zijlstra wrote: > > > On Thu, Sep 05, 2019 at 06:19:22AM +1000, Aleksa Sarai wrote: > > > > + > > > > + while (rest > 0) { > > > > + size_t bufsize =3D min(rest, sizeof(buffer)); > > > > + > > > > + if (__copy_from_user(buffer, addr, bufsize)) > > > > + return -EFAULT; > > > > + if (memchr_inv(buffer, 0, bufsize)) > > > > + return -E2BIG; > > > > + > > > > + addr +=3D bufsize; > > > > + rest -=3D bufsize; > > > > + } > > >=20 > > > The perf implementation uses get_user(); but if that is too slow, sur= ely > > > we can do something with uaccess_try() here? > >=20 > > Is there a non-x86-specific way to do that (unless I'm mistaken only x86 > > has uaccess_try() or the other *_try() wrappers)? The main "performance > > improvement" (if you can even call it that) is that we use memchr_inv() > > which finds non-matching characters more efficiently than just doing a > > loop. >=20 > Oh, you're right, that's x86 only :/ Though, I just had an idea -- am I wrong to think that the following would work just as well (without the need for an intermediate buffer)? if (memchr_inv((const char __force *) src + size, 0, rest)) return -E2BIG; Or is this type of thing very much frowned upon? What if it was a separate memchr_inv_user() instead -- I feel as though there's not a strong argument for needing to use a buffer when we're single-passing the __user buffer and doing a basic boolean check. --=20 Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH --kmvm5dxbzyhfjvqj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSxZm6dtfE8gxLLfYqdlLljIbnQEgUCXXE/TgAKCRCdlLljIbnQ Eo4lAP4vz7qxi6aZbZTeed0ZbnEtPkuMnCkFo0v18rHfgnM6xgD/bV/SICkzrufH DwNHgRAu5z8daivqeybakfQqvQMhpA4= =SteT -----END PGP SIGNATURE----- --kmvm5dxbzyhfjvqj-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aleksa Sarai Subject: Re: [PATCH v12 01/12] lib: introduce copy_struct_{to,from}_user helpers Date: Fri, 6 Sep 2019 03:01:06 +1000 Message-ID: <20190905170106.7j4nmgwnvkcwn6md@yavin.dot.cyphar.com> References: <20190904201933.10736-1-cyphar@cyphar.com> <20190904201933.10736-2-cyphar@cyphar.com> <20190905073205.GY2332@hirez.programming.kicks-ass.net> <20190905092622.tlb6nn3uisssdfbu@yavin.dot.cyphar.com> <20190905094305.GJ2349@hirez.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kmvm5dxbzyhfjvqj" Return-path: Content-Disposition: inline In-Reply-To: <20190905094305.GJ2349@hirez.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org To: Peter Zijlstra Cc: Al Viro , Jeff Layton , "J. Bruce Fields" , Arnd Bergmann , David Howells , Shuah Khan , Shuah Khan , Ingo Molnar , Christian Brauner , Rasmus Villemoes , Eric Biederman , Andy Lutomirski , Andrew Morton , Alexei Starovoitov , Kees Cook , Jann Horn , Tycho Andersen , David Drysdale , Chanho Min , Oleg Nesterov , Alexander List-Id: linux-api@vger.kernel.org --kmvm5dxbzyhfjvqj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2019-09-05, Peter Zijlstra wrote: > On Thu, Sep 05, 2019 at 07:26:22PM +1000, Aleksa Sarai wrote: > > On 2019-09-05, Peter Zijlstra wrote: > > > On Thu, Sep 05, 2019 at 06:19:22AM +1000, Aleksa Sarai wrote: > > > > + > > > > + while (rest > 0) { > > > > + size_t bufsize =3D min(rest, sizeof(buffer)); > > > > + > > > > + if (__copy_from_user(buffer, addr, bufsize)) > > > > + return -EFAULT; > > > > + if (memchr_inv(buffer, 0, bufsize)) > > > > + return -E2BIG; > > > > + > > > > + addr +=3D bufsize; > > > > + rest -=3D bufsize; > > > > + } > > >=20 > > > The perf implementation uses get_user(); but if that is too slow, sur= ely > > > we can do something with uaccess_try() here? > >=20 > > Is there a non-x86-specific way to do that (unless I'm mistaken only x86 > > has uaccess_try() or the other *_try() wrappers)? The main "performance > > improvement" (if you can even call it that) is that we use memchr_inv() > > which finds non-matching characters more efficiently than just doing a > > loop. >=20 > Oh, you're right, that's x86 only :/ Though, I just had an idea -- am I wrong to think that the following would work just as well (without the need for an intermediate buffer)? if (memchr_inv((const char __force *) src + size, 0, rest)) return -E2BIG; Or is this type of thing very much frowned upon? What if it was a separate memchr_inv_user() instead -- I feel as though there's not a strong argument for needing to use a buffer when we're single-passing the __user buffer and doing a basic boolean check. --=20 Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH --kmvm5dxbzyhfjvqj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSxZm6dtfE8gxLLfYqdlLljIbnQEgUCXXE/TgAKCRCdlLljIbnQ Eo4lAP4vz7qxi6aZbZTeed0ZbnEtPkuMnCkFo0v18rHfgnM6xgD/bV/SICkzrufH DwNHgRAu5z8daivqeybakfQqvQMhpA4= =SteT -----END PGP SIGNATURE----- --kmvm5dxbzyhfjvqj-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CEC0C43331 for ; Thu, 5 Sep 2019 17:04:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47366206A3 for ; Thu, 5 Sep 2019 17:04:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47366206A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cyphar.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46PRqN57GTzDr0k for ; Fri, 6 Sep 2019 03:04:00 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=cyphar.com (client-ip=80.241.60.215; helo=mx2.mailbox.org; envelope-from=cyphar@cyphar.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=cyphar.com Received: from mx2.mailbox.org (mx2.mailbox.org [80.241.60.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46PRmn6tpmzDqyv for ; Fri, 6 Sep 2019 03:01:42 +1000 (AEST) Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id A0FCBA01CE; Thu, 5 Sep 2019 19:01:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter05.heinlein-hosting.de (spamfilter05.heinlein-hosting.de [80.241.56.123]) (amavisd-new, port 10030) with ESMTP id l96lis2EinZ8; Thu, 5 Sep 2019 19:01:30 +0200 (CEST) Date: Fri, 6 Sep 2019 03:01:06 +1000 From: Aleksa Sarai To: Peter Zijlstra Subject: Re: [PATCH v12 01/12] lib: introduce copy_struct_{to,from}_user helpers Message-ID: <20190905170106.7j4nmgwnvkcwn6md@yavin.dot.cyphar.com> References: <20190904201933.10736-1-cyphar@cyphar.com> <20190904201933.10736-2-cyphar@cyphar.com> <20190905073205.GY2332@hirez.programming.kicks-ass.net> <20190905092622.tlb6nn3uisssdfbu@yavin.dot.cyphar.com> <20190905094305.GJ2349@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kmvm5dxbzyhfjvqj" Content-Disposition: inline In-Reply-To: <20190905094305.GJ2349@hirez.programming.kicks-ass.net> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Alexander Shishkin , Rasmus Villemoes , Alexei Starovoitov , linux-kernel@vger.kernel.org, David Howells , linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, Jiri Olsa , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Tycho Andersen , Aleksa Sarai , Shuah Khan , Ingo Molnar , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-xtensa@linux-xtensa.org, Kees Cook , Arnd Bergmann , Jann Horn , linuxppc-dev@lists.ozlabs.org, linux-m68k@lists.linux-m68k.org, Al Viro , Andy Lutomirski , Shuah Khan , Namhyung Kim , David Drysdale , Christian Brauner , "J. Bruce Fields" , linux-parisc@vger.kernel.org, linux-api@vger.kernel.org, Chanho Min , Jeff Layton , Oleg Nesterov , Eric Biederman , linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Linus Torvalds , containers@lists.linux-foundation.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" --kmvm5dxbzyhfjvqj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2019-09-05, Peter Zijlstra wrote: > On Thu, Sep 05, 2019 at 07:26:22PM +1000, Aleksa Sarai wrote: > > On 2019-09-05, Peter Zijlstra wrote: > > > On Thu, Sep 05, 2019 at 06:19:22AM +1000, Aleksa Sarai wrote: > > > > + > > > > + while (rest > 0) { > > > > + size_t bufsize =3D min(rest, sizeof(buffer)); > > > > + > > > > + if (__copy_from_user(buffer, addr, bufsize)) > > > > + return -EFAULT; > > > > + if (memchr_inv(buffer, 0, bufsize)) > > > > + return -E2BIG; > > > > + > > > > + addr +=3D bufsize; > > > > + rest -=3D bufsize; > > > > + } > > >=20 > > > The perf implementation uses get_user(); but if that is too slow, sur= ely > > > we can do something with uaccess_try() here? > >=20 > > Is there a non-x86-specific way to do that (unless I'm mistaken only x86 > > has uaccess_try() or the other *_try() wrappers)? The main "performance > > improvement" (if you can even call it that) is that we use memchr_inv() > > which finds non-matching characters more efficiently than just doing a > > loop. >=20 > Oh, you're right, that's x86 only :/ Though, I just had an idea -- am I wrong to think that the following would work just as well (without the need for an intermediate buffer)? if (memchr_inv((const char __force *) src + size, 0, rest)) return -E2BIG; Or is this type of thing very much frowned upon? What if it was a separate memchr_inv_user() instead -- I feel as though there's not a strong argument for needing to use a buffer when we're single-passing the __user buffer and doing a basic boolean check. --=20 Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH --kmvm5dxbzyhfjvqj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSxZm6dtfE8gxLLfYqdlLljIbnQEgUCXXE/TgAKCRCdlLljIbnQ Eo4lAP4vz7qxi6aZbZTeed0ZbnEtPkuMnCkFo0v18rHfgnM6xgD/bV/SICkzrufH DwNHgRAu5z8daivqeybakfQqvQMhpA4= =SteT -----END PGP SIGNATURE----- --kmvm5dxbzyhfjvqj-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAAADC43331 for ; Thu, 5 Sep 2019 17:01:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 889F220828 for ; Thu, 5 Sep 2019 17:02:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K3J6Rtys" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 889F220828 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cyphar.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qU/DWwIwGZDL9qd9bhb1hS1DXCIqdBMBrCtDuj7f3sg=; b=K3J6RtysydTVapd8y3RhIIAWM UzPkn5np+6ox+6GC9DZust85U/Q1N1uIBvG9oIUP22n3ICWr/Gxi8AI5sEUdLHSIqhvFANlnOqIxK yFDcfBlM/1y3uFd8huEiEhgrKQVVcoW+hMzRBJZgoHte2gXCSPKkGXlgydtKbr9kZ4Wf75AeyiBCZ BtG4CUiQ5Qf7Sqq+zNugroMdNAKAkKi5CDa8ACx1r5JMBmLLnC9He4jAfiF/SzckzqM7tErxQk1Gq UUsoVzpRrH5wRCzKa5t+4dSAbFABcQQCYpzyCW798ndYX8s2aOBMew5U+PNRmG0EklQE0uTFBZ05m lgB0Kf8uQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5v8l-00049P-BA; Thu, 05 Sep 2019 17:01:47 +0000 Received: from mx2.mailbox.org ([80.241.60.215]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i5v8g-00048F-V6 for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2019 17:01:45 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id A0FCBA01CE; Thu, 5 Sep 2019 19:01:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter05.heinlein-hosting.de (spamfilter05.heinlein-hosting.de [80.241.56.123]) (amavisd-new, port 10030) with ESMTP id l96lis2EinZ8; Thu, 5 Sep 2019 19:01:30 +0200 (CEST) Date: Fri, 6 Sep 2019 03:01:06 +1000 From: Aleksa Sarai To: Peter Zijlstra Subject: Re: [PATCH v12 01/12] lib: introduce copy_struct_{to,from}_user helpers Message-ID: <20190905170106.7j4nmgwnvkcwn6md@yavin.dot.cyphar.com> References: <20190904201933.10736-1-cyphar@cyphar.com> <20190904201933.10736-2-cyphar@cyphar.com> <20190905073205.GY2332@hirez.programming.kicks-ass.net> <20190905092622.tlb6nn3uisssdfbu@yavin.dot.cyphar.com> <20190905094305.GJ2349@hirez.programming.kicks-ass.net> MIME-Version: 1.0 In-Reply-To: <20190905094305.GJ2349@hirez.programming.kicks-ass.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190905_100143_310992_02C88678 X-CRM114-Status: GOOD ( 17.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Alexander Shishkin , Rasmus Villemoes , Alexei Starovoitov , linux-kernel@vger.kernel.org, David Howells , linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, Jiri Olsa , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Tycho Andersen , Aleksa Sarai , Shuah Khan , Ingo Molnar , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-xtensa@linux-xtensa.org, Kees Cook , Arnd Bergmann , Jann Horn , linuxppc-dev@lists.ozlabs.org, linux-m68k@lists.linux-m68k.org, Al Viro , Andy Lutomirski , Shuah Khan , Namhyung Kim , David Drysdale , Christian Brauner , "J. Bruce Fields" , linux-parisc@vger.kernel.org, linux-api@vger.kernel.org, Chanho Min , Jeff Layton , Oleg Nesterov , Eric Biederman , linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Linus Torvalds , containers@lists.linux-foundation.org Content-Type: multipart/mixed; boundary="===============9108544654706145243==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============9108544654706145243== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kmvm5dxbzyhfjvqj" Content-Disposition: inline --kmvm5dxbzyhfjvqj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2019-09-05, Peter Zijlstra wrote: > On Thu, Sep 05, 2019 at 07:26:22PM +1000, Aleksa Sarai wrote: > > On 2019-09-05, Peter Zijlstra wrote: > > > On Thu, Sep 05, 2019 at 06:19:22AM +1000, Aleksa Sarai wrote: > > > > + > > > > + while (rest > 0) { > > > > + size_t bufsize =3D min(rest, sizeof(buffer)); > > > > + > > > > + if (__copy_from_user(buffer, addr, bufsize)) > > > > + return -EFAULT; > > > > + if (memchr_inv(buffer, 0, bufsize)) > > > > + return -E2BIG; > > > > + > > > > + addr +=3D bufsize; > > > > + rest -=3D bufsize; > > > > + } > > >=20 > > > The perf implementation uses get_user(); but if that is too slow, sur= ely > > > we can do something with uaccess_try() here? > >=20 > > Is there a non-x86-specific way to do that (unless I'm mistaken only x86 > > has uaccess_try() or the other *_try() wrappers)? The main "performance > > improvement" (if you can even call it that) is that we use memchr_inv() > > which finds non-matching characters more efficiently than just doing a > > loop. >=20 > Oh, you're right, that's x86 only :/ Though, I just had an idea -- am I wrong to think that the following would work just as well (without the need for an intermediate buffer)? if (memchr_inv((const char __force *) src + size, 0, rest)) return -E2BIG; Or is this type of thing very much frowned upon? What if it was a separate memchr_inv_user() instead -- I feel as though there's not a strong argument for needing to use a buffer when we're single-passing the __user buffer and doing a basic boolean check. --=20 Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH --kmvm5dxbzyhfjvqj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSxZm6dtfE8gxLLfYqdlLljIbnQEgUCXXE/TgAKCRCdlLljIbnQ Eo4lAP4vz7qxi6aZbZTeed0ZbnEtPkuMnCkFo0v18rHfgnM6xgD/bV/SICkzrufH DwNHgRAu5z8daivqeybakfQqvQMhpA4= =SteT -----END PGP SIGNATURE----- --kmvm5dxbzyhfjvqj-- --===============9108544654706145243== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============9108544654706145243==--