From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22B0EC43331 for ; Fri, 6 Sep 2019 10:36:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECD56208C3 for ; Fri, 6 Sep 2019 10:36:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="lMlPK/x/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726692AbfIFKgL (ORCPT ); Fri, 6 Sep 2019 06:36:11 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:54780 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725846AbfIFKgK (ORCPT ); Fri, 6 Sep 2019 06:36:10 -0400 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B610A542; Fri, 6 Sep 2019 12:36:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1567766168; bh=xZiG8amnbavjUvBRgBuawwGqMM3tIIHucSeSpXkq3B8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lMlPK/x/Qb4YoaeoyNugw2rQK9KxCRs6az2tWlBE2IWLsBqM2o6isIMSV2cuO4BZp BEaF73Kpe/W7z5+Q7ZQv/ObAGut7jeTsIXdoeVjM4N4Px97ZyUbxrrEfFcYwyRkAGQ o0OSJHmL2OGZwiVKdKJE4GrIErEabnfxu9cIqbPg= Date: Fri, 6 Sep 2019 13:36:02 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: zhengbin , mchehab@kernel.org, linux-media@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH v2] media: mc-device.c: fix memleak in media_device_register_entity Message-ID: <20190906103602.GA5028@pendragon.ideasonboard.com> References: <1566179490-15413-1-git-send-email-zhengbin13@huawei.com> <20190906091203.GB5019@pendragon.ideasonboard.com> <20190906101134.GK5475@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190906101134.GK5475@paasikivi.fi.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Sakari, On Fri, Sep 06, 2019 at 01:11:34PM +0300, Sakari Ailus wrote: > On Fri, Sep 06, 2019 at 12:12:03PM +0300, Laurent Pinchart wrote: > > On Mon, Aug 19, 2019 at 09:51:30AM +0800, zhengbin wrote: > > > In media_device_register_entity, if media_graph_walk_init fails, > > > need to free the previously memory. > > > > > > Reported-by: Hulk Robot > > > Signed-off-by: zhengbin > > > > This looks good to me. > > > > Reviewed-by: Laurent Pinchart > > > > and applied to my tree, for v5.5. > > Hmm. This is in my tree as well. Would you like to drop it from yours? :-) Sure :-) I wonder if we should setup a shared git tree for this. -- Regards, Laurent Pinchart