All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Austin Kim <austindh.kim@gmail.com>,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	x86@kernel.org, dvhart@infradead.org, andy@infradead.org,
	hpa@zytor.com, allison@lohutok.net, armijn@tjaldur.nl,
	kjlu@umn.edu, platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/platform/uv: move kmalloc() NULL check routine
Date: Fri, 6 Sep 2019 12:43:41 +0200	[thread overview]
Message-ID: <20190906104341.GW2349@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190906093252.GB16843@kroah.com>

On Fri, Sep 06, 2019 at 11:32:52AM +0200, Greg KH wrote:
> On Fri, Sep 06, 2019 at 08:29:51AM +0900, Austin Kim wrote:
> > The result of kmalloc should have been checked ahead of below statement:
> > 	pqp = (struct bau_pq_entry *)vp;
> > 
> > Move BUG_ON(!vp) before above statement.
> > 
> > Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> > ---
> >  arch/x86/platform/uv/tlb_uv.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
> > index 20c389a..5f0a96bf 100644
> > --- a/arch/x86/platform/uv/tlb_uv.c
> > +++ b/arch/x86/platform/uv/tlb_uv.c
> > @@ -1804,9 +1804,9 @@ static void pq_init(int node, int pnode)
> >  
> >  	plsize = (DEST_Q_SIZE + 1) * sizeof(struct bau_pq_entry);
> >  	vp = kmalloc_node(plsize, GFP_KERNEL, node);
> > -	pqp = (struct bau_pq_entry *)vp;
> > -	BUG_ON(!pqp);
> > +	BUG_ON(!vp);
> 
> Ick!  Don't crash the whole machine if you are out of memory, that's a
> totally lazy and broken driver.  Fix this up properly please.

This is boot time init; if memory allocation fails, we're in trouble, no
way forward no way back.

It is not uncommon to have BUG_ON() for alloc failing during boot.

> But the original code is just fine (from a this is doing what I want it
> to do point of view), I don't see the need to change anything here, you
> did not modify any logic at all.

Agreed, the patch seems entirely pointless.

  reply	other threads:[~2019-09-06 10:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-05 23:29 Austin Kim
2019-09-05 23:29 ` Austin Kim
2019-09-06  9:32 ` Greg KH
2019-09-06 10:43   ` Peter Zijlstra [this message]
2019-09-06 10:53     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190906104341.GW2349@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=allison@lohutok.net \
    --cc=andy@infradead.org \
    --cc=armijn@tjaldur.nl \
    --cc=austindh.kim@gmail.com \
    --cc=bp@alien8.de \
    --cc=dvhart@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=kjlu@umn.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH] x86/platform/uv: move kmalloc() NULL check routine' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.